pass parameters with @_ instead of shift

This commit is contained in:
Milan
2024-01-01 20:15:42 +01:00
parent b93c4ee866
commit 115f4dca60
23 changed files with 55 additions and 112 deletions

View File

@@ -76,8 +76,7 @@ if ( defined $params->{action} ) {
show_series( $config, $request );
sub show_series {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -138,8 +137,7 @@ sub show_series {
}
sub assign_series {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -192,8 +190,7 @@ sub assign_series {
}
sub unassign_series {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -76,8 +76,7 @@ if ( defined $params->{action} ) {
show_events( $config, $request );
sub show_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -180,8 +179,7 @@ sub show_events {
}
sub assign_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -90,8 +90,7 @@ $config->{access}->{write} = 0;
showComments( $config, $request );
sub showComments {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -161,9 +160,7 @@ sub showComments {
}
sub modify_comments {
my $config = shift;
my $request = shift;
my $results = shift;
my ($config, $request, $results) = @_;
my $language = $config->{date}->{language} || 'en';
for my $result (@$results) {
@@ -176,8 +173,7 @@ sub modify_comments {
}
sub setLock {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -205,8 +201,7 @@ sub setLock {
}
sub setRead {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -72,8 +72,7 @@ if ( $params->{action} eq 'create_events' ) {
}
sub show_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -93,8 +92,7 @@ sub show_events {
}
sub create_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -122,8 +120,7 @@ sub create_events {
}
sub getDates {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -180,9 +177,7 @@ sub getDates {
}
sub createEvent {
my $config = shift;
my $request = shift;
my $date = shift;
my ($config, $request, $date) = @_;
my $permissions = $request->{permissions};
my $user = $request->{user};

View File

@@ -85,8 +85,7 @@ show_history( $config, $request );
#show existing event history
sub show_history {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -125,8 +124,7 @@ sub show_history {
#show existing event history
sub compare {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -255,9 +255,7 @@ sub print_js_error {
}
sub save_image {
my $config = shift;
my $request = shift;
my $user = shift;
my ($config, $request, $user) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -73,8 +73,7 @@ show_events( $config, $request );
#show existing event history
sub show_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -126,8 +125,7 @@ sub show_events {
}
sub sendMail {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -169,9 +167,7 @@ sub sendMail {
}
sub getMail {
my $config = shift;
my $request = shift;
my $event = shift;
my ($config, $request, $event) = @_;
my $users = series::get_users(
$config,

View File

@@ -75,8 +75,7 @@ if ( defined $params->{action} ) {
return;
sub deleteFromPlayout {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -15,13 +15,13 @@ msgid "button_upload"
msgstr "Vorproduktion hochladen"
msgid "button_create"
msgstr "Anlegen"
msgstr "Sendung anlegen"
msgid "button_save"
msgstr "Speichern"
msgstr "Sendung speichern"
msgid "button_delete"
msgstr "Löschen"
msgstr "Sendung löschen"
msgid "button_apply"
msgstr "Übernehmen"

View File

@@ -64,8 +64,7 @@ $config->{access}->{write} = 0;
show_projects( $config, $request );
sub delete_project {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{delete_project} == 1 ) {
@@ -95,8 +94,7 @@ sub delete_project {
}
sub save_project {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -144,8 +142,7 @@ sub save_project {
}
sub assign_studio {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -175,8 +172,7 @@ sub assign_studio {
# TODO: unassign series from studio
sub unassign_studio {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -205,8 +201,7 @@ sub unassign_studio {
}
sub show_projects {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -82,8 +82,7 @@ return;
# new roles will have role level 0 by default
#
sub save_roles {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -255,8 +254,7 @@ sub check_level {
# user has to be assigned to studio
# user needs to have permissions read_role
sub show_roles {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -60,8 +60,7 @@ show_events( $config, $request );
#TODO: filter by published, draft
sub show_events {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -64,8 +64,7 @@ unless ( $permissions->{read_series} == 1 ) {
show_series( $config, $request );
sub show_series {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -59,8 +59,7 @@ return unless uac::check( $config, $params, $user_presets ) == 1;
set_start_date( $config, $request );
sub set_start_date {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -54,8 +54,7 @@ showImage( $config, $request );
#TODO: filter by published, draft
sub showImage {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -73,8 +73,7 @@ template::process( $config, 'print', $params->{template}, $params );
exit;
sub showPlayout {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -85,8 +85,7 @@ return;
#insert or update a schedule and update all schedule dates
sub save_schedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{update_studio_timeslot_schedule} == 1 ) {
@@ -133,8 +132,7 @@ sub save_schedule {
}
sub delete_schedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{update_studio_timeslot_schedule} == 1 ) {
@@ -162,8 +160,7 @@ sub delete_schedule {
}
sub showTimeslotSchedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
$config->{access}->{write} = 0;
@@ -246,8 +243,7 @@ sub showTimeslotSchedule {
}
sub showDates {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
$config->{access}->{write} = 0;

View File

@@ -61,8 +61,7 @@ $config->{access}->{write} = 0;
show_studios( $config, $request );
sub delete_studio {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{update_studio} == 1 ) {
@@ -110,8 +109,7 @@ sub delete_studio {
}
sub save_studio {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -177,8 +175,7 @@ sub save_studio {
}
sub show_studios {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -67,9 +67,7 @@ sub get_value_fields {
}
sub log_event_selection {
my $config = shift;
my $request = shift;
my $user = shift;
my ($config, $request, $user) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -66,8 +66,7 @@ $config->{access}->{write} = 0;
show_settings( $config, $request );
sub show_settings {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -119,8 +118,7 @@ sub show_settings {
}
sub updateDefaultProjectStudio {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -168,8 +166,7 @@ sub updateDefaultProjectStudio {
}
sub update_settings {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -67,8 +67,7 @@ if ($params->{action} eq 'show-user-stats'){
};
sub show_user_stats {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -87,8 +86,7 @@ sub show_user_stats {
}
sub show_active_users{
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};

View File

@@ -68,8 +68,7 @@ $config->{access}->{write} = 0;
show_users( $config, $request );
sub show_users {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
@@ -170,8 +169,7 @@ sub show_users {
}
sub update_user {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -248,8 +246,7 @@ sub change_password {
}
sub delete_user {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{delete_user} == 1 ) {
@@ -265,8 +262,7 @@ sub delete_user {
# add or remove user from role for given studio_id
# todo: assign/unassign role oly if max(change user rank) is < max(users rank)
sub update_user_roles {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $permissions = $request->{permissions};
unless ( $permissions->{update_user_role} == 1 ) {

View File

@@ -69,8 +69,7 @@ return;
#insert or update a schedule and update all schedule dates
sub save_schedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
@@ -135,8 +134,7 @@ sub save_schedule {
}
sub delete_schedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
my $params = $request->{params}->{checked};
my $permissions = $request->{permissions};
@@ -163,8 +161,7 @@ sub delete_schedule {
}
sub show_work_schedule {
my $config = shift;
my $request = shift;
my ($config, $request) = @_;
$config->{access}->{write} = 0;