From 115f4dca60300140be9356fa007c7ee23b90e4b5 Mon Sep 17 00:00:00 2001
From: Milan <mc@radiopiloten.de>
Date: Mon, 1 Jan 2024 20:15:42 +0100
Subject: [PATCH] pass parameters with @_ instead of shift

---
 website/agenda/planung/assign-series.cgi       |  9 +++------
 website/agenda/planung/assignments.cgi         |  6 ++----
 website/agenda/planung/comment.cgi             | 13 ++++---------
 website/agenda/planung/create-events.cgi       | 13 ++++---------
 website/agenda/planung/event-history.cgi       |  6 ++----
 website/agenda/planung/image.cgi               |  4 +---
 website/agenda/planung/notify-events.cgi       | 10 +++-------
 website/agenda/planung/playout.cgi             |  3 +--
 website/agenda/planung/pot/de/event.po         |  6 +++---
 website/agenda/planung/projects.cgi            | 15 +++++----------
 website/agenda/planung/roles.cgi               |  6 ++----
 website/agenda/planung/select-event.cgi        |  3 +--
 website/agenda/planung/select-series.cgi       |  3 +--
 website/agenda/planung/set-user-day-start.cgi  |  3 +--
 website/agenda/planung/show-image.cgi          |  3 +--
 website/agenda/planung/show-playout.cgi        |  3 +--
 website/agenda/planung/studio-timeslots.cgi    | 12 ++++--------
 website/agenda/planung/studios.cgi             |  9 +++------
 website/agenda/planung/user-selected-event.cgi |  4 +---
 website/agenda/planung/user-settings.cgi       |  9 +++------
 website/agenda/planung/user-stats.cgi          |  6 ++----
 website/agenda/planung/users.cgi               | 12 ++++--------
 website/agenda/planung/work-time.cgi           |  9 +++------
 23 files changed, 55 insertions(+), 112 deletions(-)

diff --git a/website/agenda/planung/assign-series.cgi b/website/agenda/planung/assign-series.cgi
index 1c60f2e..f9868c5 100755
--- a/website/agenda/planung/assign-series.cgi
+++ b/website/agenda/planung/assign-series.cgi
@@ -76,8 +76,7 @@ if ( defined $params->{action} ) {
 show_series( $config, $request );
 
 sub show_series {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -138,8 +137,7 @@ sub show_series {
 }
 
 sub assign_series {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -192,8 +190,7 @@ sub assign_series {
 }
 
 sub unassign_series {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/assignments.cgi b/website/agenda/planung/assignments.cgi
index 1b12bb3..c6adba1 100755
--- a/website/agenda/planung/assignments.cgi
+++ b/website/agenda/planung/assignments.cgi
@@ -76,8 +76,7 @@ if ( defined $params->{action} ) {
 show_events( $config, $request );
 
 sub show_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -180,8 +179,7 @@ sub show_events {
 }
 
 sub assign_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/comment.cgi b/website/agenda/planung/comment.cgi
index 315b87c..dfbb92b 100755
--- a/website/agenda/planung/comment.cgi
+++ b/website/agenda/planung/comment.cgi
@@ -90,8 +90,7 @@ $config->{access}->{write} = 0;
 showComments( $config, $request );
 
 sub showComments {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -161,9 +160,7 @@ sub showComments {
 }
 
 sub modify_comments {
-    my $config  = shift;
-    my $request = shift;
-    my $results = shift;
+    my ($config, $request, $results) = @_;
 
     my $language = $config->{date}->{language} || 'en';
     for my $result (@$results) {
@@ -176,8 +173,7 @@ sub modify_comments {
 }
 
 sub setLock {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -205,8 +201,7 @@ sub setLock {
 }
 
 sub setRead {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/create-events.cgi b/website/agenda/planung/create-events.cgi
index 03860d6..bd3e5a0 100755
--- a/website/agenda/planung/create-events.cgi
+++ b/website/agenda/planung/create-events.cgi
@@ -72,8 +72,7 @@ if ( $params->{action} eq 'create_events' ) {
 }
 
 sub show_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -93,8 +92,7 @@ sub show_events {
 }
 
 sub create_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -122,8 +120,7 @@ sub create_events {
 }
 
 sub getDates {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -180,9 +177,7 @@ sub getDates {
 }
 
 sub createEvent {
-    my $config  = shift;
-    my $request = shift;
-    my $date    = shift;
+    my ($config, $request, $date) = @_;
 
     my $permissions = $request->{permissions};
     my $user        = $request->{user};
diff --git a/website/agenda/planung/event-history.cgi b/website/agenda/planung/event-history.cgi
index 57d5c35..f315e92 100755
--- a/website/agenda/planung/event-history.cgi
+++ b/website/agenda/planung/event-history.cgi
@@ -85,8 +85,7 @@ show_history( $config, $request );
 
 #show existing event history
 sub show_history {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -125,8 +124,7 @@ sub show_history {
 
 #show existing event history
 sub compare {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/image.cgi b/website/agenda/planung/image.cgi
index 5957f11..fb58b09 100755
--- a/website/agenda/planung/image.cgi
+++ b/website/agenda/planung/image.cgi
@@ -255,9 +255,7 @@ sub print_js_error {
 }
 
 sub save_image {
-    my $config  = shift;
-    my $request = shift;
-    my $user    = shift;
+    my ($config, $request, $user) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/notify-events.cgi b/website/agenda/planung/notify-events.cgi
index d9cfa7a..4e01d02 100755
--- a/website/agenda/planung/notify-events.cgi
+++ b/website/agenda/planung/notify-events.cgi
@@ -73,8 +73,7 @@ show_events( $config, $request );
 
 #show existing event history
 sub show_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -126,8 +125,7 @@ sub show_events {
 }
 
 sub sendMail {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -169,9 +167,7 @@ sub sendMail {
 }
 
 sub getMail {
-    my $config  = shift;
-    my $request = shift;
-    my $event   = shift;
+    my ($config, $request, $event) = @_;
 
     my $users = series::get_users(
         $config,
diff --git a/website/agenda/planung/playout.cgi b/website/agenda/planung/playout.cgi
index 9d123f5..170e88a 100755
--- a/website/agenda/planung/playout.cgi
+++ b/website/agenda/planung/playout.cgi
@@ -75,8 +75,7 @@ if ( defined $params->{action} ) {
 return;
 
 sub deleteFromPlayout {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/pot/de/event.po b/website/agenda/planung/pot/de/event.po
index 4b160fe..330ca90 100644
--- a/website/agenda/planung/pot/de/event.po
+++ b/website/agenda/planung/pot/de/event.po
@@ -15,13 +15,13 @@ msgid "button_upload"
 msgstr "Vorproduktion hochladen"
 
 msgid "button_create"
-msgstr "Anlegen"
+msgstr "Sendung anlegen"
 
 msgid "button_save"
-msgstr "Speichern"
+msgstr "Sendung speichern"
 
 msgid "button_delete"
-msgstr "Löschen"
+msgstr "Sendung löschen"
 
 msgid "button_apply"
 msgstr "Übernehmen"
diff --git a/website/agenda/planung/projects.cgi b/website/agenda/planung/projects.cgi
index 2db400f..304836f 100755
--- a/website/agenda/planung/projects.cgi
+++ b/website/agenda/planung/projects.cgi
@@ -64,8 +64,7 @@ $config->{access}->{write} = 0;
 show_projects( $config, $request );
 
 sub delete_project {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{delete_project} == 1 ) {
@@ -95,8 +94,7 @@ sub delete_project {
 }
 
 sub save_project {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -144,8 +142,7 @@ sub save_project {
 }
 
 sub assign_studio {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -175,8 +172,7 @@ sub assign_studio {
 
 # TODO: unassign series from studio
 sub unassign_studio {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -205,8 +201,7 @@ sub unassign_studio {
 }
 
 sub show_projects {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/roles.cgi b/website/agenda/planung/roles.cgi
index ba02fb1..9b187dd 100755
--- a/website/agenda/planung/roles.cgi
+++ b/website/agenda/planung/roles.cgi
@@ -82,8 +82,7 @@ return;
 # new roles will have role level 0 by default
 #
 sub save_roles {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -255,8 +254,7 @@ sub check_level {
 # user has to be assigned to studio
 # user needs to have permissions read_role
 sub show_roles {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/select-event.cgi b/website/agenda/planung/select-event.cgi
index 2ef481d..9bed4f0 100755
--- a/website/agenda/planung/select-event.cgi
+++ b/website/agenda/planung/select-event.cgi
@@ -60,8 +60,7 @@ show_events( $config, $request );
 
 #TODO: filter by published, draft
 sub show_events {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/select-series.cgi b/website/agenda/planung/select-series.cgi
index 56ef2a3..68d9db8 100755
--- a/website/agenda/planung/select-series.cgi
+++ b/website/agenda/planung/select-series.cgi
@@ -64,8 +64,7 @@ unless ( $permissions->{read_series} == 1 ) {
 show_series( $config, $request );
 
 sub show_series {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/set-user-day-start.cgi b/website/agenda/planung/set-user-day-start.cgi
index 0d5bacb..53b9a06 100644
--- a/website/agenda/planung/set-user-day-start.cgi
+++ b/website/agenda/planung/set-user-day-start.cgi
@@ -59,8 +59,7 @@ return unless uac::check( $config, $params, $user_presets ) == 1;
 set_start_date( $config, $request );
 
 sub set_start_date {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/show-image.cgi b/website/agenda/planung/show-image.cgi
index 1870773..ecef0e3 100755
--- a/website/agenda/planung/show-image.cgi
+++ b/website/agenda/planung/show-image.cgi
@@ -54,8 +54,7 @@ showImage( $config, $request );
 
 #TODO: filter by published, draft
 sub showImage {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/show-playout.cgi b/website/agenda/planung/show-playout.cgi
index 4d617a6..afb8482 100755
--- a/website/agenda/planung/show-playout.cgi
+++ b/website/agenda/planung/show-playout.cgi
@@ -73,8 +73,7 @@ template::process( $config, 'print', $params->{template}, $params );
 exit;
 
 sub showPlayout {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/studio-timeslots.cgi b/website/agenda/planung/studio-timeslots.cgi
index 91cf393..38981ce 100755
--- a/website/agenda/planung/studio-timeslots.cgi
+++ b/website/agenda/planung/studio-timeslots.cgi
@@ -85,8 +85,7 @@ return;
 
 #insert or update a schedule and update all schedule dates
 sub save_schedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{update_studio_timeslot_schedule} == 1 ) {
@@ -133,8 +132,7 @@ sub save_schedule {
 }
 
 sub delete_schedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{update_studio_timeslot_schedule} == 1 ) {
@@ -162,8 +160,7 @@ sub delete_schedule {
 }
 
 sub showTimeslotSchedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     $config->{access}->{write} = 0;
 
@@ -246,8 +243,7 @@ sub showTimeslotSchedule {
 }
 
 sub showDates {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     $config->{access}->{write} = 0;
 
diff --git a/website/agenda/planung/studios.cgi b/website/agenda/planung/studios.cgi
index 9017967..021cda8 100755
--- a/website/agenda/planung/studios.cgi
+++ b/website/agenda/planung/studios.cgi
@@ -61,8 +61,7 @@ $config->{access}->{write} = 0;
 show_studios( $config, $request );
 
 sub delete_studio {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{update_studio} == 1 ) {
@@ -110,8 +109,7 @@ sub delete_studio {
 }
 
 sub save_studio {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -177,8 +175,7 @@ sub save_studio {
 }
 
 sub show_studios {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/user-selected-event.cgi b/website/agenda/planung/user-selected-event.cgi
index 2a301cd..cdac151 100644
--- a/website/agenda/planung/user-selected-event.cgi
+++ b/website/agenda/planung/user-selected-event.cgi
@@ -67,9 +67,7 @@ sub get_value_fields {
 }
 
 sub log_event_selection {
-    my $config  = shift;
-    my $request = shift;
-    my $user    = shift;
+    my ($config, $request, $user) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/user-settings.cgi b/website/agenda/planung/user-settings.cgi
index d123ae8..f04643a 100755
--- a/website/agenda/planung/user-settings.cgi
+++ b/website/agenda/planung/user-settings.cgi
@@ -66,8 +66,7 @@ $config->{access}->{write} = 0;
 show_settings( $config, $request );
 
 sub show_settings {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -119,8 +118,7 @@ sub show_settings {
 }
 
 sub updateDefaultProjectStudio {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -168,8 +166,7 @@ sub updateDefaultProjectStudio {
 }
 
 sub update_settings {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/user-stats.cgi b/website/agenda/planung/user-stats.cgi
index ca26920..58acb39 100755
--- a/website/agenda/planung/user-stats.cgi
+++ b/website/agenda/planung/user-stats.cgi
@@ -67,8 +67,7 @@ if ($params->{action} eq 'show-user-stats'){
 };
 
 sub show_user_stats {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -87,8 +86,7 @@ sub show_user_stats {
 }
 
 sub show_active_users{
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
diff --git a/website/agenda/planung/users.cgi b/website/agenda/planung/users.cgi
index e25d6ac..c1eaef7 100755
--- a/website/agenda/planung/users.cgi
+++ b/website/agenda/planung/users.cgi
@@ -68,8 +68,7 @@ $config->{access}->{write} = 0;
 show_users( $config, $request );
 
 sub show_users {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params = $request->{params}->{checked};
 
@@ -170,8 +169,7 @@ sub show_users {
 }
 
 sub update_user {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -248,8 +246,7 @@ sub change_password {
 }
 
 sub delete_user {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{delete_user} == 1 ) {
@@ -265,8 +262,7 @@ sub delete_user {
 # add or remove user from role for given studio_id
 # todo: assign/unassign role oly if max(change user rank) is < max(users rank)
 sub update_user_roles {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $permissions = $request->{permissions};
     unless ( $permissions->{update_user_role} == 1 ) {
diff --git a/website/agenda/planung/work-time.cgi b/website/agenda/planung/work-time.cgi
index fee2fba..b1eca56 100755
--- a/website/agenda/planung/work-time.cgi
+++ b/website/agenda/planung/work-time.cgi
@@ -69,8 +69,7 @@ return;
 
 #insert or update a schedule and update all schedule dates
 sub save_schedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params = $request->{params}->{checked};
 
@@ -135,8 +134,7 @@ sub save_schedule {
 }
 
 sub delete_schedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     my $params      = $request->{params}->{checked};
     my $permissions = $request->{permissions};
@@ -163,8 +161,7 @@ sub delete_schedule {
 }
 
 sub show_work_schedule {
-    my $config  = shift;
-    my $request = shift;
+    my ($config, $request) = @_;
 
     $config->{access}->{write} = 0;