Update User_documentation_en.md

Adds a documentation how permissions are granted when sharing a board, based on code at ea4655b24e/lib/Service/PermissionService.php (L169)

Signed-off-by: Cyrille Bollu <StCyr@users.noreply.github.com>

.devcontainer/devcontainer.json

@@ -1,5 +1,5 @@
 {
-    "image": "ghcr.io/juliushaertl/nextcloud-dev-php81:latest",
+    "image": "ghcr.io/juliushaertl/nextcloud-dev-php80:latest",
     "forwardPorts": [80],
     "containerEnv": {
         "NEXTCLOUD_AUTOINSTALL_APPS": "deck",

.github/workflows/appbuild.yml

@@ -18,13 +18,13 @@ jobs:
     steps:
     - uses: actions/checkout@v4.1.7
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4.0.3
+      uses: actions/setup-node@v4.0.2
       with:
         node-version: ${{ matrix.node-version }}
     - name: Set up npm7
       run: npm i -g npm@7
     - name: Setup PHP
-      uses: shivammathur/setup-php@2.31.1
+      uses: shivammathur/setup-php@2.30.5
       with:
         php-version: '7.4'
         tools: composer

.github/workflows/appstore-build-publish.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
         # Skip if no package.json
         if: ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v3
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 
@@ -72,7 +72,7 @@ jobs:
           filename: ${{ env.APP_NAME }}/appinfo/info.xml
 
       - name: Set up php ${{ steps.php-versions.outputs.php-min }}
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: ${{ steps.php-versions.outputs.php-min }}
           coverage: none

.github/workflows/cypress.yml

@@ -41,7 +41,7 @@ jobs:
 
     steps:
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4.0.3
+        uses: actions/setup-node@v4.0.2
         with:
           node-version: ${{ matrix.node-version }}
 
@@ -91,7 +91,7 @@ jobs:
           restore-keys: ${{ steps.extcache.outputs.key }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@2.31.1
+        uses: shivammathur/setup-php@2.30.5
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: ${{ env.extensions }}

.github/workflows/integration.yml

@@ -78,7 +78,7 @@ jobs:
               path: apps/activity
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@2.31.1
+        uses: shivammathur/setup-php@2.30.5
         with:
           php-version: ${{ matrix.php-versions }}
           extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, mysql, pdo_mysql, pgsql, pdo_pgsql, apcu

.github/workflows/lint-eslint.yml

@@ -63,7 +63,7 @@ jobs:
           fallbackNpm: '^10'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v3
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/lint-php-cs.yml

@@ -25,7 +25,7 @@ jobs:
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
       - name: Set up php8.2
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: 8.2
           coverage: none

.github/workflows/lint-php.yml

@@ -28,7 +28,7 @@ jobs:
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: ${{ matrix.php-versions }}
           coverage: none

.github/workflows/lint-stylelint.yml

@@ -32,7 +32,7 @@ jobs:
           fallbackNpm: '^9'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v3
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/nodejs.yml

@@ -14,7 +14,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4.1.7
     - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4.0.3
+      uses: actions/setup-node@v4.0.2
       with:
         node-version: ${{ matrix.node-version }}
     - name: Set up npm7

.github/workflows/npm-audit-fix.yml

@@ -36,7 +36,7 @@ jobs:
           fallbackNpm: '^9'
 
       - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
-        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v3
+        uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v3
         with:
           node-version: ${{ steps.versions.outputs.nodeVersion }}
 

.github/workflows/phpunit-mysql.yml

@@ -92,7 +92,7 @@ jobs:
           path: apps/${{ env.APP_NAME }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: ${{ matrix.php-versions }}
           # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation

.github/workflows/phpunit-pgsql.yml

@@ -80,7 +80,7 @@ jobs:
           path: apps/${{ env.APP_NAME }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: ${{ matrix.php-versions }}
           # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation

.github/workflows/phpunit-sqlite.yml

@@ -69,7 +69,7 @@ jobs:
           path: apps/${{ env.APP_NAME }}
 
       - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: ${{ matrix.php-versions }}
           # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation

.github/workflows/psalm.yml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
       - name: Set up php8.2
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: 8.2
           coverage: none

.github/workflows/reuse.yml

@@ -9,14 +9,12 @@
 
 name: REUSE Compliance Check
 
-on: [pull_request]
+on: pull_request
 
 jobs:
   reuse-compliance-check:
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-
+    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
     - name: REUSE Compliance Check
-      uses: fsfe/reuse-action@3ae3c6bdf1257ab19397fab11fd3312144692083 # v4.0.0
+      uses: fsfe/reuse-action@a46482ca367aef4454a87620aa37c2be4b2f8106 # v3.0.0

.github/workflows/update-nextcloud-ocp-approve-merge.yml

@@ -43,7 +43,7 @@ jobs:
 
       # Enable GitHub auto merge
       - name: Auto merge
-        uses: alexwilson/enable-github-automerge-action@3a349b20acc6235b856fb0b1c95a36cb5373da2f # main
+        uses: alexwilson/enable-github-automerge-action@835faa041540d2234ea4530506a7abd42c847dfc # main
         if: startsWith(steps.branchname.outputs.branch, 'automated/noid/') && endsWith(steps.branchname.outputs.branch, 'update-nextcloud-ocp')
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/update-nextcloud-ocp.yml

@@ -31,7 +31,7 @@ jobs:
 
       - name: Set up php8.2
         if: steps.checkout.outcome == 'success'
-        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2
+        uses: shivammathur/setup-php@fc14643b0a99ee9db10a3c025a33d76544fa3761 # v2
         with:
           php-version: 8.2
           # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation

.reuse/dep5

@@ -0,0 +1,16 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: deck
+Upstream-Contact: Nextcloud <info@nextcloud.com>
+Source: https://github.com/nextcloud/deck
+
+Files: .gitattributes .github/* .editorconfig babel.config.js .php-cs-fixer.dist.php package-lock.json package.json composer.json composer.lock webpack.js stylelint.config.js .eslintrc.js .gitignore .jshintrc .l10nignore action/.gitignore action/package.json action/package-lock.json action/dist/index.js tests/* psalm.xml cypress/.env cypress/.eslintrc.js cypress/docker-compose.yml cypress/plugins/index.js cypress/tsconfig.json cypress.config.ts vendor-bin/*/composer.json stylelint.config.cjs vendor-bin/*/composer.lock .tx/config webpack.config.js tsconfig.json vite.config.ts js/vendor.LICENSE.txt krankerl.toml .npmignore cypress/fixtures/* postcss.config.js cypress/dockerNode.ts jest.config.js cypress.config.js relativeci.config.js .nextcloudignore .devcontainer/devcontainer.json
+Copyright: none
+License: CC0-1.0
+
+Files: l10n/*.js l10n/*.json js/*.js.map js/*.js js/*.mjs js/*.mjs.map js/templates/*.handlebars lib/Service/Importer/fixtures/config-deckJson-schema.json lib/Service/Importer/fixtures/config-trelloApi-schema.json lib/Service/Importer/fixtures/config-trelloJson-schema.json screenshots/screenshot1.png src/assets/file-placeholder.svg img/favicon.ico img/favicon.png img/favicon.svg img/activity.svg img/activity-dark.svg img/deck.svg img/deck-current.svg img/deck-dark.svg img/details-white.svg img/card.svg
+Copyright: 2019 Nextcloud GmbH and Nextcloud contributors
+License: AGPL-3.0-or-later
+
+Files: img/attach.svg img/description.svg img/details.svg img/toggle-view-expand.svg img/toggle-view-collapse.svg img/filter.svg img/filter_set.svg img/circles-dark.svg img/circles.svg img/color_picker.svg img/color_picker-dark.svg img/notifications-dark.svg img/archive.svg img/add-white.svg img/calendar-dark.svg img/calendar-white.svg
+Copyright: 2018-2024 Google LLC
+License: Apache-2.0

README.md

@@ -91,8 +91,8 @@ You can enable HMR (Hot module replacement) to avoid page reloads when working o
 ```
 docker run --rm \
     -p 8080:80 \
-    -v $PWD:/var/www/html/apps-extra/deck \
-    ghcr.io/juliushaertl/nextcloud-dev-php81:latest
+    -v ~/path/to/app:/var/www/html/apps-extra/app \
+    ghcr.io/juliushaertl/nextcloud-dev-php80:latest
 ```
 
 ### Full Nextcloud development environment

REUSE.toml

@@ -1,24 +0,0 @@
-# SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
-# SPDX-License-Identifier: AGPL-3.0-or-later
-version = 1
-SPDX-PackageName = "deck"
-SPDX-PackageSupplier = "Nextcloud <info@nextcloud.com>"
-SPDX-PackageDownloadLocation = "https://github.com/nextcloud/deck"
-
-[[annotations]]
-path = [".gitattributes", ".github/**", ".editorconfig", "babel.config.js", ".php-cs-fixer.dist.php", "package-lock.json", "package.json", "composer.json", "composer.lock", "webpack.js", "stylelint.config.js", ".eslintrc.js", ".gitignore", ".jshintrc", ".l10nignore", "action/.gitignore", "action/package.json", "action/package-lock.json", "action/dist/index.js", "tests/**", "psalm.xml", "cypress/.env", "cypress/.eslintrc.js", "cypress/docker-compose.yml", "cypress/plugins/index.js", "cypress/tsconfig.json", "cypress.config.ts", "vendor-bin/**/composer.json", "stylelint.config.cjs", "vendor-bin/**/composer.lock", ".tx/config", "webpack.config.js", "tsconfig.json", "vite.config.ts", "js/vendor.LICENSE.txt", "krankerl.toml", ".npmignore", "cypress/fixtures/**", "postcss.config.js", "cypress/dockerNode.ts", "jest.config.js", "cypress.config.js", "relativeci.config.js", ".nextcloudignore", ".devcontainer/devcontainer.json"]
-precedence = "aggregate"
-SPDX-FileCopyrightText = "none"
-SPDX-License-Identifier = "CC0-1.0"
-
-[[annotations]]
-path = ["l10n/**.js", "l10n/**.json", "js/**.js.map", "js/**.js", "js/**.mjs", "js/**.mjs.map", "js/templates/**.handlebars", "lib/Service/Importer/fixtures/config-deckJson-schema.json", "lib/Service/Importer/fixtures/config-trelloApi-schema.json", "lib/Service/Importer/fixtures/config-trelloJson-schema.json", "screenshots/screenshot1.png", "src/assets/file-placeholder.svg", "img/favicon.ico", "img/favicon.png", "img/favicon.svg", "img/activity.svg", "img/activity-dark.svg", "img/deck.svg", "img/deck-current.svg", "img/deck-dark.svg", "img/details-white.svg", "img/card.svg"]
-precedence = "aggregate"
-SPDX-FileCopyrightText = "2019 Nextcloud GmbH and Nextcloud contributors"
-SPDX-License-Identifier = "AGPL-3.0-or-later"
-
-[[annotations]]
-path = ["img/attach.svg", "img/description.svg", "img/details.svg", "img/toggle-view-expand.svg", "img/toggle-view-collapse.svg", "img/filter.svg", "img/filter_set.svg", "img/circles-dark.svg", "img/circles.svg", "img/color_picker.svg", "img/color_picker-dark.svg", "img/notifications-dark.svg", "img/archive.svg", "img/add-white.svg", "img/calendar-dark.svg", "img/calendar-white.svg"]
-precedence = "aggregate"
-SPDX-FileCopyrightText = "2018-2024 Google LLC"
-SPDX-License-Identifier = "Apache-2.0"

composer.lock

@@ -8,20 +8,20 @@
     "packages": [
         {
             "name": "justinrainbow/json-schema",
-            "version": "5.3.0",
+            "version": "v5.2.13",
             "source": {
                 "type": "git",
-                "url": "https://github.com/jsonrainbow/json-schema.git",
-                "reference": "feb2ca6dd1cebdaf1ed60a4c8de2e53ce11c4fd8"
+                "url": "https://github.com/justinrainbow/json-schema.git",
+                "reference": "fbbe7e5d79f618997bc3332a6f49246036c45793"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/jsonrainbow/json-schema/zipball/feb2ca6dd1cebdaf1ed60a4c8de2e53ce11c4fd8",
-                "reference": "feb2ca6dd1cebdaf1ed60a4c8de2e53ce11c4fd8",
+                "url": "https://api.github.com/repos/justinrainbow/json-schema/zipball/fbbe7e5d79f618997bc3332a6f49246036c45793",
+                "reference": "fbbe7e5d79f618997bc3332a6f49246036c45793",
                 "shasum": ""
             },
             "require": {
-                "php": ">=7.1"
+                "php": ">=5.3.3"
             },
             "require-dev": {
                 "friendsofphp/php-cs-fixer": "~2.2.20||~2.15.1",
@@ -32,6 +32,11 @@
                 "bin/validate-json"
             ],
             "type": "library",
+            "extra": {
+                "branch-alias": {
+                    "dev-master": "5.0.x-dev"
+                }
+            },
             "autoload": {
                 "psr-4": {
                     "JsonSchema\\": "src/JsonSchema/"
@@ -66,10 +71,10 @@
                 "schema"
             ],
             "support": {
-                "issues": "https://github.com/jsonrainbow/json-schema/issues",
-                "source": "https://github.com/jsonrainbow/json-schema/tree/5.3.0"
+                "issues": "https://github.com/justinrainbow/json-schema/issues",
+                "source": "https://github.com/justinrainbow/json-schema/tree/v5.2.13"
             },
-            "time": "2024-07-06T21:00:26+00:00"
+            "time": "2023-09-26T02:20:38+00:00"
         }
     ],
     "packages-dev": [
@@ -249,12 +254,12 @@
             "source": {
                 "type": "git",
                 "url": "https://github.com/nextcloud-deps/ocp.git",
-                "reference": "13c7fcd3f86213789ab064e3e1bf58e9d5133db6"
+                "reference": "bdeabb2fbb4691ac3d72dc27f56dd52aa6c61725"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/nextcloud-deps/ocp/zipball/13c7fcd3f86213789ab064e3e1bf58e9d5133db6",
-                "reference": "13c7fcd3f86213789ab064e3e1bf58e9d5133db6",
+                "url": "https://api.github.com/repos/nextcloud-deps/ocp/zipball/bdeabb2fbb4691ac3d72dc27f56dd52aa6c61725",
+                "reference": "bdeabb2fbb4691ac3d72dc27f56dd52aa6c61725",
                 "shasum": ""
             },
             "require": {
@@ -286,7 +291,7 @@
                 "issues": "https://github.com/nextcloud-deps/ocp/issues",
                 "source": "https://github.com/nextcloud-deps/ocp/tree/master"
             },
-            "time": "2024-07-13T00:37:22+00:00"
+            "time": "2024-06-18T00:36:38+00:00"
         },
         {
             "name": "nikic/php-parser",

css/deck.css

@@ -11,13 +11,3 @@
 	background-image: url(../img/deck.svg);
 	filter: var(--background-invert-if-dark);
 }
-
-input[type=submit].icon-confirm {
-	border-color: var(--color-border-maxcontrast) !important;
-	border-left: none;
-}
-
-input[type=text]:focus+input[type=submit].icon-confirm,
-input[type=text]:hover+input[type=submit].icon-confirm {
-	border-color: var(--color-main-text) !important;
-}

docs/index.md

@@ -1 +1,5 @@
+<!--
+  - SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
+-->
 ../README.md

docs/index.md.license

@@ -1,2 +0,0 @@
-SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
-SPDX-License-Identifier: AGPL-3.0-or-later

l10n/eu.js

@@ -321,16 +321,16 @@ OC.L10N.register(
     "Unarchive board" : "Atera taula artxibotik",
     "Archive board" : "Artxibatu taula",
     "Export board" : "Esportatu taula",
-    "Turn on due date reminders" : "Aktibatu epemuga gogorarazpenak",
-    "Turn off due date reminders" : "Desaktibatu epemuga gogorarazpenak",
-    "Due date reminders" : "Epemuga gogorarazpenak",
+    "Turn on due date reminders" : "Aktibatu epemugako abisuak",
+    "Turn off due date reminders" : "Desaktibatu epemugako abisuak",
+    "Due date reminders" : "Epemugako abisuak",
     "All cards" : "Txartel guztiak",
     "Assigned cards" : "Esleitutako txartelak",
     "No notifications" : "Jakinarazpenik ez",
     "Delete board" : "Ezabatu taula",
     "Board {0} deleted" : "{0} taula ezabatu da",
     "Only assigned cards" : "Bakarrik esleitutako txartelak",
-    "No reminder" : "Gogorarazpenik ez",
+    "No reminder" : "Abisurik ez",
     "An error occurred" : "Errore bat gertatu da",
     "Are you sure you want to delete the board {title}? This will delete all the data of this board including archived cards." : "Ziur zaude {title} taula ezabatu nahi duzula? Honek taula honen datu guztiak ezabatuko ditu, artxibatutako txartelak barne.",
     "Delete the board?" : "Taula ezabatu?",

l10n/eu.json

@@ -319,16 +319,16 @@
     "Unarchive board" : "Atera taula artxibotik",
     "Archive board" : "Artxibatu taula",
     "Export board" : "Esportatu taula",
-    "Turn on due date reminders" : "Aktibatu epemuga gogorarazpenak",
-    "Turn off due date reminders" : "Desaktibatu epemuga gogorarazpenak",
-    "Due date reminders" : "Epemuga gogorarazpenak",
+    "Turn on due date reminders" : "Aktibatu epemugako abisuak",
+    "Turn off due date reminders" : "Desaktibatu epemugako abisuak",
+    "Due date reminders" : "Epemugako abisuak",
     "All cards" : "Txartel guztiak",
     "Assigned cards" : "Esleitutako txartelak",
     "No notifications" : "Jakinarazpenik ez",
     "Delete board" : "Ezabatu taula",
     "Board {0} deleted" : "{0} taula ezabatu da",
     "Only assigned cards" : "Bakarrik esleitutako txartelak",
-    "No reminder" : "Gogorarazpenik ez",
+    "No reminder" : "Abisurik ez",
     "An error occurred" : "Errore bat gertatu da",
     "Are you sure you want to delete the board {title}? This will delete all the data of this board including archived cards." : "Ziur zaude {title} taula ezabatu nahi duzula? Honek taula honen datu guztiak ezabatuko ditu, artxibatutako txartelak barne.",
     "Delete the board?" : "Taula ezabatu?",

l10n/gl.js

@@ -43,8 +43,8 @@ OC.L10N.register(
     "{user} has marked the card {card} as undone in list {stack} on board {board}" : "{user} marcou a tarxeta {card} como sen facer na lista {stack} no taboleiro {board}",
     "You have removed the due date of card {card}" : "Vde. retirou a caducidade da tarxeta {card}",
     "{user} has removed the due date of card {card}" : "{user} retirou a caducidade da tarxeta {card}",
-    "You have set the due date of card {card} to {after}" : "Vde. definiu a caducidade da tarxeta {card} a {after}",
-    "{user} has set the due date of card {card} to {after}" : "{user} definiu a caducidade da tarxeta {card} a {after}",
+    "You have set the due date of card {card} to {after}" : "Vde. estabeleceu a caducidade da tarxeta {card} a {after}",
+    "{user} has set the due date of card {card} to {after}" : "{user} estabeleceu a caducidade da tarxeta {card} a {after}",
     "You have updated the due date of card {card} to {after}" : "Vde. actualizou a caducidade da tarxeta {card} a {after}",
     "{user} has updated the due date of card {card} to {after}" : "{user} actualizou a caducidade da tarxeta {card} a {after}",
     "You have added the tag {label} to card {card} in list {stack} on board {board}" : "Vde. engadiu a etiqueta {label} á tarxeta {card} na lista {stack} no taboleiro {board}",
@@ -117,7 +117,7 @@ OC.L10N.register(
     "This comment has more than %s characters.\nAdded as an attachment to the card with name %s.\nAccessible on URL: %s." : "Este comentario ten máis de %s caracteres.\nEngadido como anexo á tarxeta co nome %s.\nAccesíbel no URL: %s.",
     "Card not found" : "Non se atopou a tarxeta",
     "Path is already shared with this card" : "A ruta xa está compartida con esta tarxeta",
-    "Invalid date, date format must be YYYY-MM-DD" : "Data incorrecta, o formato da data debe ser AAAA-MM-DD",
+    "Invalid date, date format must be YYYY-MM-DD" : "Data incorrecta, o formato da date debe ser AAAA-MM-DD",
     "Personal planning and team project organization" : "Planificación persoal e organización de proxectos de equipo",
     "Deck is a kanban style organization tool aimed at personal planning and project organization for teams integrated with Nextcloud.\n\n\n- 📥 Add your tasks to cards and put them in order\n- 📄 Write down additional notes in Markdown\n- 🔖 Assign labels for even better organization\n- 👥 Share with your team, friends or family\n- 📎 Attach files and embed them in your Markdown description\n- 💬 Discuss with your team using comments\n- ⚡ Keep track of changes in the activity stream\n- 🚀 Get your project organized" : "Gabeta é unha ferramenta de organización de estilo kanban dirixida a planificación persoal e organización de proxectos para equipos integrados con Nextcloud. \n\n\n– 📥 Engada as súas tarefas ás tarxetas e fagas ordenadas\n– 📄 Escriba notas adicionais en Markdown\n– 🔖 Asigne etiquetas para unha mellor organización\n– 👥 Comparta co seu equipo, amigos ou a súa familia\n– 📎 Anexe ficheiros e integreos na súa descrición de Markdown\n– 💬 Debata co seu equipo usando os comentarios\n– ⚡ Faga un seguimento dos cambios no fluxo de actividade\n– 🚀 Teña o seu proxecto organizado",
     "Add board" : "Engadir taboleiro",
@@ -252,7 +252,7 @@ OC.L10N.register(
     "Write a description …" : "Escriba unha descrición…",
     "Choose attachment" : "Escoller o anexo",
     "Assign a due date to this card…" : "Asignar unha data de caducidade a esta tarxeta…",
-    "Set a due date" : "Definir a data de caducidade",
+    "Set a due date" : "Estabelecer a data de caducidade",
     "Add due date" : "Engadir a data de remate",
     "Choose a date" : "Escoller a data",
     "Remove due date" : "Retirar a data de caducidade",

l10n/gl.json

@@ -41,8 +41,8 @@
     "{user} has marked the card {card} as undone in list {stack} on board {board}" : "{user} marcou a tarxeta {card} como sen facer na lista {stack} no taboleiro {board}",
     "You have removed the due date of card {card}" : "Vde. retirou a caducidade da tarxeta {card}",
     "{user} has removed the due date of card {card}" : "{user} retirou a caducidade da tarxeta {card}",
-    "You have set the due date of card {card} to {after}" : "Vde. definiu a caducidade da tarxeta {card} a {after}",
-    "{user} has set the due date of card {card} to {after}" : "{user} definiu a caducidade da tarxeta {card} a {after}",
+    "You have set the due date of card {card} to {after}" : "Vde. estabeleceu a caducidade da tarxeta {card} a {after}",
+    "{user} has set the due date of card {card} to {after}" : "{user} estabeleceu a caducidade da tarxeta {card} a {after}",
     "You have updated the due date of card {card} to {after}" : "Vde. actualizou a caducidade da tarxeta {card} a {after}",
     "{user} has updated the due date of card {card} to {after}" : "{user} actualizou a caducidade da tarxeta {card} a {after}",
     "You have added the tag {label} to card {card} in list {stack} on board {board}" : "Vde. engadiu a etiqueta {label} á tarxeta {card} na lista {stack} no taboleiro {board}",
@@ -115,7 +115,7 @@
     "This comment has more than %s characters.\nAdded as an attachment to the card with name %s.\nAccessible on URL: %s." : "Este comentario ten máis de %s caracteres.\nEngadido como anexo á tarxeta co nome %s.\nAccesíbel no URL: %s.",
     "Card not found" : "Non se atopou a tarxeta",
     "Path is already shared with this card" : "A ruta xa está compartida con esta tarxeta",
-    "Invalid date, date format must be YYYY-MM-DD" : "Data incorrecta, o formato da data debe ser AAAA-MM-DD",
+    "Invalid date, date format must be YYYY-MM-DD" : "Data incorrecta, o formato da date debe ser AAAA-MM-DD",
     "Personal planning and team project organization" : "Planificación persoal e organización de proxectos de equipo",
     "Deck is a kanban style organization tool aimed at personal planning and project organization for teams integrated with Nextcloud.\n\n\n- 📥 Add your tasks to cards and put them in order\n- 📄 Write down additional notes in Markdown\n- 🔖 Assign labels for even better organization\n- 👥 Share with your team, friends or family\n- 📎 Attach files and embed them in your Markdown description\n- 💬 Discuss with your team using comments\n- ⚡ Keep track of changes in the activity stream\n- 🚀 Get your project organized" : "Gabeta é unha ferramenta de organización de estilo kanban dirixida a planificación persoal e organización de proxectos para equipos integrados con Nextcloud. \n\n\n– 📥 Engada as súas tarefas ás tarxetas e fagas ordenadas\n– 📄 Escriba notas adicionais en Markdown\n– 🔖 Asigne etiquetas para unha mellor organización\n– 👥 Comparta co seu equipo, amigos ou a súa familia\n– 📎 Anexe ficheiros e integreos na súa descrición de Markdown\n– 💬 Debata co seu equipo usando os comentarios\n– ⚡ Faga un seguimento dos cambios no fluxo de actividade\n– 🚀 Teña o seu proxecto organizado",
     "Add board" : "Engadir taboleiro",
@@ -250,7 +250,7 @@
     "Write a description …" : "Escriba unha descrición…",
     "Choose attachment" : "Escoller o anexo",
     "Assign a due date to this card…" : "Asignar unha data de caducidade a esta tarxeta…",
-    "Set a due date" : "Definir a data de caducidade",
+    "Set a due date" : "Estabelecer a data de caducidade",
     "Add due date" : "Engadir a data de remate",
     "Choose a date" : "Escoller a data",
     "Remove due date" : "Retirar a data de caducidade",

l10n/ja.js

@@ -37,10 +37,6 @@ OC.L10N.register(
     "{user} has archived card {card} in list {stack} on board {board}" : "{user}がボード{board}のリスト{stack}にカード{card}をアーカイブしました",
     "You have unarchived card {card} in list {stack} on board {board}" : "ボード {board}のリスト {stack}にあるカード {card} をアーカイブ解除しました",
     "{user} has unarchived card {card} in list {stack} on board {board}" : "{user}がボード {board}のリスト {stack}にあるカード {card} をアーカイブ解除しました",
-    "You have marked the card {card} as done in list {stack} on board {board}" : "ボード{board}のリスト{stack}で、カード{card}に完了のマークを付けました。",
-    "{user} has marked card {card} as done in list {stack} on board {board}" : "{user}は、ボード{board}のリスト{stack}で、カード{card}に完了のマークを付けました。",
-    "You have marked the card {card} as undone in list {stack} on board {board}" : "ボード{board}のリスト{stack}でカード{card}に未完成のマークを付けました。",
-    "{user} has marked the card {card} as undone in list {stack} on board {board}" : "{user}は、ボード{board}のリスト{stack}でカード{card}に未完成のマークを付けました。",
     "You have removed the due date of card {card}" : "カード{card}の期日を削除しました",
     "{user} has removed the due date of card {card}" : "{user}がカード{card}の期日を削除しました",
     "You have set the due date of card {card} to {after}" : "カード{card}の期日を{after}に設定しました",
@@ -149,7 +145,6 @@ OC.L10N.register(
     "Filter by tag" : "タグによるフィルター",
     "Filter by assigned user" : "割当ユーザーでフィルター",
     "Unassigned" : "未割り当て",
-    "Filter by status" : "ステータスによるフィルター",
     "Open and completed" : "開いて完成",
     "Open" : "開く",
     "Completed" : "完了",
@@ -315,7 +310,6 @@ OC.L10N.register(
     "Show card ID badge" : "カードIDバジを表示",
     "Show boards in calendar/tasks" : "カレンダー/タスクでボードを表示する",
     "Limit board creation to some groups" : "ボード作成は一部のグループに制限する",
-    "Users outside of those groups will not be able to create their own boards, but will still be able to work on boards that have been shared with them." : "これらのグループ以外のユーザーは、独自のボードを作成することはできませんが、共有されているボードで作業することはできます。",
     "Board details" : "ボードの詳細",
     "Edit board" : "ボードを編集",
     "Clone board" : "ボードを複製",
@@ -333,7 +327,6 @@ OC.L10N.register(
     "Only assigned cards" : "割り当てられたカードのみ",
     "No reminder" : "リマインダーなし",
     "An error occurred" : "エラーが発生しました",
-    "Are you sure you want to delete the board {title}? This will delete all the data of this board including archived cards." : "ボード{title}を削除しますか? これにより、アーカイブされたカードを含むこのボードのすべてのデータが削除されます。",
     "Delete the board?" : "ボードを削除しますか？",
     "Loading filtered view" : "フィルタされたビューを読み込み中",
     "Today" : "今日",
@@ -345,7 +338,6 @@ OC.L10N.register(
     "Deck board {name}\n* Last modified on {lastMod}" : "デッキボード{name}\n最終更新日：{lastMod}",
     "{stack} in {board}" : "{board} 内の {stack}",
     "Click to expand description" : "説明を展開するにはクリックしてください",
-    "* Created on {created}\n* Last modified on {lastMod}\n* {nbAttachments} attachments\n* {nbComments} comments" : "* 作成: {created}\n* 最終変更: {lastMod}\n* {nbAttachments} 添付ファイル\n* {nbComments} コメント",
     "{nbCards} cards" : "{nbCards} カード",
     "Click to expand comment" : "コメントを展開するにはクリックしてください",
     "Create a new card" : "新しいカードを作成する",

l10n/ja.json

@@ -35,10 +35,6 @@
     "{user} has archived card {card} in list {stack} on board {board}" : "{user}がボード{board}のリスト{stack}にカード{card}をアーカイブしました",
     "You have unarchived card {card} in list {stack} on board {board}" : "ボード {board}のリスト {stack}にあるカード {card} をアーカイブ解除しました",
     "{user} has unarchived card {card} in list {stack} on board {board}" : "{user}がボード {board}のリスト {stack}にあるカード {card} をアーカイブ解除しました",
-    "You have marked the card {card} as done in list {stack} on board {board}" : "ボード{board}のリスト{stack}で、カード{card}に完了のマークを付けました。",
-    "{user} has marked card {card} as done in list {stack} on board {board}" : "{user}は、ボード{board}のリスト{stack}で、カード{card}に完了のマークを付けました。",
-    "You have marked the card {card} as undone in list {stack} on board {board}" : "ボード{board}のリスト{stack}でカード{card}に未完成のマークを付けました。",
-    "{user} has marked the card {card} as undone in list {stack} on board {board}" : "{user}は、ボード{board}のリスト{stack}でカード{card}に未完成のマークを付けました。",
     "You have removed the due date of card {card}" : "カード{card}の期日を削除しました",
     "{user} has removed the due date of card {card}" : "{user}がカード{card}の期日を削除しました",
     "You have set the due date of card {card} to {after}" : "カード{card}の期日を{after}に設定しました",
@@ -147,7 +143,6 @@
     "Filter by tag" : "タグによるフィルター",
     "Filter by assigned user" : "割当ユーザーでフィルター",
     "Unassigned" : "未割り当て",
-    "Filter by status" : "ステータスによるフィルター",
     "Open and completed" : "開いて完成",
     "Open" : "開く",
     "Completed" : "完了",
@@ -313,7 +308,6 @@
     "Show card ID badge" : "カードIDバジを表示",
     "Show boards in calendar/tasks" : "カレンダー/タスクでボードを表示する",
     "Limit board creation to some groups" : "ボード作成は一部のグループに制限する",
-    "Users outside of those groups will not be able to create their own boards, but will still be able to work on boards that have been shared with them." : "これらのグループ以外のユーザーは、独自のボードを作成することはできませんが、共有されているボードで作業することはできます。",
     "Board details" : "ボードの詳細",
     "Edit board" : "ボードを編集",
     "Clone board" : "ボードを複製",
@@ -331,7 +325,6 @@
     "Only assigned cards" : "割り当てられたカードのみ",
     "No reminder" : "リマインダーなし",
     "An error occurred" : "エラーが発生しました",
-    "Are you sure you want to delete the board {title}? This will delete all the data of this board including archived cards." : "ボード{title}を削除しますか? これにより、アーカイブされたカードを含むこのボードのすべてのデータが削除されます。",
     "Delete the board?" : "ボードを削除しますか？",
     "Loading filtered view" : "フィルタされたビューを読み込み中",
     "Today" : "今日",
@@ -343,7 +336,6 @@
     "Deck board {name}\n* Last modified on {lastMod}" : "デッキボード{name}\n最終更新日：{lastMod}",
     "{stack} in {board}" : "{board} 内の {stack}",
     "Click to expand description" : "説明を展開するにはクリックしてください",
-    "* Created on {created}\n* Last modified on {lastMod}\n* {nbAttachments} attachments\n* {nbComments} comments" : "* 作成: {created}\n* 最終変更: {lastMod}\n* {nbAttachments} 添付ファイル\n* {nbComments} コメント",
     "{nbCards} cards" : "{nbCards} カード",
     "Click to expand comment" : "コメントを展開するにはクリックしてください",
     "Create a new card" : "新しいカードを作成する",

l10n/nb.js

@@ -149,7 +149,6 @@ OC.L10N.register(
     "Filter by tag" : "Filtrer på knagg",
     "Filter by assigned user" : "Filtrer på tildelt bruker",
     "Unassigned" : "Ikke tildelt",
-    "Filter by status" : "Filtrer etter status",
     "Open and completed" : "Åpen og fullført",
     "Open" : "Åpne",
     "Completed" : "Ferdig",
@@ -258,7 +257,6 @@ OC.L10N.register(
     "Remove due date" : "Fjern forfallsdato",
     "Mark as done" : "Marker som fullført",
     "Due at:" : "Forfaller den:",
-    "Not done" : "Ikke fullført",
     "Unarchive card" : "Hent kort fra arkiv",
     "Archive card" : "Arkiver kort",
     "Select Date" : "Velg dato",

l10n/nb.json

@@ -147,7 +147,6 @@
     "Filter by tag" : "Filtrer på knagg",
     "Filter by assigned user" : "Filtrer på tildelt bruker",
     "Unassigned" : "Ikke tildelt",
-    "Filter by status" : "Filtrer etter status",
     "Open and completed" : "Åpen og fullført",
     "Open" : "Åpne",
     "Completed" : "Ferdig",
@@ -256,7 +255,6 @@
     "Remove due date" : "Fjern forfallsdato",
     "Mark as done" : "Marker som fullført",
     "Due at:" : "Forfaller den:",
-    "Not done" : "Ikke fullført",
     "Unarchive card" : "Hent kort fra arkiv",
     "Archive card" : "Arkiver kort",
     "Select Date" : "Velg dato",

l10n/sl.js

@@ -129,13 +129,10 @@ OC.L10N.register(
     "Archived cards" : "Arhivirane naloge",
     "Add list" : "Dodaj seznam",
     "List name" : "Ime seznama",
-    "Active filters" : "Dejavni filtri",
     "Apply filter" : "Uveljavi filter",
     "Filter by tag" : "Filtriraj po oznaki",
     "Filter by assigned user" : "Filtriraj po dodeljenem uporabniku",
     "Unassigned" : "Nedodeljeno",
-    "Filter by status" : "Filtri po stanju",
-    "Open and completed" : "Odprto in končano",
     "Open" : "Odpri",
     "Completed" : "Končano",
     "Filter by due date" : "Filtriraj po datumu preteka",
@@ -145,8 +142,6 @@ OC.L10N.register(
     "Next 30 days" : "Naslednjih 30 dni",
     "No due date" : "Ni datuma preteka",
     "Clear filter" : "Počisti filter",
-    "View Modes" : "Načini pogleda",
-    "Toggle View Modes" : "Preklopi načine pogleda",
     "Hide archived cards" : "Skrij arhivirane naloge",
     "Show archived cards" : "Prikaži arhivirane naloge",
     "Toggle compact mode" : "Preklopi način prikaza",

l10n/sl.json

@@ -127,13 +127,10 @@
     "Archived cards" : "Arhivirane naloge",
     "Add list" : "Dodaj seznam",
     "List name" : "Ime seznama",
-    "Active filters" : "Dejavni filtri",
     "Apply filter" : "Uveljavi filter",
     "Filter by tag" : "Filtriraj po oznaki",
     "Filter by assigned user" : "Filtriraj po dodeljenem uporabniku",
     "Unassigned" : "Nedodeljeno",
-    "Filter by status" : "Filtri po stanju",
-    "Open and completed" : "Odprto in končano",
     "Open" : "Odpri",
     "Completed" : "Končano",
     "Filter by due date" : "Filtriraj po datumu preteka",
@@ -143,8 +140,6 @@
     "Next 30 days" : "Naslednjih 30 dni",
     "No due date" : "Ni datuma preteka",
     "Clear filter" : "Počisti filter",
-    "View Modes" : "Načini pogleda",
-    "Toggle View Modes" : "Preklopi načine pogleda",
     "Hide archived cards" : "Skrij arhivirane naloge",
     "Show archived cards" : "Prikaži arhivirane naloge",
     "Toggle compact mode" : "Preklopi način prikaza",

l10n/sr.js

@@ -117,7 +117,7 @@ OC.L10N.register(
     "This comment has more than %s characters.\nAdded as an attachment to the card with name %s.\nAccessible on URL: %s." : "Овај коментар има више од %s карактера.\nДодат је као прилог картици под именом %s.\nДоступно је на URL адреси: %s.",
     "Card not found" : "Картица није нађена",
     "Path is already shared with this card" : "Путања се већ дели са овом картицом",
-    "Invalid date, date format must be YYYY-MM-DD" : "Неисправан датум, формат датума мора бити ГГГГ-ММ-ДД",
+    "Invalid date, date format must be YYYY-MM-DD" : "Неисправан датим, формат датума мора бити ГГГГ-ММ-ДД",
     "Personal planning and team project organization" : "Лични планер и организатор тимског пројекта",
     "Deck is a kanban style organization tool aimed at personal planning and project organization for teams integrated with Nextcloud.\n\n\n- 📥 Add your tasks to cards and put them in order\n- 📄 Write down additional notes in Markdown\n- 🔖 Assign labels for even better organization\n- 👥 Share with your team, friends or family\n- 📎 Attach files and embed them in your Markdown description\n- 💬 Discuss with your team using comments\n- ⚡ Keep track of changes in the activity stream\n- 🚀 Get your project organized" : "Шпил је организациони алат у канбан стилу који је намењен личном планирању и организацији пројекта у тимовима интегрисаним са Nextcloud.\n\n\n- 📥 Додајте своје задатке у картице и поређајте их по редоследу\n- 📄 Напишите додатне белешке употребом Markdown синтаксе\n- 🔖 Доделите ознаке у циљу још боље организације\n- 👥 Делите са својим тимом, пријатељима или породицом\n- 📎 Прикачите фајлове и уградите их у свој Markdown опис\n- 💬 Дискутујте са својим тимом користећи коментаре\n- ⚡ Пратите измене у току активности\n- 🚀 Организујте свој пројекат",
     "Add board" : "Додај таблу",

l10n/sr.json

@@ -115,7 +115,7 @@
     "This comment has more than %s characters.\nAdded as an attachment to the card with name %s.\nAccessible on URL: %s." : "Овај коментар има више од %s карактера.\nДодат је као прилог картици под именом %s.\nДоступно је на URL адреси: %s.",
     "Card not found" : "Картица није нађена",
     "Path is already shared with this card" : "Путања се већ дели са овом картицом",
-    "Invalid date, date format must be YYYY-MM-DD" : "Неисправан датум, формат датума мора бити ГГГГ-ММ-ДД",
+    "Invalid date, date format must be YYYY-MM-DD" : "Неисправан датим, формат датума мора бити ГГГГ-ММ-ДД",
     "Personal planning and team project organization" : "Лични планер и организатор тимског пројекта",
     "Deck is a kanban style organization tool aimed at personal planning and project organization for teams integrated with Nextcloud.\n\n\n- 📥 Add your tasks to cards and put them in order\n- 📄 Write down additional notes in Markdown\n- 🔖 Assign labels for even better organization\n- 👥 Share with your team, friends or family\n- 📎 Attach files and embed them in your Markdown description\n- 💬 Discuss with your team using comments\n- ⚡ Keep track of changes in the activity stream\n- 🚀 Get your project organized" : "Шпил је организациони алат у канбан стилу који је намењен личном планирању и организацији пројекта у тимовима интегрисаним са Nextcloud.\n\n\n- 📥 Додајте своје задатке у картице и поређајте их по редоследу\n- 📄 Напишите додатне белешке употребом Markdown синтаксе\n- 🔖 Доделите ознаке у циљу још боље организације\n- 👥 Делите са својим тимом, пријатељима или породицом\n- 📎 Прикачите фајлове и уградите их у свој Markdown опис\n- 💬 Дискутујте са својим тимом користећи коментаре\n- ⚡ Пратите измене у току активности\n- 🚀 Организујте свој пројекат",
     "Add board" : "Додај таблу",

lib/Activity/CommentEventHandler.php

@@ -1,37 +1,43 @@
 <?php
-
-declare(strict_types=1);
 /**
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-namespace OCA\Deck\Listeners;
+namespace OCA\Deck\Activity;
 
-use OCA\Deck\Activity\ActivityManager;
 use OCA\Deck\Db\CardMapper;
 use OCA\Deck\Db\ChangeHelper;
 use OCA\Deck\Notification\NotificationHelper;
 use OCP\Comments\CommentsEvent;
-use OCP\EventDispatcher\Event;
-use OCP\EventDispatcher\IEventListener;
+use OCP\Comments\IComment;
+use OCP\Comments\ICommentsEventHandler;
 
-/** @template-implements IEventListener<CommentsEvent|Event> */
-class CommentEventListener implements IEventListener {
+class CommentEventHandler implements ICommentsEventHandler {
 
-	public function __construct(
-		private ActivityManager $activityManager,
-		private NotificationHelper $notificationHelper,
-		private CardMapper $cardMapper,
-		private ChangeHelper $changeHelper,
-	) {
+	/** @var ActivityManager */
+	private $activityManager;
+
+	/** @var NotificationHelper */
+	private $notificationHelper;
+
+	/** @var CardMapper */
+	private $cardMapper;
+
+	/** @var ChangeHelper */
+	private $changeHelper;
+
+	public function __construct(ActivityManager $activityManager, NotificationHelper $notificationHelper, CardMapper $cardMapper, ChangeHelper $changeHelper) {
+		$this->notificationHelper = $notificationHelper;
+		$this->activityManager = $activityManager;
+		$this->cardMapper = $cardMapper;
+		$this->changeHelper = $changeHelper;
 	}
 
-	public function handle(Event $event): void {
-		if (!$event instanceof CommentsEvent) {
-			return;
-		}
-
+	/**
+	 * @param CommentsEvent $event
+	 */
+	public function handle(CommentsEvent $event) {
 		if ($event->getComment()->getObjectType() !== 'deckCard') {
 			return;
 		}
@@ -55,13 +61,20 @@ class CommentEventListener implements IEventListener {
 		}
 	}
 
-	private function activityHandler(CommentsEvent $event): void {
+	/**
+	 * @param CommentsEvent $event
+	 */
+	private function activityHandler(CommentsEvent $event) {
+		/** @var IComment $comment */
 		$comment = $event->getComment();
 		$card = $this->cardMapper->find($comment->getObjectId());
 		$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_CARD, $card, ActivityManager::SUBJECT_CARD_COMMENT_CREATE, ['comment' => $comment]);
 	}
 
-	private function notificationHandler(CommentsEvent $event): void {
+	/**
+	 * @param CommentsEvent $event
+	 */
+	private function notificationHandler(CommentsEvent $event) {
 		$this->notificationHelper->sendMention($event->getComment());
 	}
 }

lib/AppInfo/Application.php

@@ -9,6 +9,7 @@ namespace OCA\Deck\AppInfo;
 use Closure;
 use Exception;
 use OCA\Circles\Events\CircleDestroyedEvent;
+use OCA\Deck\Activity\CommentEventHandler;
 use OCA\Deck\Capabilities;
 use OCA\Deck\Collaboration\Resources\ResourceProvider;
 use OCA\Deck\Collaboration\Resources\ResourceProviderCard;
@@ -27,7 +28,6 @@ use OCA\Deck\Event\CardUpdatedEvent;
 use OCA\Deck\Event\SessionClosedEvent;
 use OCA\Deck\Event\SessionCreatedEvent;
 use OCA\Deck\Listeners\BeforeTemplateRenderedListener;
-use OCA\Deck\Listeners\CommentEventListener;
 use OCA\Deck\Listeners\FullTextSearchEventListener;
 use OCA\Deck\Listeners\LiveUpdateListener;
 use OCA\Deck\Listeners\ParticipantCleanupListener;
@@ -56,7 +56,7 @@ use OCP\Collaboration\Reference\RenderReferenceEvent;
 use OCP\Collaboration\Resources\IProviderManager;
 use OCP\Collaboration\Resources\LoadAdditionalScriptsEvent;
 use OCP\Comments\CommentsEntityEvent;
-use OCP\Comments\CommentsEvent;
+use OCP\Comments\ICommentsManager;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Group\Events\GroupDeletedEvent;
 use OCP\IConfig;
@@ -91,6 +91,7 @@ class Application extends App implements IBootstrap {
 
 	public function boot(IBootContext $context): void {
 		$context->injectFn(Closure::fromCallable([$this, 'registerCommentsEntity']));
+		$context->injectFn(Closure::fromCallable([$this, 'registerCommentsEventHandler']));
 		$context->injectFn(Closure::fromCallable([$this, 'registerCollaborationResources']));
 
 		$context->injectFn(function (IManager $shareManager) {
@@ -140,7 +141,6 @@ class Application extends App implements IBootstrap {
 		$context->registerEventListener(AclCreatedEvent::class, FullTextSearchEventListener::class);
 		$context->registerEventListener(AclUpdatedEvent::class, FullTextSearchEventListener::class);
 		$context->registerEventListener(AclDeletedEvent::class, FullTextSearchEventListener::class);
-		$context->registerEventListener(CommentsEvent::class, CommentEventListener::class);
 
 		// Handling cache invalidation for collections
 		$context->registerEventListener(AclCreatedEvent::class, ResourceListener::class);
@@ -184,6 +184,12 @@ class Application extends App implements IBootstrap {
 		});
 	}
 
+	protected function registerCommentsEventHandler(ICommentsManager $commentsManager): void {
+		$commentsManager->registerEventHandler(function () {
+			return $this->getContainer()->query(CommentEventHandler::class);
+		});
+	}
+
 	protected function registerCollaborationResources(IProviderManager $resourceManager): void {
 		$resourceManager->registerResourceProvider(ResourceProvider::class);
 		$resourceManager->registerResourceProvider(ResourceProviderCard::class);

lib/Db/CardMapper.php

@@ -113,7 +113,7 @@ class CardMapper extends QBMapper implements IPermissionMapper {
 		return parent::update($cardUpdate);
 	}
 
-	public function find($id, bool $enhance = true): Card {
+	public function find($id): Card {
 		$qb = $this->db->getQueryBuilder();
 		$qb->select('*')
 			->from('deck_cards')
@@ -122,11 +122,9 @@ class CardMapper extends QBMapper implements IPermissionMapper {
 			->addOrderBy('id');
 		/** @var Card $card */
 		$card = $this->findEntity($qb);
-		if ($enhance) {
-			$labels = $this->labelMapper->findAssignedLabelsForCard($card->getId());
-			$card->setLabels($labels);
-			$this->mapOwner($card);
-		}
+		$labels = $this->labelMapper->findAssignedLabelsForCard($card->getId());
+		$card->setLabels($labels);
+		$this->mapOwner($card);
 		return $card;
 	}
 
@@ -562,15 +560,12 @@ class CardMapper extends QBMapper implements IPermissionMapper {
 	}
 
 	public function isOwner($userId, $id): bool {
-		$qb = $this->db->getQueryBuilder();
-		$qb->select('c.id')
-			->from($this->getTableName(), 'c')
-			->innerJoin('c', 'deck_stacks', 's', 'c.stack_id = s.id')
-			->innerJoin('s', 'deck_boards', 'b', 'b.id = s.board_id')
-			->where($qb->expr()->eq('c.id', $qb->createNamedParameter($id, IQueryBuilder::PARAM_INT)))
-			->andWhere($qb->expr()->eq('b.owner', $qb->createNamedParameter($userId, IQueryBuilder::PARAM_STR)));
-
-		return count($qb->executeQuery()->fetchAll()) > 0;
+		$sql = 'SELECT owner FROM `*PREFIX*deck_boards` WHERE `id` IN (SELECT board_id FROM `*PREFIX*deck_stacks` WHERE id IN (SELECT stack_id FROM `*PREFIX*deck_cards` WHERE id = ?))';
+		$stmt = $this->db->prepare($sql);
+		$stmt->bindParam(1, $id, \PDO::PARAM_INT, 0);
+		$stmt->execute();
+		$row = $stmt->fetch();
+		return ($row['owner'] === $userId);
 	}
 
 	public function findBoardId($id): ?int {

lib/Service/PermissionService.php

@@ -119,7 +119,7 @@ class PermissionService {
 		if ($permissions[$permission] === true) {
 
 			if (!$allowDeletedCard && $mapper instanceof CardMapper) {
-				$card = $mapper->find((int)$id, false);
+				$card = $mapper->find((int)$id);
 				if ($card->getDeletedAt() > 0) {
 					throw new NoPermissionException('Card is deleted');
 				}

lib/Sharing/DeckShareProvider.php

@@ -831,7 +831,7 @@ class DeckShareProvider implements \OCP\Share\IShareProvider {
 		$pathSections = explode('/', $data['path'], 2);
 		// FIXME: would not detect rare md5'd home storage case properly
 		if ($pathSections[0] !== 'files'
-			&& (strpos($data['storage_string_id'], 'home::') === 0 || strpos($data['storage_string_id'], 'object::user') === 0)) {
+			&& in_array(explode(':', $data['storage_string_id'], 2)[0], ['home', 'object'])) {
 			return false;
 		}
 		return true;

package-lock.json

@@ -10,11 +10,11 @@
       "license": "agpl",
       "dependencies": {
         "@babel/polyfill": "^7.12.1",
-        "@babel/runtime": "^7.24.8",
+        "@babel/runtime": "^7.24.7",
         "@nextcloud/auth": "^2.3.0",
         "@nextcloud/axios": "^2.5.0",
         "@nextcloud/capabilities": "^1.2.0",
-        "@nextcloud/dialogs": "^5.3.5",
+        "@nextcloud/dialogs": "^5.3.3",
         "@nextcloud/event-bus": "^3.3.1",
         "@nextcloud/files": "^3.5.1",
         "@nextcloud/initial-state": "^2.2.0",
@@ -22,10 +22,10 @@
         "@nextcloud/moment": "^1.3.1",
         "@nextcloud/notify_push": "^1.3.0",
         "@nextcloud/router": "^3.0.1",
-        "@nextcloud/vue": "^8.14.0",
+        "@nextcloud/vue": "^8.12.0",
         "blueimp-md5": "^2.19.0",
         "chroma-js": "^2.4.2",
-        "dompurify": "^3.1.6",
+        "dompurify": "^3.1.5",
         "lodash": "^4.17.21",
         "markdown-it": "^14.1.0",
         "markdown-it-link-attributes": "^4.0.1",
@@ -52,10 +52,10 @@
         "@nextcloud/eslint-config": "^8.4.1",
         "@nextcloud/stylelint-config": "^3.0.1",
         "@nextcloud/webpack-vue-config": "^6.0.0",
-        "@relative-ci/agent": "^4.2.9",
+        "@relative-ci/agent": "^4.2.8",
         "@vue/test-utils": "^2.4.6",
         "@vue/vue2-jest": "^29.2.6",
-        "cypress": "^13.13.0",
+        "cypress": "^13.12.0",
         "eslint-plugin-cypress": "^3.3.0",
         "eslint-webpack-plugin": "^4.2.0",
         "jest": "^29.7.0",
@@ -1917,9 +1917,9 @@
       "peer": true
     },
     "node_modules/@babel/runtime": {
-      "version": "7.24.8",
-      "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.24.8.tgz",
-      "integrity": "sha512-5F7SDGs1T72ZczbRwbGO9lQi0NLjQxzl6i4lJxLxfW9U5UluCSyEJeniWvnhl3/euNiqQVbo8zruhsDfid0esA==",
+      "version": "7.24.7",
+      "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.24.7.tgz",
+      "integrity": "sha512-UwgBRMjJP+xv857DCngvqXI3Iq6J4v0wXmwc6sapg+zyhbwmQX67LUEFrkK5tbyJ30jGuG3ZvWpBiB9LCy1kWw==",
       "dependencies": {
         "regenerator-runtime": "^0.14.0"
       },
@@ -1994,9 +1994,9 @@
       "dev": true
     },
     "node_modules/@bundle-stats/plugin-webpack-validate": {
-      "version": "4.13.3",
-      "resolved": "https://registry.npmjs.org/@bundle-stats/plugin-webpack-validate/-/plugin-webpack-validate-4.13.3.tgz",
-      "integrity": "sha512-R7qGmWsWq5rhv/Zu6pS+d1S29gV1rxogl/udmbH/L4LysX+TxcotFENsCKn9J7nNBlmLyqDVZpynfGm14ywXjg==",
+      "version": "4.13.2",
+      "resolved": "https://registry.npmjs.org/@bundle-stats/plugin-webpack-validate/-/plugin-webpack-validate-4.13.2.tgz",
+      "integrity": "sha512-Rfdipz+uBsAIIDUo1D+ylD0RxXLCcznaxpodz9QCcd0/P5tkD8gnWh1MZcfZmLFaCnxvTyJMdKJHyjIJ7xyCbA==",
       "dev": true,
       "dependencies": {
         "lodash": "4.17.21",
@@ -3525,9 +3525,9 @@
       }
     },
     "node_modules/@nextcloud/dialogs": {
-      "version": "5.3.5",
-      "resolved": "https://registry.npmjs.org/@nextcloud/dialogs/-/dialogs-5.3.5.tgz",
-      "integrity": "sha512-v2+M2zN90IqkZby7QZ575Ej/VsSQXcI6EurMVp51mRGLTeO2bJw8IVdfumDJhSA+3rn/nSHmkz3zWcHUInqzTg==",
+      "version": "5.3.3",
+      "resolved": "https://registry.npmjs.org/@nextcloud/dialogs/-/dialogs-5.3.3.tgz",
+      "integrity": "sha512-K5ZdwRch3vrt7ZQXp04rUHGid4GcSeRnG0SkvccwfhiVg85wut9YZd+i2YiMPw+VYURKEjr2ZOK7R5afnViWag==",
       "dependencies": {
         "@mdi/js": "^7.4.47",
         "@nextcloud/auth": "^2.3.0",
@@ -3538,7 +3538,7 @@
         "@nextcloud/l10n": "^3.1.0",
         "@nextcloud/router": "^3.0.1",
         "@nextcloud/sharing": "^0.2.2",
-        "@nextcloud/typings": "^1.9.0",
+        "@nextcloud/typings": "^1.8.0",
         "@types/toastify-js": "^1.12.3",
         "@vueuse/core": "^10.11.0",
         "cancelable-promise": "^4.3.1",
@@ -3876,24 +3876,14 @@
         "stylelint-config-recommended-vue": "^1.5.0"
       }
     },
-    "node_modules/@nextcloud/timezones": {
-      "version": "0.1.1",
-      "resolved": "https://registry.npmjs.org/@nextcloud/timezones/-/timezones-0.1.1.tgz",
-      "integrity": "sha512-ldLuLyz605sszetnp6jy6mtlThu4ICKsZThxHIZwn6t4QzjQH3xr+k8mRU7GIvKq9egUFDqBp4gBjxm3/ROZig==",
-      "dependencies": {
-        "ical.js": "^2.0.1"
-      },
-      "engines": {
-        "node": "^20.0.0",
-        "npm": "^10.0.0"
-      }
-    },
     "node_modules/@nextcloud/typings": {
-      "version": "1.9.1",
-      "resolved": "https://registry.npmjs.org/@nextcloud/typings/-/typings-1.9.1.tgz",
-      "integrity": "sha512-i0l/L5gKW8EACbXHVxXM6wn3sUhY2qmnL2OijppzU4dENC7/hqySMQDer7/+cJbNSNG7uHF/Z+9JmHtDfRfuGg==",
+      "version": "1.8.0",
+      "resolved": "https://registry.npmjs.org/@nextcloud/typings/-/typings-1.8.0.tgz",
+      "integrity": "sha512-q9goE0wc+1BCI9Ku0MebCHmqOMwz2K7ESKQrcHDs6O+HqbKA8zGiEtXL5XGrMS7Ovtl1YOIwxlP9kEvgvXt52Q==",
       "dependencies": {
-        "@types/jquery": "3.5.16"
+        "@types/jquery": "3.5.16",
+        "vue": "^2.7.15",
+        "vue-router": "<4"
       },
       "engines": {
         "node": "^20.0.0",
@@ -3901,27 +3891,27 @@
       }
     },
     "node_modules/@nextcloud/vue": {
-      "version": "8.14.0",
-      "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.14.0.tgz",
-      "integrity": "sha512-hB3dG7tZWpItC74PfbTLW02754qYXFDH+h7Ksq6b7e8WlhnKLWrhNGKhSpNDt9/g+vb5bSIOxbiDZIJZ63hAuQ==",
+      "version": "8.12.0",
+      "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.12.0.tgz",
+      "integrity": "sha512-MHL12+XGIDvpsSdrJn79pYKYrTVUouEymc4No91lKTNZTWDN6bciDSprmMs553hECXrqj7sfwxu6sepj0zcR3Q==",
       "dependencies": {
         "@floating-ui/dom": "^1.1.0",
         "@linusborg/vue-simple-portal": "^0.1.5",
         "@nextcloud/auth": "^2.2.1",
         "@nextcloud/axios": "^2.4.0",
         "@nextcloud/browser-storage": "^0.4.0",
+        "@nextcloud/calendar-js": "^7.0.0",
         "@nextcloud/capabilities": "^1.1.0",
         "@nextcloud/event-bus": "^3.1.0",
         "@nextcloud/initial-state": "^2.1.0",
         "@nextcloud/l10n": "^3.0.1",
         "@nextcloud/logger": "^3.0.1",
         "@nextcloud/router": "^3.0.0",
-        "@nextcloud/timezones": "^0.1.1",
         "@nextcloud/vue-select": "^3.25.0",
         "@vueuse/components": "^10.9.0",
         "@vueuse/core": "^10.9.0",
         "clone": "^2.1.2",
-        "debounce": "2.1.0",
+        "debounce": "2.0.0",
         "dompurify": "^3.0.5",
         "emoji-mart-vue-fast": "^15.0.1",
         "escape-html": "^1.0.3",
@@ -3945,7 +3935,6 @@
         "vue": "^2.7.16",
         "vue-color": "^2.8.1",
         "vue-frag": "^1.4.3",
-        "vue-router": "^3.6.5",
         "vue2-datepicker": "^3.11.0"
       },
       "engines": {
@@ -3977,6 +3966,19 @@
         "@floating-ui/core": "^1.0.5"
       }
     },
+    "node_modules/@nextcloud/vue/node_modules/@nextcloud/calendar-js": {
+      "version": "7.0.0",
+      "resolved": "https://registry.npmjs.org/@nextcloud/calendar-js/-/calendar-js-7.0.0.tgz",
+      "integrity": "sha512-CvCcO4hFPjMfIB2AKW0QLNYukGoHFS7QQVvIC8khJjzNfVGS6qMJd2oaZtD9Q9w1fLpvwp1X7orcYGYmosDkAA==",
+      "engines": {
+        "node": "^20.0.0",
+        "npm": "^10.0.0"
+      },
+      "peerDependencies": {
+        "ical.js": "^2.0.1",
+        "uuid": "^9.0.0"
+      }
+    },
     "node_modules/@nextcloud/vue/node_modules/@types/unist": {
       "version": "3.0.2",
       "resolved": "https://registry.npmjs.org/@types/unist/-/unist-3.0.2.tgz",
@@ -4060,6 +4062,19 @@
         "url": "https://opencollective.com/unified"
       }
     },
+    "node_modules/@nextcloud/vue/node_modules/uuid": {
+      "version": "9.0.1",
+      "resolved": "https://registry.npmjs.org/uuid/-/uuid-9.0.1.tgz",
+      "integrity": "sha512-b+1eJOlsR9K8HJpow9Ok3fiWOWSIcIzXodvv0rQjVoOVNpWMpxf1wZNpt4y9h10odCNrqnYp1OBzRktckBe3sA==",
+      "funding": [
+        "https://github.com/sponsors/broofa",
+        "https://github.com/sponsors/ctavan"
+      ],
+      "peer": true,
+      "bin": {
+        "uuid": "dist/bin/uuid"
+      }
+    },
     "node_modules/@nextcloud/vue/node_modules/vfile": {
       "version": "6.0.1",
       "resolved": "https://registry.npmjs.org/vfile/-/vfile-6.0.1.tgz",
@@ -4185,16 +4200,16 @@
       }
     },
     "node_modules/@relative-ci/agent": {
-      "version": "4.2.9",
-      "resolved": "https://registry.npmjs.org/@relative-ci/agent/-/agent-4.2.9.tgz",
-      "integrity": "sha512-VrpE0eHi6DMVnfS5epTzo6Z9aGC3l7QuwqP/h2NQrpKMyXfLjqBrYNVzttHueIqxvLP9FzBXmpYm7OxjcTYJuQ==",
+      "version": "4.2.8",
+      "resolved": "https://registry.npmjs.org/@relative-ci/agent/-/agent-4.2.8.tgz",
+      "integrity": "sha512-GbmBZ1LlMkLGkypOakINfSfsrI5l0USom7EFqv9EPHmcKhxWu0TIrnTBhIGPO29A8m9yLKIz9ZTzHCA1ROKF1Q==",
       "dev": true,
       "dependencies": {
-        "@bundle-stats/plugin-webpack-filter": "4.13.3",
-        "@bundle-stats/plugin-webpack-validate": "4.13.3",
+        "@bundle-stats/plugin-webpack-filter": "4.13.2",
+        "@bundle-stats/plugin-webpack-validate": "4.13.2",
         "core-js": "3.37.1",
         "cosmiconfig": "9.0.0",
-        "debug": "4.3.5",
+        "debug": "4.3.4",
         "dotenv": "16.4.5",
         "env-ci": "7.3.0",
         "fs-extra": "11.2.0",
@@ -4218,9 +4233,9 @@
       }
     },
     "node_modules/@relative-ci/agent/node_modules/@bundle-stats/plugin-webpack-filter": {
-      "version": "4.13.3",
-      "resolved": "https://registry.npmjs.org/@bundle-stats/plugin-webpack-filter/-/plugin-webpack-filter-4.13.3.tgz",
-      "integrity": "sha512-jMMt2Hz5FgHMBT+52L2zsB14RJBLVjV9UxnFhpd8iH1JWgxTvQFmUG/FpubMdzhIXZx6QAHFslrtCSExgMYgtQ==",
+      "version": "4.13.2",
+      "resolved": "https://registry.npmjs.org/@bundle-stats/plugin-webpack-filter/-/plugin-webpack-filter-4.13.2.tgz",
+      "integrity": "sha512-FU1i0DYBhIzY2hElvKSSEdazka4lpc9zP2zAYGmOmYkF6g4Omz+1DWH6a7MZv0cZhee8yIxaRNGkGy1R/llmtQ==",
       "dev": true,
       "engines": {
         "node": ">= 14.0"
@@ -7717,9 +7732,9 @@
       "integrity": "sha512-uX1KG+x9h5hIJsaKR9xHUeUraxf8IODOwq9JLNPq6BwB04a/xgpq3rcx47l5BZu5zBPlgD342tdke3Hom/nJRA=="
     },
     "node_modules/cypress": {
-      "version": "13.13.0",
-      "resolved": "https://registry.npmjs.org/cypress/-/cypress-13.13.0.tgz",
-      "integrity": "sha512-ou/MQUDq4tcDJI2FsPaod2FZpex4kpIK43JJlcBgWrX8WX7R/05ZxGTuxedOuZBfxjZxja+fbijZGyxiLP6CFA==",
+      "version": "13.12.0",
+      "resolved": "https://registry.npmjs.org/cypress/-/cypress-13.12.0.tgz",
+      "integrity": "sha512-udzS2JilmI9ApO/UuqurEwOvThclin5ntz7K0BtnHBs+tg2Bl9QShLISXpSEMDv/u8b6mqdoAdyKeZiSqKWL8g==",
       "dev": true,
       "hasInstallScript": true,
       "dependencies": {
@@ -7762,7 +7777,7 @@
         "request-progress": "^3.0.0",
         "semver": "^7.5.3",
         "supports-color": "^8.1.1",
-        "tmp": "~0.2.3",
+        "tmp": "~0.2.1",
         "untildify": "^4.0.0",
         "yauzl": "^2.10.0"
       },
@@ -7981,9 +7996,9 @@
       "license": "MIT"
     },
     "node_modules/debounce": {
-      "version": "2.1.0",
-      "resolved": "https://registry.npmjs.org/debounce/-/debounce-2.1.0.tgz",
-      "integrity": "sha512-OkL3+0pPWCqoBc/nhO9u6TIQNTK44fnBnzuVtJAbp13Naxw9R6u21x+8tVTka87AhDZ3htqZ2pSSsZl9fqL2Wg==",
+      "version": "2.0.0",
+      "resolved": "https://registry.npmjs.org/debounce/-/debounce-2.0.0.tgz",
+      "integrity": "sha512-xRetU6gL1VJbs85Mc4FoEGSjQxzpdxRyFhe3lmWFyy2EzydIcD4xzUvRJMD+NPDfMwKNhxa3PvsIOU32luIWeA==",
       "engines": {
         "node": ">=18"
       },
@@ -7992,9 +8007,9 @@
       }
     },
     "node_modules/debug": {
-      "version": "4.3.5",
-      "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.5.tgz",
-      "integrity": "sha512-pt0bNEmneDIvdL1Xsd9oDQ/wrQRkXDT4AUWlNZNPKvW5x/jyO9VFXkJUP07vQ2upmw5PlaITaPKc31jK13V+jg==",
+      "version": "4.3.4",
+      "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.4.tgz",
+      "integrity": "sha512-PRWFHuSU3eDtQJPvnNY7Jcket1j0t5OuOsFzPPzsekD52Zl8qUfFIPEiswXqIvHWGVHOgX+7G/vCNNhehwxfkQ==",
       "dependencies": {
         "ms": "2.1.2"
       },
@@ -8342,9 +8357,9 @@
       }
     },
     "node_modules/dompurify": {
-      "version": "3.1.6",
-      "resolved": "https://registry.npmjs.org/dompurify/-/dompurify-3.1.6.tgz",
-      "integrity": "sha512-cTOAhc36AalkjtBpfG6O8JimdTMWNXjiePT2xQH/ppBGi/4uIpmj8eKyIkMJErXWARyINV/sB38yf8JCLF5pbQ=="
+      "version": "3.1.5",
+      "resolved": "https://registry.npmjs.org/dompurify/-/dompurify-3.1.5.tgz",
+      "integrity": "sha512-lwG+n5h8QNpxtyrJW/gJWckL+1/DQiYMX8f7t8Z2AZTPw1esVrqjI63i7Zc2Gz0aKzLVMYC1V1PL/ky+aY/NgA=="
     },
     "node_modules/domutils": {
       "version": "3.1.0",
@@ -11224,7 +11239,8 @@
     "node_modules/ical.js": {
       "version": "2.0.1",
       "resolved": "https://registry.npmjs.org/ical.js/-/ical.js-2.0.1.tgz",
-      "integrity": "sha512-uYYb1CwTXbd9NP/xTtgQZ5ivv6bpUjQu9VM98s3X78L3XRu00uJW5ZtmnLwyxhztpf5fSiRyDpFW7ZNCePlaPw=="
+      "integrity": "sha512-uYYb1CwTXbd9NP/xTtgQZ5ivv6bpUjQu9VM98s3X78L3XRu00uJW5ZtmnLwyxhztpf5fSiRyDpFW7ZNCePlaPw==",
+      "peer": true
     },
     "node_modules/iconv-lite": {
       "version": "0.4.24",
@@ -17657,7 +17673,6 @@
       "resolved": "https://registry.npmjs.org/rimraf/-/rimraf-3.0.2.tgz",
       "integrity": "sha512-JZkJMZkAGFFPP2YqXZXPbMlMBgsxzE8ILs4lMIX/2o0L9UBw9O/Y3o6wFw/i9YLapcUJWwqbi3kdxIPdC62TIA==",
       "dev": true,
-      "peer": true,
       "dependencies": {
         "glob": "^7.1.3"
       },
@@ -19269,12 +19284,15 @@
       }
     },
     "node_modules/tmp": {
-      "version": "0.2.3",
-      "resolved": "https://registry.npmjs.org/tmp/-/tmp-0.2.3.tgz",
-      "integrity": "sha512-nZD7m9iCPC5g0pYmcaxogYKggSfLsdxl8of3Q/oIbqCqLLIO9IAF0GWjX1z9NZRHPiXv8Wex4yDCaZsgEw0Y8w==",
+      "version": "0.2.1",
+      "resolved": "https://registry.npmjs.org/tmp/-/tmp-0.2.1.tgz",
+      "integrity": "sha512-76SUhtfqR2Ijn+xllcI5P1oyannHNHByD80W1q447gU3mp9G9PSpGdWmjUOHRDPiHYacIk66W7ubDTuPF3BEtQ==",
       "dev": true,
+      "dependencies": {
+        "rimraf": "^3.0.0"
+      },
       "engines": {
-        "node": ">=14.14"
+        "node": ">=8.17.0"
       }
     },
     "node_modules/tmpl": {

package.json

@@ -31,11 +31,11 @@
   },
   "dependencies": {
     "@babel/polyfill": "^7.12.1",
-    "@babel/runtime": "^7.24.8",
+    "@babel/runtime": "^7.24.7",
     "@nextcloud/auth": "^2.3.0",
     "@nextcloud/axios": "^2.5.0",
     "@nextcloud/capabilities": "^1.2.0",
-    "@nextcloud/dialogs": "^5.3.5",
+    "@nextcloud/dialogs": "^5.3.3",
     "@nextcloud/event-bus": "^3.3.1",
     "@nextcloud/files": "^3.5.1",
     "@nextcloud/initial-state": "^2.2.0",
@@ -43,10 +43,10 @@
     "@nextcloud/moment": "^1.3.1",
     "@nextcloud/notify_push": "^1.3.0",
     "@nextcloud/router": "^3.0.1",
-    "@nextcloud/vue": "^8.14.0",
+    "@nextcloud/vue": "^8.12.0",
     "blueimp-md5": "^2.19.0",
     "chroma-js": "^2.4.2",
-    "dompurify": "^3.1.6",
+    "dompurify": "^3.1.5",
     "lodash": "^4.17.21",
     "markdown-it": "^14.1.0",
     "markdown-it-link-attributes": "^4.0.1",
@@ -80,10 +80,10 @@
     "@nextcloud/eslint-config": "^8.4.1",
     "@nextcloud/stylelint-config": "^3.0.1",
     "@nextcloud/webpack-vue-config": "^6.0.0",
-    "@relative-ci/agent": "^4.2.9",
+    "@relative-ci/agent": "^4.2.8",
     "@vue/test-utils": "^2.4.6",
     "@vue/vue2-jest": "^29.2.6",
-    "cypress": "^13.13.0",
+    "cypress": "^13.12.0",
     "eslint-plugin-cypress": "^3.3.0",
     "eslint-webpack-plugin": "^4.2.0",
     "jest": "^29.7.0",

src/components/ActivityEntry.vue

@@ -120,7 +120,7 @@ export default {
 			margin-left: 10px;
 		}
 		.activity--message {
-			margin-left: var(--default-clickable-area);
+			margin-left: 44px;
 			color: var(--color-text-light);
 			margin-bottom: 10px;
 		}

src/components/Controls.vue

@@ -476,8 +476,8 @@ export default {
 	.controls {
 		display: flex;
 		margin: 5px;
-		height: var(--default-clickable-area);
-		padding-left: var(--default-clickable-area);
+		height: 44px;
+		padding-left: 44px;
 
 		.board-title {
 			display: flex;
@@ -507,8 +507,8 @@ export default {
 
 	#app-navigation-toggle-custom {
 		position: static;
-		width: var(--default-clickable-area);
-		height: var(--default-clickable-area);
+		width: 44px;
+		height: 44px;
 		cursor: pointer;
 		opacity: 1;
 		display: inline-block !important;
@@ -567,8 +567,8 @@ export default {
 	.filter-button {
 		padding: 0;
 		border-radius: 50%;
-		width: var(--default-clickable-area);
-		height: var(--default-clickable-area);
+		width: 44px;
+		height: 44px;
 
 		&[data-popper-shown] {
 			background-color: var(--color-background-hover);

src/components/SessionList.vue

@@ -56,7 +56,7 @@ export default {
 <style scoped lang="scss">
 
 .avatar-list {
-	min-height: var(--default-clickable-area);
+	min-height: 44px;
 	align-items: center;
 	padding-right: 0.5em;
 	border: none;

src/components/board/Board.vue

@@ -250,7 +250,7 @@ export default {
 	.board {
 		padding-left: $board-spacing;
 		position: relative;
-		max-height: calc(100% - var(--default-clickable-area));
+		max-height: calc(100% - 44px);
 		overflow: hidden;
 		overflow-x: auto;
 		flex-grow: 1;

src/components/board/BoardSidebar.vue

@@ -1,6 +1,6 @@
 <!--
-	- SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
-	- SPDX-License-Identifier: AGPL-3.0-or-later
+  - SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
 -->
 
 <template>
@@ -100,12 +100,3 @@ export default {
 	},
 }
 </script>
-
-<style scoped lang="scss">
-:deep {
-	.app-sidebar-tabs__tab-caption,
-	.app-sidebar-tabs__nav .checkbox-content__text {
-		white-space: normal !important;
-	}
-}
-</style>

src/components/board/DeletedTabSidebar.vue

@@ -4,7 +4,7 @@
 -->
 <template>
 	<div>
-		<h5>{{ t('deck', 'Deleted lists') }}</h5>
+		<h3>{{ t('deck', 'Deleted lists') }}</h3>
 		<ul>
 			<li v-for="deletedStack in deletedStacks" :key="deletedStack.id">
 				<span class="icon icon-deck" />
@@ -18,7 +18,7 @@
 			</li>
 		</ul>
 
-		<h5>{{ t('deck', 'Deleted cards') }}</h5>
+		<h3>{{ t('deck', 'Deleted cards') }}</h3>
 		<ul>
 			<li v-for="deletedCard in deletedCards" :key="deletedCard.id">
 				<div class="icon icon-deck" />
@@ -102,7 +102,7 @@ export default {
 		}
 
 		* {
-			flex-basis: var(--default-clickable-area);
+			flex-basis: 44px;
 		}
 
 		.title {

src/components/board/Stack.vue

@@ -1,6 +1,6 @@
 <!--
-	- SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
-	- SPDX-License-Identifier: AGPL-3.0-or-later
+  - SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
 -->
 
 <template>
@@ -261,7 +261,7 @@ export default {
 		},
 		startEditing(stack) {
 			if (this.dragging) {
-				return
+			  return
 			}
 
 			this.copiedStack = Object.assign({}, stack)
@@ -322,7 +322,7 @@ export default {
 		padding-left: $card-spacing;
 		padding-right: $card-spacing;
 		cursor: grab;
-		min-height: var(--default-clickable-area);
+		min-height: 44px;
 
 		// Smooth fade out of the cards at the top
 		&:before {
@@ -374,7 +374,6 @@ export default {
 			border-radius: 3px;
 			margin: 6px;
 			padding: 4px 4px;
-			font-size: 120%;
 
 			&:focus-visible {
 				outline: 2px solid var(--color-border-dark);
@@ -385,17 +384,10 @@ export default {
 		form {
 			margin: 2px 0;
 		}
-
-		:deep {
-			.action-item,
-			.v-popper--theme-dropdown {
-				display: flex;
-			}
-		}
 	}
 
 	.stack__card-add {
-		height: var(--default-clickable-area);
+		height: 44px;
 		flex-shrink: 0;
 		z-index: 100;
 		display: flex;

src/components/board/TagsTabSidebar.vue

@@ -173,7 +173,7 @@ export default {
 }
 </script>
 <style scoped lang="scss">
-	$clickable-area: var(--default-clickable-area);
+	$clickable-area: 44px;
 
 	.labels li {
 		display: flex;

src/components/boards/Boards.vue

@@ -62,7 +62,7 @@ export default {
 
 <style lang="scss">
 	.board-list {
-		margin-top: - var(--default-clickable-area); //@TODO
+		margin-top: -44px;
 
 		.board-list-row {
 			align-items: center;
@@ -77,7 +77,7 @@ export default {
 
 		.board-list-header-row {
 			color: var(--color-text-lighter);
-			height: var(--default-clickable-area);
+			height: 44px;
 		}
 
 		.board-list-bullet-cell,

src/components/card/AttachmentList.vue

@@ -253,10 +253,10 @@ export default {
 		gap: calc(var(--default-grid-baseline) * 3);
 
 		.icon-upload, .icon-folder {
-			padding-left: var(--default-clickable-area);
+			padding-left: 44px;
 			background-position: 16px center;
 			flex-grow: 1;
-			height: var(--default-clickable-area);
+			height: 44px;
 			margin-bottom: 12px;
 			text-align: left;
 		}
@@ -291,7 +291,7 @@ export default {
 		li.attachment {
 			display: flex;
 			padding: 3px;
-			min-height: var(--default-clickable-area);
+			min-height: 44px;
 
 			&.deleted {
 				opacity: .5;
@@ -339,7 +339,7 @@ export default {
 				}
 			}
 			button.icon-history {
-				width: var(--default-clickable-area);
+				width: 44px;
 			}
 			progress {
 				margin-top: 3px;

src/components/card/CardSidebar.vue

@@ -221,7 +221,7 @@ section.app-sidebar__tab--active {
 	right: 0;
 	max-width: calc(100% - #{$modal-padding * 2});
 	padding: 0 14px;
-	height: 97%;
+	height: auto;
 	overflow: initial;
 	user-select: text;
 	-webkit-user-select: text;

src/components/card/CommentItem.vue

@@ -213,7 +213,7 @@ export default {
 	@import '../../css/comments';
 
 	.reply {
-		margin: 0 0 0 var(--default-clickable-area);
+		margin: 0 0 0 44px;
 
 		&.reply--preview {
 			margin: 4px 0;

src/components/card/Description.vue

@@ -187,6 +187,7 @@ export default {
 				},
 				onUpdate: ({ markdown }) => {
 					if (this.description === markdown) {
+						this.descriptionLastEdit = 0
 						return
 					}
 					this.description = markdown
@@ -282,9 +283,7 @@ export default {
 				return
 			}
 			this.descriptionSaving = true
-			if (this.card.id !== undefined) {
-				await this.$store.dispatch('updateCardDesc', { ...this.card, description: this.description })
-			}
+			await this.$store.dispatch('updateCardDesc', { ...this.card, description: this.description })
 			this.$emit('change', this.description)
 			this.descriptionLastEdit = 0
 			this.descriptionSaving = false
@@ -367,7 +366,7 @@ h5 {
 }
 
 .description__text :deep(.ProseMirror) {
-	padding-bottom: var(--default-clickable-area);
+	padding-bottom: 44px;
 }
 
 </style>
@@ -423,6 +422,6 @@ h5 {
 }
 
 .modal__card .description__text .text-menubar {
-	top: 0;
+	top: 142px !important;
 }
 </style>

src/components/cards/CardItem.vue

@@ -338,7 +338,7 @@ export default {
 				}
 			}
 			.card-menu {
-				height: var(--default-clickable-area);
+				height: 44px;
 				align-self: end;
 			}
 		}
@@ -391,7 +391,7 @@ export default {
 	}
 
 	.compact {
-		min-height: var(--default-clickable-area);
+		min-height: 44px;
 
 		.duedate {
 			margin-right: 0;

src/components/navigation/AppNavigationAddBoard.vue

@@ -73,7 +73,7 @@ export default {
 	.board-create {
 		order: 1;
 		display: flex;
-		height: var(--default-clickable-area);
+		height: 44px;
 
 		form {
 			display: flex;
@@ -86,8 +86,8 @@ export default {
 	}
 
 	.app-navigation-entry-bullet-wrapper {
-		width: var(--default-clickable-area);
-		height: var(--default-clickable-area);
+		width: 44px;
+		height: 44px;
 		.color0 {
 			width: 30px !important;
 			margin: 5px;

src/components/navigation/AppNavigationBoard.vue

@@ -319,10 +319,10 @@ export default {
 
 <style lang="scss" scoped>
 	.board-edit {
-		margin-left: var(--default-clickable-area);
+		margin-left: 44px;
 		order: 1;
 		display: flex;
-		height: var(--default-clickable-area);
+		height: 44px;
 
 		form {
 			display: flex;
@@ -335,8 +335,8 @@ export default {
 	}
 
 	.app-navigation-entry-bullet-wrapper {
-		width: var(--default-clickable-area);
-		height: var(--default-clickable-area);
+		width: 44px;
+		height: 44px;
 		.color0 {
 			width: 30px !important;
 			margin: 5px;

src/components/overview/Overview.vue

@@ -158,7 +158,7 @@ export default {
 
 .overview {
 	position: relative;
-	height: calc(100% - var(--default-clickable-area));
+	height: calc(100% - 44px);
 	overflow-x: scroll;
 	display: flex;
 	align-items: stretch;

src/components/search/Placeholder.vue

@@ -59,7 +59,7 @@ export default {
 
 <style lang="scss" scoped>
 @import '../../css/variables';
-$clickable-area: var(--default-clickable-area);
+$clickable-area: 44px;
 
 .card--placeholder {
 	width: $stack-width;

src/css/comments.scss

@@ -9,7 +9,7 @@
 
 	.editor__content:deep {
 		flex-grow: 1;
-		margin-left: var(--default-clickable-area);
+		margin-left: 44px;
 
 		.ProseMirror {
 			width: 100%;
@@ -17,8 +17,8 @@
 	}
 
 	input[type='submit'] {
-		width: var(--default-clickable-area);
-		height: var(--default-clickable-area);
+		width: 44px;
+		height: 44px;
 		margin: 0;
 		padding: 13px;
 		background-color: transparent;
@@ -51,6 +51,6 @@
 }
 
 .comment--content {
-	margin-left: var(--default-clickable-area);
+	margin-left: 44px;
 	word-break: break-word;
 }

src/helpers/mentions.js

@@ -2,7 +2,6 @@
  * SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-
 const rawToParsed = (text) => {
 	text = text.replace(/<br>/g, '\n')
 	text = text.replace(/&nbsp;/g, ' ')

src/helpers/xml.js

@@ -2,7 +2,6 @@
  * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-
 const xmlToJson = (xml) => {
 	let obj = {}
 	if (xml.nodeType === 1) {

src/init-collections.js

@@ -18,6 +18,8 @@ Vue.prototype.OC = OC
 window.addEventListener('DOMContentLoaded', () => {
 	if (OCA.Sharing && OCA.Sharing.ShareSearch) {
 		OCA.Sharing.ShareSearch.addNewResult(FileSharingPicker)
+	} else {
+		console.error('OCA.Sharing.ShareSearch not ready')
 	}
 
 	window.OCP.Collaboration.registerType('deck', {

tests/unit/Activity/CommentEventHandlerTest.php

@@ -21,9 +21,8 @@
  *
  */
 
-namespace OCA\Deck\Listeners;
+namespace OCA\Deck\Activity;
 
-use OCA\Deck\Activity\ActivityManager;
 use OCA\Deck\Db\Card;
 use OCA\Deck\Db\CardMapper;
 use OCA\Deck\Db\ChangeHelper;
@@ -32,9 +31,9 @@ use OCP\Comments\CommentsEvent;
 use OCP\Comments\IComment;
 use PHPUnit\Framework\TestCase;
 
-class CommentEventListenerTest extends TestCase {
+class CommentEventHandlerTest extends TestCase {
 
-	/** @var CommentEventListener */
+	/** @var CommentEventHandler */
 	private $commentEventHandler;
 	/** @var ActivityManager */
 	private $activityManager;
@@ -50,7 +49,7 @@ class CommentEventListenerTest extends TestCase {
 		$this->notificationHelper = $this->createMock(NotificationHelper::class);
 		$this->cardMapper = $this->createMock(CardMapper::class);
 		$this->changeHelper = $this->createMock(ChangeHelper::class);
-		$this->commentEventHandler = new CommentEventListener(
+		$this->commentEventHandler = new CommentEventHandler(
 			$this->activityManager,
 			$this->notificationHelper,
 			$this->cardMapper,