 Ryan FletcherandJulius Härtl
|
d17d0ec16f
|
removing whitespaces
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-24 14:56:37 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
1949dae8d4
|
attempt at solving css "jumps" on inline edits.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-24 14:56:37 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
7c6d36fde1
|
Added class input-inline
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-24 14:56:36 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
5fd8ff003b
|
editable inline card titles
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-24 14:56:36 +02:00 |
|
Ryan Fletcher
|
fd7dd9c3b4
|
cleaning up whitespace / unused css style.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-23 07:10:17 -04:00 |
|
Ryan Fletcher
|
6fb4525754
|
sending strings through translation code.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-21 17:25:09 -04:00 |
|
Ryan Fletcher
|
001609982d
|
adjusting solution based on standards shown to me by jancborchardt
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-21 17:11:47 -04:00 |
|
Ryan Fletcher
|
9353e4852c
|
Added empty message to board list when there are no boards present.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-21 14:35:03 -04:00 |
|
 Ryan FletcherandJulius Härtl
|
4391bf4eb8
|
added missing BadRequestException checks to StackService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
aba7d02cfe
|
Added BadRequestException checks in DefaultBoardService. Fixed bug in DefaultBoardService BadRequestException checks.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
6f5c0a2816
|
Added in BadRequestException checks in CardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
e8571454d9
|
Added BadRequestException checks into BoardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
7930fec5d7
|
Added in BadRequestException tests into AttachmentService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
37a2858d5f
|
wrote attachment api controller, fixed bug caught by unit test in CardService
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
e88c9a760d
|
Wrote unit tests for AttachmentApiController and stubbed out AttachmentApicontroller. Trying out test driven development.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
172a80fa5d
|
Added additional endpoints for cards / stacks
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
3e965d0cfb
|
Implemented additional CardApiController endpoints
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
72aeb723a5
|
fixed up missing checks from labelService, BadRequestException is now extending StatusException
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
507a7fd243
|
Code cleanup, removing unused code from older iteration.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
184cd00a8b
|
Wrote initial unit tests for LabelApiControllerTest.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
9c81584b02
|
Wrote tests for CardApiControllerTest.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
5bc8a363b9
|
Split Card Update in CardApiController as it was gigantic and broke codacy complexity rules by a lot. Also moved validation checks into respective services.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
f1169b9c7e
|
finished writing StackApiControllerTest.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
f2268c7f58
|
Moved Data Response checks into stack serivice, cleaned up related unit tests.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
d33dd3e0fc
|
Moved BadRequestException checks to middleware, removed uneeded unit tests in BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
8cac183af6
|
simple code style changes according to codacy standards.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
570ac81848
|
added the create tests in StackApiControllerTest
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
5719e9f134
|
Wrote unit tests against StackApiController -> get()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
891fa7b7d5
|
Created index tests for StackApiTestController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
54f110f7c6
|
first attempt at BoardApiControllerTest->testGetNoPermission()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
6d57b1081a
|
BoardApiControllerTest wrote delete tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
8dd732631a
|
BoardApiController wrote update tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
1fe70568cb
|
Wrote unit tests for the BoardApiController -> create tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
bd254fd261
|
BoardApiControllerTest wrote get() tests.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
fad579c4d3
|
Wrote first unit test for BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
e8c53d71aa
|
fixed more unit tests.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
e0049cf07b
|
Resolved unit tests errors, down from 36 to 9.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
881b05aeb1
|
fixed BoardControllerTest from errors
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
cfd9ab98c6
|
Implemented StackApiController Get Function.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
dd1d4246fe
|
Finished Error handling across the API
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
2668f6b80c
|
committing WIP (improving error validation across the api's)
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
a388d199dc
|
Refactored error handling in StackApiController and moved it into ApiHelper.php, this will allow me to use the same checks in all controllers.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
d9f3d492dc
|
Better variable name for stackService in StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
a14ca3d1f5
|
Better error handling in StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
7d9fc83dc9
|
Code style fixings.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
f97c7c3f7b
|
Added in Create + Delete functions to the LabelApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
6002067b64
|
Created LabelApiController and it's get / update methods.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
7e4d24236a
|
Updated the CardApiController->update method to allow updating of archive state and assigned user,.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
b82591a0bc
|
Added delete operation to CardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
e5f7f89ed9
|
Wrote update method for CardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
a68e888654
|
Started CardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
0c0910ee81
|
Co authored for my changes.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
ced87edfa5
|
Put in validation responses in BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:15 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
5415ec21dc
|
Validation Checking against StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
3cb496daa2
|
Cleaned up StackApiController to use proper route parameters, removed route parameters from request payloads as per rest standards.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
03e0559afe
|
StackApiController->delete($boardId, $id) added in error handling
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
be91ff641c
|
StackApiController added the update put route.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
cec06493c0
|
Error handling for StackApiController->Index()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
0da84a3e8c
|
Corrected comment in BoardApiController from copy / paste.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:14 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
6822d7d099
|
Error handling in undelete function and created the update function in BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
d82746be97
|
Error handling for undoDelete and created an update method in BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
3b49c7f262
|
Added exception handling to BoardApiController -> Delete
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
9bc9569a0d
|
Added checks to see if the entity is not found in BoardApiController -> get($id)
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
8771e35f11
|
Added exception handling to StackApiController->create()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
 Ryan FletcherandJulius Härtl
|
656e8efa43
|
quick test in StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:13 +02:00 |
|
Ryan Fletcher
|
04cb5f656d
|
Mocked up $this->l10n calls in DefaultBoardServiceTest
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-13 08:53:21 -04:00 |
|
Ryan Fletcher
|
3863c7497b
|
Used $l10n references in my unit test, this should allow it pass.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-12 12:15:46 -04:00 |
|
Ryan Fletcher
|
8d4dbd4d82
|
Fixed up code styles as per review by juliushaertl
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-12 11:17:11 -04:00 |
|
Ryan Fletcher
|
af92da9a7c
|
Removing translations I attempted to put in before knowing the process.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 16:18:00 -04:00 |
|
Ryan Fletcher
|
ba378ea00b
|
First attempt at using l10n
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 15:00:08 -04:00 |
|
Ryan Fletcher
|
be8a3479ac
|
Updated PageControllerTest.php to reflect new changes
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 13:33:04 -04:00 |
|
Ryan Fletcher
|
2002841c61
|
Wrote unit tests for checkFirstRun method in the default board service
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 12:59:40 -04:00 |
|
Ryan Fletcher
|
08f9874745
|
Updated constructor in PageControllerTest
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 11:50:11 -04:00 |
|
Ryan Fletcher
|
712ab9e0bc
|
Corrected testCreateDefaultBoard()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 11:49:20 -04:00 |
|
Ryan Fletcher
|
e07fc0a2c7
|
Corrected missing import and missing parameter in defaultBoardServiceTest
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 10:49:46 -04:00 |
|
Ryan Fletcher
|
61fb68f4cf
|
Added a unit test against DefaultBoardService->TestCreateDefaultBoard()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 10:20:42 -04:00 |
|
Ryan Fletcher
|
8a8cffc542
|
Completed checkFirstRun() in DefaultBoardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-11 08:02:54 -04:00 |
|
Ryan Fletcher
|
a36dfcc144
|
first attempt at writing the checkFirstRun() in DefaultBoardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-10 21:16:24 -04:00 |
|
Ryan Fletcher
|
683354da9d
|
corrected null errors from first attempt.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-10 19:30:47 -04:00 |
|
Ryan Fletcher
|
e208fd8222
|
First Attempt at implementing createDefaultBoard()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-07-10 17:10:27 -04:00 |
|