Fix codacy warnings and remove unused code

Signed-off-by: Julius Härtl <jus@bitgrid.net>

js/controller/BoardController.js

@@ -346,7 +346,7 @@ app.controller('BoardController', function ($rootScope, $scope, $stateParams, St
 			BoardService.getCurrent().labels.push(data);
 			$scope.status.createLabel = false;
 			$scope.newLabel = {};
-		}).catch(err => {
+		}).catch((err) => {
 			OC.Notification.showTemporary(err);
 		});
 	};
@@ -357,7 +357,7 @@ app.controller('BoardController', function ($rootScope, $scope, $stateParams, St
 
 	$scope.labelUpdate = function (label) {
 		label.edit = false;
-		LabelService.update(label).catch(err => {
+		LabelService.update(label).catch((err) => {
 			label.title = label.renameTitle;
 			OC.Notification.showTemporary(err);
 		});

lib/Service/LabelService.php

@@ -92,7 +92,6 @@ class LabelService {
 
 		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
 
-		//$this->checkDuplicateTitle($boardId, $title);
 		$boardLabels = $this->labelMapper->findAll($boardId);
 		if (\is_array($boardLabels)) {
 			foreach($boardLabels as $boardLabel) {
@@ -166,7 +165,6 @@ class LabelService {
 		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
 
 		$label = $this->find($id);
-		//$this->checkDuplicateTitle($label->getBoardId(), $title);
 
 		$boardLabels = $this->labelMapper->findAll($label->getBoardId());
 		if (\is_array($boardLabels)) {
@@ -191,19 +189,4 @@ class LabelService {
 		return $this->labelMapper->update($label);
 	}
 
-	/**
-	 * @param $boardId
-	 * @param $title
-	 * @throws BadRequestException
-	 */
-	private function checkDuplicateTitle($boardId, $title) {
-		$boardLabels = $this->labelMapper->findAll($boardId);
-		foreach($boardLabels as $boardLabel) {
-			if ($boardLabel->getTitle() === $title) {
-				throw new BadRequestException('title must be unique');
-				break;
-			}
-		}
-	}
-
 }