ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #3625 from bink/bugfix/correct-acl-for-cirlce-and-member-shares

Browse Source 
Fix: Check all circle shares for permissions
This commit is contained in:
Julius Härtl
2022-04-11 16:45:37 +02:00
committed by GitHub
parent 5d477b733d 04f8292b8a
commit 949cb99847
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Service/PermissionService.php
View File

@@ -213,7 +213,9 @@ class PermissionService {
if ($this->circlesService->isCirclesEnabled() && $acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) { if ($this->circlesService->isCirclesEnabled() && $acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) {
try { try {
return $this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission); if ($this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission)) {
return true;
}
} catch (\Exception $e) { } catch (\Exception $e) {
$this->logger->info('Member not found in circle that was accessed. This should not happen.'); $this->logger->info('Member not found in circle that was accessed. This should not happen.');
} }