Merge pull request #3625 from bink/bugfix/correct-acl-for-cirlce-and-member-shares

Fix: Check all circle shares for permissions
This commit is contained in:
Julius Härtl
2022-04-11 16:45:37 +02:00
committed by GitHub

View File

@@ -213,7 +213,9 @@ class PermissionService {
if ($this->circlesService->isCirclesEnabled() && $acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) {
try {
return $this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission);
if ($this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission)) {
return true;
}
} catch (\Exception $e) {
$this->logger->info('Member not found in circle that was accessed. This should not happen.');
}