ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix test case which relied on mapper->delete() returning a bool value

Browse Source 
Signed-off-by: Raul Ferreira Fuentes <raul@nextcloud.com>
This commit is contained in:
Raul Ferreira Fuentes
2022-04-11 20:04:16 +02:00
parent 8399b00a10
commit 8c1e53a8df
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Service/BoardService.php
View File

@@ -625,11 +625,9 @@ class BoardService {
} catch (\Exception $e) { } catch (\Exception $e) {
} }
} }
$delete = $this->aclMapper->delete($acl);
$this->eventDispatcher->dispatchTyped(new AclDeletedEvent($acl)); $this->eventDispatcher->dispatchTyped(new AclDeletedEvent($acl));
return (bool) $this->aclMapper->delete($acl);
return $delete;
} }
/** /**

2
tests/unit/Service/BoardServiceTest.php
View File

@@ -420,7 +420,7 @@ class BoardServiceTest extends TestCase {
$this->aclMapper->expects($this->once()) $this->aclMapper->expects($this->once())
->method('delete') ->method('delete')
->with($acl) ->with($acl)
->willReturn(true); ->willReturn($acl);
$this->assertTrue($this->service->deleteAcl(123)); $this->assertTrue($this->service->deleteAcl(123));
} }
} }

1
tests/unit/Service/CardServiceTest.php
View File

@@ -160,6 +160,7 @@ class CardServiceTest extends TestCase {
$cardExpected->setAssignedUsers(['user1', 'user2']); $cardExpected->setAssignedUsers(['user1', 'user2']);
$cardExpected->setRelatedBoard($boardMock); $cardExpected->setRelatedBoard($boardMock);
$cardExpected->setRelatedStack($stackMock); $cardExpected->setRelatedStack($stackMock);
$cardExpected->setLabels([]);
$this->assertEquals($cardExpected, $this->cardService->find(123)); $this->assertEquals($cardExpected, $this->cardService->find(123));
} }