From 8c1e53a8dff6f87237508c6f9a1da17ce99ad767 Mon Sep 17 00:00:00 2001 From: Raul Ferreira Fuentes Date: Mon, 11 Apr 2022 20:04:16 +0200 Subject: [PATCH] Fix test case which relied on `mapper->delete()` returning a bool value Signed-off-by: Raul Ferreira Fuentes --- lib/Service/BoardService.php | 4 +--- tests/unit/Service/BoardServiceTest.php | 2 +- tests/unit/Service/CardServiceTest.php | 1 + 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/Service/BoardService.php b/lib/Service/BoardService.php index e1cfc8023..4dd2b05c3 100644 --- a/lib/Service/BoardService.php +++ b/lib/Service/BoardService.php @@ -625,11 +625,9 @@ class BoardService { } catch (\Exception $e) { } } - $delete = $this->aclMapper->delete($acl); $this->eventDispatcher->dispatchTyped(new AclDeletedEvent($acl)); - - return $delete; + return (bool) $this->aclMapper->delete($acl); } /** diff --git a/tests/unit/Service/BoardServiceTest.php b/tests/unit/Service/BoardServiceTest.php index 0e8bfeb15..702e16cd4 100644 --- a/tests/unit/Service/BoardServiceTest.php +++ b/tests/unit/Service/BoardServiceTest.php @@ -420,7 +420,7 @@ class BoardServiceTest extends TestCase { $this->aclMapper->expects($this->once()) ->method('delete') ->with($acl) - ->willReturn(true); + ->willReturn($acl); $this->assertTrue($this->service->deleteAcl(123)); } } diff --git a/tests/unit/Service/CardServiceTest.php b/tests/unit/Service/CardServiceTest.php index 622b22c5b..ca260dc9b 100644 --- a/tests/unit/Service/CardServiceTest.php +++ b/tests/unit/Service/CardServiceTest.php @@ -160,6 +160,7 @@ class CardServiceTest extends TestCase { $cardExpected->setAssignedUsers(['user1', 'user2']); $cardExpected->setRelatedBoard($boardMock); $cardExpected->setRelatedStack($stackMock); + $cardExpected->setLabels([]); $this->assertEquals($cardExpected, $this->cardService->find(123)); }