[lint] fix warnings not autofixed by ruff

app/controllers/aaManager.py

@@ -1,15 +1,24 @@
 import logging
 
-logger = logging.getLogger(__name__)
-
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.orm import selectinload
 from sqlmodel import Session, select
 
-from app.model.models import *
+from app.model.models import (
+    AccessAuthorizationCreate,
+    AccessAuthorizationResponse,
+    Timetable,
+    AccessAuthorizationDB,
+    OneShotAccess,
+    GroupResponse,
+    GroupDB,
+    AccessAuthorizationUpdate,
+)
 from app.services.auth import auth_is_admin
 from app.services.database import add_and_refresh, get_session
 
+logger = logging.getLogger(__name__)
+
 aa_router = APIRouter(prefix="/api/v1/aa", tags=["AccessAuth"])
 
 

app/controllers/cardManager.py

@@ -1,7 +1,4 @@
 import logging
-
-logger = logging.getLogger(__name__)
-
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.exc import NoResultFound
 from sqlmodel import Session, select
@@ -11,12 +8,14 @@ from app.services.auth import auth_is_admin
 from app.services.database import add_and_refresh, get_session
 from app.services.scanner import DeleteCard, WriteNewCard
 
+logger = logging.getLogger(__name__)
+
 card_router = APIRouter(prefix="/api/v1/cards", tags=["Card"])
 
 
 def register_card(cardInput: CardCreate):
     key, uid = WriteNewCard()
-    if key == None:
+    if key is None:
         logger.info("No card registered. Check logs!")
         raise HTTPException(
             status.HTTP_417_EXPECTATION_FAILED, detail="No card registered. Check logs!"
@@ -40,7 +39,7 @@ def add_card(
     try:
         assert (
             db.exec(select(Card).where(Card.name == cardInput.name)).one_or_none()
-            == None
+            is None
         )
     except AssertionError:
         raise HTTPException(status.HTTP_409_CONFLICT, detail="Name already used!")

app/controllers/debugManager.py

@@ -1,14 +1,14 @@
 import logging
-
-logger = logging.getLogger(__name__)
 from fastapi import APIRouter, Depends, HTTPException
 from sqlalchemy import exc
 from sqlmodel import Session, select
 
-from app.model.models import *
+from app.model.models import Card
 from app.services.auth import auth_is_admin
 from app.services.database import add_and_refresh, get_session
 
+logger = logging.getLogger(__name__)
+
 debug_router = APIRouter(
     prefix="/api/v1/debug",
     tags=["Debug items - maybe dont show this in UI"],

app/controllers/doorManager.py

@@ -14,7 +14,9 @@ def open_door(db: Session = Depends(get_session), admin: bool = Depends(auth_is_
 
 
 @door_router.put("/close")
-def open_door(db: Session = Depends(get_session), admin: bool = Depends(auth_is_admin)):
+def close_door(
+    db: Session = Depends(get_session), admin: bool = Depends(auth_is_admin)
+):
     doorService.closedoor()
 
 

app/controllers/userManager.py

@@ -1,14 +1,13 @@
 import logging
-
-logger = logging.getLogger(__name__)
-
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlmodel import Session, select
 
-from ..model.models import UserCreate, UserDB, UserResponse, UserUpdate
-from ..services.auth import auth_is_admin, get_password_hash
-from ..services.auth import get_current_user as auth_user
-from ..services.database import add_and_refresh, get_session
+from app.model.models import UserCreate, UserDB, UserResponse, UserUpdate
+from app.services.auth import auth_is_admin, get_password_hash
+from app.services.auth import get_current_user as auth_user
+from app.services.database import add_and_refresh, get_session
+
+logger = logging.getLogger(__name__)
 
 user_router = APIRouter(tags=["Users"], prefix="/api/v1/users")
 
@@ -24,7 +23,7 @@ def create_user(
     try:
         assert (
             db.exec(select(UserDB).where(UserDB.name == user.name)).one_or_none()
-            == None
+            is None
         )
     except AssertionError:
         raise HTTPException(status.HTTP_409_CONFLICT, detail="Name already used!")