kalipso/racalmas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use sorted keys on SQL update statement

Browse Source 
make sure, sorted keys are used for query and binding variable.
This commit is contained in:
Milan
2020-02-29 23:01:49 +01:00
parent 9b392ae0f4
commit 9f8170507e
13 changed files with 48 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/calcms/db.pm
View File

@@ -138,15 +138,16 @@ sub insert ($$$){
my $tablename = shift;
my $entry = shift;
my $keys = join( ",", map { $_ } ( keys %$entry ) );
my $values = join( ",", map { '?' } ( keys %$entry ) );
my @bind_values = map { $entry->{$_} } ( keys %$entry );
my @keys = sort keys %$entry;
my $keys = join( ",", @keys );
my $values = join( ",", map { '?' } @keys );
my @bind_values = map { $entry->{$_} } @keys;
my $sql = "insert into $tablename \n ($keys) \n values ($values);\n";
if ( $debug_write == 1 ) {
print STDERR $sql . "\n";
print STDERR Dumper( \@bind_values ) . "\n" if (@bind_values);
print STDERR Dumper( \@bind_values ) . "\n" if scalar(@bind_values);
}
put( $dbh, $sql, \@bind_values );