From 96c5bad0e61dad3e8f6a5fab81e1e0a3ba620962 Mon Sep 17 00:00:00 2001
From: Milan <mc@radiopiloten.de>
Date: Fri, 17 Feb 2023 21:45:56 +0100
Subject: [PATCH] db.pm: fix table columns

-query the previously connected database on fetching table columns
-avoid small/big letter on accessing the database schema
---
 lib/calcms/db.pm | 25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/lib/calcms/db.pm b/lib/calcms/db.pm
index a40b00a..6f115e0 100644
--- a/lib/calcms/db.pm
+++ b/lib/calcms/db.pm
@@ -25,6 +25,7 @@ our $read  = 1;
 our $write = 1;
 
 # connect to database
+my $database;
 sub connect($;$) {
     my ($options, $request) = @_;
 
@@ -33,7 +34,7 @@ sub connect($;$) {
     my $access_options = $options->{access};
     my $hostname = $access_options->{hostname};
     my $port     = $access_options->{port};
-    my $database = $access_options->{database};
+    $database    = $access_options->{database};
     my $username = $access_options->{username};
     my $password = $access_options->{password};
 
@@ -92,18 +93,24 @@ sub get($$;$) {
 
 # get list of table columns
 sub get_columns($$) {
-    my ($dbh, $table) =@_;
-
-    my $columns = db::get( $dbh, 'select column_name from information_schema.columns where table_name=?', [$table] );
-    return [ map { $_->{column_name} } @$columns ];
+    my ($dbh, $table) = @_;
+    my $columns = db::get( $dbh,
+        qq{
+            select column_name from information_schema.columns
+            where table_schema=?
+            and table_name = ?
+            order by ordinal_position
+        },
+        [$database, $table]
+    );
+    return [ map { values %$_ } @$columns ];
 }
 
 # get hash with table columns as keys
 sub get_columns_hash($$) {
-    my ($dbh, $table) =@_;
-
-    my $columns = db::get( $dbh, 'select column_name from information_schema.columns where table_name=?', [$table] );
-    return { map { $_->{column_name} => 1 } @$columns };
+    my ($dbh, $table) = @_;
+    my $columns = get_columns($dbh, $table);
+    return { map { $_ => 1 } @$columns };
 }
 
 #returns last inserted id