Bump version to 1.2.9

Signed-off-by: Julius Härtl <jus@bitgrid.net>

.github/workflows/app-code-check.yml

@@ -1,55 +0,0 @@
-name: Nextcloud app code check
-
-on:
-  pull_request:
-  push:
-    branches:
-      - master
-      - stable*
-
-env:
-  APP_NAME: deck
-
-jobs:
-  unit-tests:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        php-versions: ['7.4']
-        server-versions: ['master', 'stable18', 'stable19', 'stable20']
-
-    name: AppCode check php${{ matrix.php-versions }}-${{ matrix.server-versions }}
-    steps:
-      - name: Checkout server
-        uses: actions/checkout@v2
-        with:
-          repository: nextcloud/server
-          ref: ${{ matrix.server-versions }}
-
-      - name: Checkout submodules
-        shell: bash
-        run: |
-          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
-          git submodule sync --recursive
-          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
-
-      - name: Checkout app
-        uses: actions/checkout@v2
-        with:
-          path: apps/${{ env.APP_NAME }}
-
-      - name: Set up php ${{ matrix.php-versions }}
-        uses: shivammathur/setup-php@v1
-        with:
-          php-version: ${{ matrix.php-versions }}
-          tools: phpunit
-          extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite
-
-      - name: Checkout app
-        uses: actions/checkout@v2
-        with:
-          path: apps/${{ env.APP_NAME }}
-
-      - name: App code check
-        run: php occ app:check-code ${{ env.APP_NAME }}

.github/workflows/appbuild.yml

@@ -6,7 +6,7 @@ on:
 jobs:
   build:
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     strategy:
       matrix:

.github/workflows/integration.yml

@@ -34,7 +34,7 @@ jobs:
           POSTGRES_DB: nextcloud
         options: --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
       mysql:
-        image: mariadb
+        image: mariadb:10.5
         ports:
           - 4444:3306/tcp
         env:

.github/workflows/phpunit.yml

@@ -35,7 +35,7 @@ jobs:
           POSTGRES_DB: nextcloud
         options: --health-cmd pg_isready --health-interval 5s --health-timeout 2s --health-retries 5
       mysql:
-        image: mariadb
+        image: mariadb:10.5
         ports:
           - 4444:3306/tcp
         env:
@@ -66,7 +66,7 @@ jobs:
         with:
           php-version: ${{ matrix.php-versions }}
           tools: phpunit
-          extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, mysql, pdo_mysql, pgsql, pdo_pgsql
+          extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, mysql, pdo_mysql, pgsql, pdo_pgsql, zip, gd
           coverage: none
 
       - name: Set up PHPUnit

CHANGELOG.md

@@ -1,6 +1,49 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+
+## 1.2.9
+
+### Other
+
+- #3319 Additional check for stacks
+- #3226 Additional circle level check
+
+
+## 1.2.8
+
+### Fixed
+
+* [#3090](https://github.com/nextcloud/deck/pull/3090) Always fetch attachments
+* [#3163](https://github.com/nextcloud/deck/pull/3163) Always log generic exceptions
+
+
+## 1.2.7
+
+### Fixed
+
+* [#2966](https://github.com/nextcloud/deck/pull/2966) Fix navigating to board details
+* [#2985](https://github.com/nextcloud/deck/pull/2985) Fix codemirror description width
+* [#2993](https://github.com/nextcloud/deck/pull/2993) Remove notification on unshare and add type hints
+* [#3007](https://github.com/nextcloud/deck/pull/3007) Only import debounce
+* [#3009](https://github.com/nextcloud/deck/pull/3009) Do not query the lookupserver when looking for sharees
+
+
+## 1.2.6 - 2021-04-07
+
+### Fixed
+* [#2925](https://github.com/nextcloud/deck/pull/2925) Avoid reusing the existing route object to make navigation work properly
+* [#2947](https://github.com/nextcloud/deck/pull/2947) Fix bug when saving the description
+
+
+## 1.2.5 - 2021-03-05
+
+### Fixed
+
+* [#2845](https://github.com/nextcloud/deck/pull/2845) Search by mail on the board sharing input
+* [#2850](https://github.com/nextcloud/deck/pull/2850) Switch to Content-Disposition attachment and check for sane mimetypes
+* [#2860](https://github.com/nextcloud/deck/pull/2860) Properly pass the user to fetch circles when calling through occ
+
 ## 1.2.4 - 2021-02-02
 
 ### Fixed
@@ -131,31 +174,31 @@ All notable changes to this project will be documented in this file.
 ### Fixed
 
 
-* [#2116](https://github.com/nextcloud/deck/pull/2116) Fix navigation layout issues @juliushaertl
+* [#2116](https://github.com/nextcloud/deck/pull/2116) Fix navigation layout issues
-* [#2118](https://github.com/nextcloud/deck/pull/2118) Use proper parameter when handling attachments @juliushaertl
+* [#2118](https://github.com/nextcloud/deck/pull/2118) Use proper parameter when handling attachments
 
 ## 1.0.4 - 2020-06-26
 
 ### Fixed
 
-* [#2062](https://github.com/nextcloud/deck/pull/2062) Fix saving card description after toggling checkboxes @juliushaertl
+* [#2062](https://github.com/nextcloud/deck/pull/2062) Fix saving card description after toggling checkboxes
 * [#2065](https://github.com/nextcloud/deck/pull/2065) Adding CSS rule for Markdown Blockquotes @reox
-* [#2059](https://github.com/nextcloud/deck/pull/2059) Fix fetching attachments on card change @juliushaertl
+* [#2059](https://github.com/nextcloud/deck/pull/2059) Fix fetching attachments on card change
-* [#2060](https://github.com/nextcloud/deck/pull/2060) Use mixing for relative date in card sidebar @juliushaertl
+* [#2060](https://github.com/nextcloud/deck/pull/2060) Use mixing for relative date in card sidebar
 
 
 ## 1.0.3 - 2020-06-19
 
 ### Fixed
 
-* [#2019](https://github.com/nextcloud/deck/pull/2019) Remove old global css rule @juliushaertl
+* [#2019](https://github.com/nextcloud/deck/pull/2019) Remove old global css rule
-* [#2020](https://github.com/nextcloud/deck/pull/2020) Fix navigation issue with leftover nodes @juliushaertl
+* [#2020](https://github.com/nextcloud/deck/pull/2020) Fix navigation issue with leftover nodes
-* [#2021](https://github.com/nextcloud/deck/pull/2021) Fix description issues @juliushaertl
+* [#2021](https://github.com/nextcloud/deck/pull/2021) Fix description issues
-* [#2022](https://github.com/nextcloud/deck/pull/2022) Fix replyto issues with the comments API @juliushaertl
+* [#2022](https://github.com/nextcloud/deck/pull/2022) Fix replyto issues with the comments API
-* [#2027](https://github.com/nextcloud/deck/pull/2027) Allow to unassign current user from card @juliushaertl
+* [#2027](https://github.com/nextcloud/deck/pull/2027) Allow to unassign current user from card
 * [#2029](https://github.com/nextcloud/deck/pull/2029) Fix wording : stack -> list @cloud2018
-* [#2032](https://github.com/nextcloud/deck/pull/2032) Force order by id as second sorting key @juliushaertl
+* [#2032](https://github.com/nextcloud/deck/pull/2032) Force order by id as second sorting key
-* [#2045](https://github.com/nextcloud/deck/pull/2045) Improve label styling @juliushaertl
+* [#2045](https://github.com/nextcloud/deck/pull/2045) Improve label styling
 * [#2010](https://github.com/nextcloud/deck/pull/2010) User documentation fixes @Nyco
 * [#1998](https://github.com/nextcloud/deck/pull/1998) Add Checklist explaination to the doc @4rnoP
 

appinfo/info.xml

@@ -1,6 +1,5 @@
-<?xml version="1.0"?>
+<?xml version="1.0" encoding="utf-8"?>
-<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
+<info xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
-      xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
     <id>deck</id>
     <name>Deck</name>
     <summary>Personal planning and team project organization</summary>
@@ -17,12 +16,12 @@
 - 🚀 Get your project organized
 
 </description>
-    <version>1.2.4</version>
+    <version>1.2.9</version>
     <licence>agpl</licence>
     <author>Julius Härtl</author>
     <namespace>Deck</namespace>
     <types>
-        <dav />
+        <dav/>
     </types>
     <category>organization</category>
     <category>office</category>
@@ -36,7 +35,7 @@
         <database min-version="9.4">pgsql</database>
         <database>sqlite</database>
         <database min-version="5.5">mysql</database>
-        <nextcloud min-version="18" max-version="20" />
+        <nextcloud min-version="18" max-version="20"/>
     </dependencies>
     <background-jobs>
         <job>OCA\Deck\Cron\DeleteCron</job>

lib/Db/BoardMapper.php

@@ -35,6 +35,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 	private $stackMapper;
 	private $userManager;
 	private $groupManager;
+	private $logger;
 
 	private $circlesEnabled;
 
@@ -44,7 +45,8 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 		AclMapper $aclMapper,
 		StackMapper $stackMapper,
 		IUserManager $userManager,
-		IGroupManager $groupManager
+		IGroupManager $groupManager,
+		ILogger $logger
 	) {
 		parent::__construct($db, 'deck_boards', Board::class);
 		$this->labelMapper = $labelMapper;
@@ -52,6 +54,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 		$this->stackMapper = $stackMapper;
 		$this->userManager = $userManager;
 		$this->groupManager = $groupManager;
+		$this->logger = $logger;
 
 		$this->circlesEnabled = \OC::$server->getAppManager()->isEnabledForUser('circles');
 	}
@@ -159,7 +162,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 		}
 		$circles = array_map(function ($circle) {
 			return $circle->getUniqueId();
-		}, \OCA\Circles\Api\v1\Circles::joinedCircles('', true));
+		}, \OCA\Circles\Api\v1\Circles::joinedCircles($userId, true));
 		if (count($circles) === 0) {
 			return [];
 		}
@@ -238,7 +241,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 				if ($user !== null) {
 					return new User($user);
 				}
-				\OC::$server->getLogger()->debug('User ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
+				$this->logger->debug('User ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
 				return null;
 			}
 			if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
@@ -246,7 +249,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 				if ($group !== null) {
 					return new Group($group);
 				}
-				\OC::$server->getLogger()->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
+				$this->logger->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant());
 				return null;
 			}
 			if ($acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) {
@@ -258,11 +261,12 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
 					if ($circle) {
 						return new Circle($circle);
 					}
-				} catch (\Exception $e) {
+				} catch (\Throwable $e) {
+					$this->logger->error('Failed to get circle details when building ACL', ['exception' => $e]);
 				}
 				return null;
 			}
-			\OC::$server->getLogger()->log(ILogger::WARN, 'Unknown permission type for mapping acl ' . $acl->getId());
+			$this->logger->warning('Unknown permission type for mapping acl ' . $acl->getId());
 			return null;
 		});
 	}

lib/Middleware/ExceptionMiddleware.php

@@ -98,9 +98,7 @@ class ExceptionMiddleware extends Middleware {
 				'status' => 500,
 				'message' => $exception->getMessage()
 			];
-			if ($this->config->getSystemValue('loglevel', Util::WARN) === Util::DEBUG) {
+			$this->logger->logException($exception);
-				$this->logger->logException($exception);
-			}
 			if ($this->config->getSystemValue('debug', true) === true) {
 				$response['exception'] = (array) $exception;
 			}

lib/Notification/NotificationHelper.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * @copyright Copyright (c) 2017 Julius Härtl <jus@bitgrid.net>
  *
@@ -24,19 +27,24 @@
 namespace OCA\Deck\Notification;
 
 use DateTime;
+use Exception;
 use OCA\Deck\AppInfo\Application;
 use OCA\Deck\Db\Acl;
 use OCA\Deck\Db\AssignmentMapper;
 use OCA\Deck\Db\Board;
 use OCA\Deck\Db\BoardMapper;
+use OCA\Deck\Db\Card;
 use OCA\Deck\Db\CardMapper;
 use OCA\Deck\Db\User;
 use OCA\Deck\Service\ConfigService;
 use OCA\Deck\Service\PermissionService;
+use OCP\AppFramework\Db\DoesNotExistException;
+use OCP\AppFramework\Db\MultipleObjectsReturnedException;
 use OCP\Comments\IComment;
 use OCP\IConfig;
 use OCP\IGroupManager;
 use OCP\Notification\IManager;
+use OCP\Notification\INotification;
 
 class NotificationHelper {
 
@@ -80,10 +88,10 @@ class NotificationHelper {
 	}
 
 	/**
-	 * @param $card
+	 * @throws DoesNotExistException
-	 * @throws \OCP\AppFramework\Db\DoesNotExistException
+	 * @throws Exception thrown on invalid due date
 	 */
-	public function sendCardDuedate($card) {
+	public function sendCardDuedate(Card $card): void {
 		// check if notification has already been sent
 		// ideally notifications should not be deleted once seen by the user so we can
 		// also deliver due date notifications for users who have been added later to a board
@@ -117,7 +125,7 @@ class NotificationHelper {
 				$notification
 					->setApp('deck')
 					->setUser((string)$user->getUID())
-					->setObject('card', $card->getId())
+					->setObject('card', (string)$card->getId())
 					->setSubject('card-overdue', [
 						$card->getTitle(), $board->getTitle()
 					])
@@ -128,25 +136,29 @@ class NotificationHelper {
 		$this->cardMapper->markNotified($card);
 	}
 
-	public function markDuedateAsRead($card) {
+	public function markDuedateAsRead(Card $card): void {
 		$notification = $this->notificationManager->createNotification();
 		$notification
 			->setApp('deck')
-			->setObject('card', $card->getId())
+			->setObject('card', (string)$card->getId())
 			->setSubject('card-overdue', []);
 		$this->notificationManager->markProcessed($notification);
 	}
 
-	public function sendCardAssigned($card, $userId) {
+	public function sendCardAssigned(Card $card, string $userId): void {
 		$boardId = $this->cardMapper->findBoardId($card->getId());
-		$board = $this->getBoard($boardId);
+		try {
+			$board = $this->getBoard($boardId);
+		} catch (Exception $e) {
+			return;
+		}
 
 		$notification = $this->notificationManager->createNotification();
 		$notification
 			->setApp('deck')
-			->setUser((string) $userId)
+			->setUser($userId)
 			->setDateTime(new DateTime())
-			->setObject('card', $card->getId())
+			->setObject('card', (string)$card->getId())
 				->setSubject('card-assigned', [
 					$card->getTitle(),
 					$board->getTitle(),
@@ -155,29 +167,56 @@ class NotificationHelper {
 		$this->notificationManager->notify($notification);
 	}
 
+	public function markCardAssignedAsRead(Card $card, string $userId): void {
+		$notification = $this->notificationManager->createNotification();
+		$notification
+			->setApp('deck')
+			->setUser($userId)
+			->setObject('card', (string)$card->getId())
+			->setSubject('card-assigned', []);
+		$this->notificationManager->markProcessed($notification);
+	}
+
 	/**
 	 * Send notifications that a board was shared with a user/group
-	 *
-	 * @param $boardId
-	 * @param Acl $acl
-	 * @throws \InvalidArgumentException
 	 */
-	public function sendBoardShared($boardId, $acl) {
+	public function sendBoardShared(int $boardId, Acl $acl, bool $markAsRead = false): void {
-		$board = $this->getBoard($boardId);
+		try {
+			$board = $this->getBoard($boardId);
+		} catch (Exception $e) {
+			return;
+		}
+
 		if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {
 			$notification = $this->generateBoardShared($board, $acl->getParticipant());
-			$this->notificationManager->notify($notification);
+			if ($markAsRead) {
+				$this->notificationManager->markProcessed($notification);
+			} else {
+				$notification->setDateTime(new DateTime());
+				$this->notificationManager->notify($notification);
+			}
 		}
 		if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) {
 			$group = $this->groupManager->get($acl->getParticipant());
+			if ($group === null) {
+				return;
+			}
 			foreach ($group->getUsers() as $user) {
+				if ($user->getUID() === $this->currentUser) {
+					continue;
+				}
 				$notification = $this->generateBoardShared($board, $user->getUID());
-				$this->notificationManager->notify($notification);
+				if ($markAsRead) {
+					$this->notificationManager->markProcessed($notification);
+				} else {
+					$notification->setDateTime(new DateTime());
+					$this->notificationManager->notify($notification);
+				}
 			}
 		}
 	}
 
-	public function sendMention(IComment $comment) {
+	public function sendMention(IComment $comment): void {
 		foreach ($comment->getMentions() as $mention) {
 			$card = $this->cardMapper->find($comment->getObjectId());
 			$boardId = $this->cardMapper->findBoardId($card->getId());
@@ -194,27 +233,22 @@ class NotificationHelper {
 	}
 
 	/**
-	 * @param $boardId
+	 * @throws DoesNotExistException
-	 * @return Board
+	 * @throws MultipleObjectsReturnedException
-	 * @throws \OCP\AppFramework\Db\DoesNotExistException
 	 */
-	private function getBoard($boardId, bool $withLabels = false, bool $withAcl = false) {
+	private function getBoard(int $boardId, bool $withLabels = false, bool $withAcl = false): Board {
 		if (!array_key_exists($boardId, $this->boards)) {
 			$this->boards[$boardId] = $this->boardMapper->find($boardId, $withLabels, $withAcl);
 		}
 		return $this->boards[$boardId];
 	}
-
+	
-	/**
+	private function generateBoardShared(Board $board, string $userId): INotification {
-	 * @param Board $board
-	 */
-	private function generateBoardShared($board, $userId) {
 		$notification = $this->notificationManager->createNotification();
 		$notification
 			->setApp('deck')
-			->setUser((string) $userId)
+			->setUser($userId)
-			->setDateTime(new DateTime())
+			->setObject('board', (string)$board->getId())
-			->setObject('board', $board->getId())
 			->setSubject('board-shared', [$board->getTitle(), $this->currentUser]);
 		return $notification;
 	}

lib/Service/AssignmentService.php

@@ -74,6 +74,8 @@ class AssignmentService {
 	 * @var IEventDispatcher
 	 */
 	private $eventDispatcher;
+	/** @var string|null */
+	private $currentUser;
 
 	public function __construct(
 		PermissionService $permissionService,
@@ -138,8 +140,7 @@ class AssignmentService {
 		}
 
 
-		if ($userId !== $this->currentUser) {
+		if ($type === Assignment::TYPE_USER && $userId !== $this->currentUser) {
-			/* Notifyuser about the card assignment */
 			$this->notificationHelper->sendCardAssigned($card, $userId);
 		}
 
@@ -185,6 +186,9 @@ class AssignmentService {
 				$assignment = $this->assignedUsersMapper->delete($assignment);
 				$card = $this->cardMapper->find($cardId);
 				$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_CARD, $card, ActivityManager::SUBJECT_CARD_USER_UNASSIGN, ['assigneduser' => $userId]);
+				if ($type === Assignment::TYPE_USER && $userId !== $this->currentUser) {
+					$this->notificationHelper->markCardAssignedAsRead($card, $userId);
+				}
 				$this->changeHelper->cardChanged($cardId);
 
 				$this->eventDispatcher->dispatch(

lib/Service/BoardService.php

@@ -532,11 +532,10 @@ class BoardService {
 		$acl->setPermissionShare($share);
 		$acl->setPermissionManage($manage);
 
-		/* Notify users about the shared board */
-		$this->notificationHelper->sendBoardShared($boardId, $acl);
-
 		$newAcl = $this->aclMapper->insert($acl);
+
 		$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_BOARD, $newAcl, ActivityManager::SUBJECT_BOARD_SHARE);
+		$this->notificationHelper->sendBoardShared((int)$boardId, $newAcl);
 		$this->boardMapper->mapAcl($newAcl);
 		$this->changeHelper->boardChanged($boardId);
 
@@ -628,6 +627,7 @@ class BoardService {
 			}
 		}
 		$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_BOARD, $acl, ActivityManager::SUBJECT_BOARD_UNSHARE);
+		$this->notificationHelper->sendBoardShared($acl->getBoardId(), $acl, true);
 		$this->changeHelper->boardChanged($acl->getBoardId());
 
 		$version = \OCP\Util::getVersion()[0];

lib/Service/CardService.php

@@ -240,6 +240,7 @@ class CardService {
 		$card->setDeletedAt(time());
 		$this->cardMapper->update($card);
 		$this->activityManager->triggerEvent(ActivityManager::DECK_OBJECT_CARD, $card, ActivityManager::SUBJECT_CARD_DELETE);
+		$this->notificationHelper->markDuedateAsRead($card);
 		$this->changeHelper->cardChanged($card->getId(), false);
 
 		$this->eventDispatcher->dispatch(
@@ -322,6 +323,15 @@ class CardService {
 		$card->setOrder($order);
 		$card->setOwner($owner);
 		$card->setDuedate($duedate);
+		$resetDuedateNotification = false;
+		if (
+			$card->getDuedate() === null ||
+			(new \DateTime($card->getDuedate())) != (new \DateTime($changes->getBefore()->getDuedate()))
+		) {
+			$card->setNotified(false);
+			$resetDuedateNotification = true;
+		}
+
 		if ($deletedAt !== null) {
 			$card->setDeletedAt($deletedAt);
 		}
@@ -341,6 +351,9 @@ class CardService {
 
 
 		$card = $this->cardMapper->update($card);
+		if ($resetDuedateNotification) {
+			$this->notificationHelper->markDuedateAsRead($card);
+		}
 		$this->changeHelper->cardChanged($card->getId(), true);
 
 		$this->eventDispatcher->dispatch(

lib/Service/CirclesService.php

@@ -26,6 +26,7 @@ declare(strict_types=1);
 
 namespace OCA\Deck\Service;
 
+use OCA\Circles\Api\v1\Circles;
 use OCP\App\IAppManager;
 
 /**
@@ -53,8 +54,8 @@ class CirclesService {
 		}
 
 		try {
-			\OCA\Circles\Api\v1\Circles::getMember($circleId, $userId, 1, true);
+			$member = \OCA\Circles\Api\v1\Circles::getMember($circleId, $userId, 1, true);
-			return true;
+			return $member->getLevel() >= Circles::LEVEL_MEMBER;
 		} catch (\Exception $e) {
 		}
 		return false;

lib/Service/FileService.php

@@ -27,10 +27,9 @@ use OCA\Deck\Db\Attachment;
 use OCA\Deck\Db\AttachmentMapper;
 use OCA\Deck\StatusException;
 use OCA\Deck\Exceptions\ConflictException;
-use OCP\AppFramework\Http\ContentSecurityPolicy;
-use OCP\AppFramework\Http\FileDisplayResponse;
 use OCP\AppFramework\Http\StreamResponse;
 use OCP\Files\IAppData;
+use OCP\Files\IMimeTypeDetector;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotFoundException;
 use OCP\Files\NotPermittedException;
@@ -49,6 +48,7 @@ class FileService implements IAttachmentService {
 	private $rootFolder;
 	private $config;
 	private $attachmentMapper;
+	private $mimeTypeDetector;
 
 	public function __construct(
 		IL10N $l10n,
@@ -57,7 +57,8 @@ class FileService implements IAttachmentService {
 		ILogger $logger,
 		IRootFolder $rootFolder,
 		IConfig $config,
-		AttachmentMapper $attachmentMapper
+		AttachmentMapper $attachmentMapper,
+		IMimeTypeDetector $mimeTypeDetector
 	) {
 		$this->l10n = $l10n;
 		$this->appData = $appData;
@@ -66,6 +67,7 @@ class FileService implements IAttachmentService {
 		$this->rootFolder = $rootFolder;
 		$this->config = $config;
 		$this->attachmentMapper = $attachmentMapper;
+		$this->mimeTypeDetector = $mimeTypeDetector;
 	}
 
 	/**
@@ -225,27 +227,14 @@ class FileService implements IAttachmentService {
 
 	/**
 	 * @param Attachment $attachment
-	 * @return FileDisplayResponse|\OCP\AppFramework\Http\Response|StreamResponse
+	 * @return StreamResponse
 	 * @throws \Exception
 	 */
 	public function display(Attachment $attachment) {
 		$file = $this->getFileFromRootFolder($attachment);
-		if (method_exists($file, 'fopen')) {
+		$response = new StreamResponse($file->fopen('rb'));
-			$response = new StreamResponse($file->fopen('r'));
+		$response->addHeader('Content-Disposition', 'attachment; filename="' . rawurldecode($file->getName()) . '"');
-			$response->addHeader('Content-Disposition', 'inline; filename="' . rawurldecode($file->getName()) . '"');
+		$response->addHeader('Content-Type', $this->mimeTypeDetector->getSecureMimeType($file->getMimeType()));
-		} else {
-			$response = new FileDisplayResponse($file);
-		}
-		// We need those since otherwise chrome won't show the PDF file with CSP rule object-src 'none'
-		// https://bugs.chromium.org/p/chromium/issues/detail?id=271452
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedObjectDomain('\'self\'');
-		$policy->addAllowedObjectDomain('blob:');
-		$policy->addAllowedMediaDomain('\'self\'');
-		$policy->addAllowedMediaDomain('blob:');
-		$response->setContentSecurityPolicy($policy);
-
-		$response->addHeader('Content-Type', $file->getMimeType());
 		return $response;
 	}
 

lib/Service/PermissionService.php

@@ -23,6 +23,7 @@
 
 namespace OCA\Deck\Service;
 
+use OCA\Circles\Model\Member;
 use OCA\Deck\Db\Acl;
 use OCA\Deck\Db\AclMapper;
 use OCA\Deck\Db\Board;
@@ -194,8 +195,8 @@ class PermissionService {
 
 			if ($this->circlesEnabled && $acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) {
 				try {
-					\OCA\Circles\Api\v1\Circles::getMember($acl->getParticipant(), $this->userId, 1, true);
+					$member = \OCA\Circles\Api\v1\Circles::getMember($acl->getParticipant(), $this->userId, 1, true);
-					return $acl->getPermission($permission);
+					return $member->getLevel() >= Member::LEVEL_MEMBER && $acl->getPermission($permission);
 				} catch (\Exception $e) {
 					$this->logger->info('Member not found in circle that was accessed. This should not happen.');
 				}

lib/Service/StackService.php

@@ -114,6 +114,7 @@ class StackService {
 			throw new BadRequestException('stack id must be a number');
 		}
 
+		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_READ);
 		$stack = $this->stackMapper->find($stackId);
 		$cards = $this->cardMapper->findAll($stackId);
 		foreach ($cards as $cardIndex => $card) {

package.json

@@ -1,7 +1,7 @@
 {
 	"name": "deck",
 	"description": "",
-	"version": "1.0.0",
+	"version": "1.2.9",
 	"authors": [
 		{
 			"name": "Julius Härtl",
@@ -129,4 +129,4 @@
 			"<rootDir>/node_modules/jest-serializer-vue"
 		]
 	}
-}
+}

src/components/board/SharingTabSidebar.vue

@@ -10,7 +10,7 @@
 			:loading="isLoading || !!isSearching"
 			:disabled="isLoading"
 			track-by="multiselectKey"
-			:internal-search="true"
+			:internal-search="false"
 			@input="clickAddAcl"
 			@search-change="asyncFind">
 			<template #noOptions>
@@ -73,6 +73,7 @@ import { CollectionList } from 'nextcloud-vue-collections'
 import { mapGetters, mapState } from 'vuex'
 import { getCurrentUser } from '@nextcloud/auth'
 import { showError } from '@nextcloud/dialogs'
+import debounce from 'lodash/debounce'
 
 export default {
 	name: 'SharingTabSidebar',
@@ -148,18 +149,13 @@ export default {
 		this.asyncFind('')
 	},
 	methods: {
+		debouncedFind: debounce(async function(query) {
+			this.isSearching = true
+			await this.$store.dispatch('loadSharees', query)
+			this.isSearching = false
+		}, 300),
 		async asyncFind(query) {
-			// manual debounce to handle async searching more easily and have more control over the loading state
+			await this.debouncedFind(query)
-			const timestamp = (new Date()).getTime()
-			if (!this.isSearching || timestamp > this.isSearching + 300) {
-				this.isSearching = timestamp
-				await this.$store.dispatch('loadSharees', query)
-
-				// only reset searching flag if the most recent search finished
-				if (this.isSearching === timestamp) {
-					this.isSearching = false
-				}
-			}
 		},
 		async clickAddAcl() {
 			this.addAclForAPI = {

src/components/card/AttachmentList.vue

@@ -151,8 +151,13 @@ export default {
 			}
 		},
 	},
-	created() {
+	watch: {
-		this.$store.dispatch('fetchAttachments', this.cardId)
+		cardId: {
+			immediate: true,
+			handler() {
+				this.$store.dispatch('fetchAttachments', this.cardId)
+			},
+		},
 	},
 	methods: {
 		handleUploadFile(event) {

src/components/card/CardSidebarTabDetails.vue

@@ -117,7 +117,7 @@
 				type="deck-card" />
 		</div>
 
-		<Description :key="card.id" :card="card" />
+		<Description :key="card.id" :card="card" @change="descriptionChanged" />
 	</div>
 </template>
 
@@ -234,6 +234,9 @@ export default {
 		this.initialize()
 	},
 	methods: {
+		descriptionChanged(newDesc) {
+			this.copiedCard.description = newDesc
+		},
 		async initialize() {
 			if (!this.card) {
 				return
@@ -253,9 +256,6 @@ export default {
 			}
 		},
 
-		setDue() {
-			this.$store.dispatch('updateCardDue', this.copiedCard)
-		},
 		removeDue() {
 			this.copiedCard.duedate = null
 			this.$store.dispatch('updateCardDue', this.copiedCard)

src/components/card/Description.vue

@@ -205,6 +205,7 @@ export default {
 			await this.$store.dispatch('updateCardDesc', { ...this.card, description: this.description })
 			this.descriptionLastEdit = 0
 			this.descriptionSaving = false
+			this.$emit('change', this.description)
 		},
 		updateDescription() {
 			this.descriptionLastEdit = Date.now()
@@ -292,6 +293,7 @@ h5 {
 	padding: 0;
 	background-color: var(--color-main-background);
 	color: var(--color-main-text);
+	width: 100%;
 }
 
 .CodeMirror-placeholder {

src/components/navigation/AppNavigationBoard.vue

@@ -235,9 +235,7 @@ export default {
 			try {
 				const newBoard = await this.$store.dispatch('cloneBoard', this.board)
 				this.loading = false
-				const route = this.routeTo
+				this.$router.push({ name: 'board', params: { id: newBoard.id } })
-				route.params.id = newBoard.id
-				this.$router.push(route)
 			} catch (e) {
 				OC.Notification.showTemporary(t('deck', 'An error occurred'))
 				console.error(e)
@@ -278,9 +276,7 @@ export default {
 			)
 		},
 		actionDetails() {
-			const route = this.routeTo
+			this.$router.push({ name: 'board.details', params: { id: this.board.id } })
-			route.name = 'board.details'
-			this.$router.push(route)
 		},
 		applyEdit(e) {
 			this.editing = false
@@ -298,11 +294,6 @@ export default {
 		cancelEdit(e) {
 			this.editing = false
 		},
-		showSidebar() {
-			const route = this.routeTo
-			route.name = 'board.details'
-			this.$router.push(route)
-		},
 		async updateSetting(key, value) {
 			this.updateDueSetting = value
 			const setting = {}

src/store/main.js

@@ -414,7 +414,8 @@ export default new Vuex.Store({
 			params.append('search', query)
 			params.append('format', 'json')
 			params.append('perPage', 20)
-			params.append('itemType', [0, 1, 7])
+			params.append('itemType', [0, 1, 4, 7])
+			params.append('lookup', false)
 
 			const response = await axios.get(generateOcsUrl('apps/files_sharing/api/v1') + 'sharees', { params })
 			commit('setSharees', response.data.ocs.data)

tests/psalm-baseline.xml

@@ -1,21 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.3.1@2feba22a005a18bf31d4c7b9bdb9252c73897476">
+<files psalm-version="4.3.2@57b53ff26237074fdf5cbcb034f7da5172be4524">
   <file src="lib/Activity/ActivityManager.php">
     <TypeDoesNotContainType occurrences="1">
       <code>$message !== null</code>
     </TypeDoesNotContainType>
-    <UndefinedMagicMethod occurrences="9">
-      <code>getArchived</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getCardId</code>
-      <code>getCardId</code>
-      <code>getStackId</code>
-      <code>getTitle</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Activity/DeckProvider.php">
     <InvalidScalarArgument occurrences="1">
@@ -27,25 +15,6 @@
       <code>Application</code>
     </DuplicateClass>
   </file>
-  <file src="lib/AppInfo/Application20.php">
-    <UndefinedClass occurrences="1">
-      <code>IBootstrap</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/AppInfo/ApplicationLegacy.php">
-    <UndefinedInterfaceMethod occurrences="2">
-      <code>listen</code>
-      <code>listen</code>
-    </UndefinedInterfaceMethod>
-  </file>
-  <file src="lib/Collaboration/Resources/ResourceProviderCard.php">
-    <UndefinedMagicMethod occurrences="4">
-      <code>getAcl</code>
-      <code>getOwner</code>
-      <code>getTitle</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
-  </file>
   <file src="lib/Command/UserExport.php">
     <ImplementedReturnTypeMismatch occurrences="1">
       <code>void</code>
@@ -89,13 +58,6 @@
       <code>$parentId</code>
     </InvalidScalarArgument>
   </file>
-  <file src="lib/Controller/PageController.php">
-    <MissingDependency occurrences="3">
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-    </MissingDependency>
-  </file>
   <file src="lib/Controller/StackApiController.php">
     <RedundantCondition occurrences="1">
       <code>$modified !== null</code>
@@ -104,21 +66,6 @@
       <code>Util</code>
     </UndefinedClass>
   </file>
-  <file src="lib/Cron/CardDescriptionActivity.php">
-    <UndefinedClass occurrences="1">
-      <code>Job</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Cron/DeleteCron.php">
-    <UndefinedClass occurrences="1">
-      <code>Job</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Cron/ScheduledNotifications.php">
-    <UndefinedClass occurrences="1">
-      <code>Job</code>
-    </UndefinedClass>
-  </file>
   <file src="lib/DAV/Calendar.php">
     <UndefinedClass occurrences="1">
       <code>ExternalCalendar</code>
@@ -140,18 +87,6 @@
       <code>NotFound</code>
     </UndefinedClass>
   </file>
-  <file src="lib/Dashboard/DeckWidget.php">
-    <UndefinedClass occurrences="1">
-      <code>IWidget</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Db/Acl.php">
-    <UndefinedMagicMethod occurrences="3">
-      <code>getPermissionEdit</code>
-      <code>getPermissionManage</code>
-      <code>getPermissionShare</code>
-    </UndefinedMagicMethod>
-  </file>
   <file src="lib/Db/AclMapper.php">
     <ParamNameMismatch occurrences="1">
       <code>$aclId</code>
@@ -161,60 +96,26 @@
     <ParamNameMismatch occurrences="1">
       <code>$cardId</code>
     </ParamNameMismatch>
-    <UndefinedMagicMethod occurrences="9">
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/AttachmentMapper.php">
-    <UndefinedMagicMethod occurrences="2">
-      <code>getCardId</code>
-      <code>getCardId</code>
-    </UndefinedMagicMethod>
     <UndefinedVariable occurrences="1">
       <code>$query</code>
     </UndefinedVariable>
   </file>
-  <file src="lib/Db/Board.php">
-    <UndefinedMagicMethod occurrences="1">
-      <code>getLastModified</code>
-    </UndefinedMagicMethod>
-  </file>
   <file src="lib/Db/BoardMapper.php">
     <ParamNameMismatch occurrences="1">
       <code>$boardId</code>
     </ParamNameMismatch>
-    <UndefinedClass occurrences="1">
+    <UndefinedClass occurrences="2">
+      <code>\OCA\Circles\Api\v1\Circles</code>
       <code>\OCA\Circles\Api\v1\Circles</code>
     </UndefinedClass>
-    <UndefinedMagicMethod occurrences="2">
-      <code>setAcl</code>
-      <code>setLabels</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/Card.php">
     <UndefinedClass occurrences="2">
       <code>VCalendar</code>
       <code>VCalendar</code>
     </UndefinedClass>
-    <UndefinedMagicMethod occurrences="9">
-      <code>getArchived</code>
-      <code>getArchived</code>
-      <code>getDescription</code>
-      <code>getLabels</code>
-      <code>getLabels</code>
-      <code>getLastModified</code>
-      <code>getLastModified</code>
-      <code>getStackId</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/CardMapper.php">
     <ImplicitToStringCast occurrences="1">
@@ -226,21 +127,6 @@
     <ParamNameMismatch occurrences="1">
       <code>$cardId</code>
     </ParamNameMismatch>
-    <UndefinedMagicMethod occurrences="13">
-      <code>getDescription</code>
-      <code>getDescription</code>
-      <code>getDuedate</code>
-      <code>setCreatedAt</code>
-      <code>setDatabaseType</code>
-      <code>setDatabaseType</code>
-      <code>setDescription</code>
-      <code>setDescription</code>
-      <code>setLabels</code>
-      <code>setLastModified</code>
-      <code>setLastModified</code>
-      <code>setNotified</code>
-      <code>setNotified</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/ChangeHelper.php">
     <UndefinedThisPropertyAssignment occurrences="3">
@@ -269,69 +155,21 @@
       <code>\OCA\Circles\Model\Circle</code>
     </UndefinedDocblockClass>
   </file>
-  <file src="lib/Db/Label.php">
-    <UndefinedMagicMethod occurrences="1">
-      <code>getLastModified</code>
-    </UndefinedMagicMethod>
-  </file>
   <file src="lib/Db/LabelMapper.php">
     <ParamNameMismatch occurrences="1">
       <code>$labelId</code>
     </ParamNameMismatch>
-    <UndefinedMagicMethod occurrences="2">
-      <code>setLastModified</code>
-      <code>setLastModified</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Db/RelationalEntity.php">
-    <UndefinedMagicMethod occurrences="1">
-      <code>getETag</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/Stack.php">
     <UndefinedClass occurrences="2">
       <code>VCalendar</code>
       <code>VCalendar</code>
     </UndefinedClass>
-    <UndefinedMagicMethod occurrences="2">
-      <code>getLastModified</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Db/StackMapper.php">
     <ParamNameMismatch occurrences="1">
       <code>$stackId</code>
     </ParamNameMismatch>
-    <UndefinedMagicMethod occurrences="1">
-      <code>getBoardId</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Listeners/BeforeTemplateRenderedListener.php">
-    <UndefinedClass occurrences="1">
-      <code>BeforeTemplateRenderedEvent</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Migration/UnknownUsers.php">
-    <UndefinedMagicMethod occurrences="4">
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getType</code>
-      <code>getType</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Notification/NotificationHelper.php">
-    <InvalidScalarArgument occurrences="1">
-      <code>$board-&gt;getId()</code>
-    </InvalidScalarArgument>
-    <MissingDependency occurrences="1">
-      <code>Application</code>
-    </MissingDependency>
-    <UndefinedMagicMethod occurrences="3">
-      <code>getTitle</code>
-      <code>getTitle</code>
-      <code>getTitle</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Notification/Notifier.php">
     <RedundantCast occurrences="7">
@@ -348,129 +186,18 @@
     <InvalidPropertyAssignmentValue occurrences="1">
       <code>[]</code>
     </InvalidPropertyAssignmentValue>
-    <UndefinedClass occurrences="2">
-      <code>IndexDocument</code>
-      <code>SearchTemplate</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Search/BoardSearchResultEntry.php">
-    <UndefinedClass occurrences="1">
-      <code>SearchResultEntry</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Search/CardSearchResultEntry.php">
-    <UndefinedClass occurrences="1">
-      <code>SearchResultEntry</code>
-    </UndefinedClass>
-  </file>
-  <file src="lib/Search/DeckProvider.php">
-    <UndefinedClass occurrences="1">
-      <code>IProvider</code>
-    </UndefinedClass>
   </file>
   <file src="lib/Service/AssignmentService.php">
     <InvalidScalarArgument occurrences="2">
       <code>$cardId</code>
       <code>$cardId</code>
     </InvalidScalarArgument>
-    <UndefinedMagicMethod occurrences="9">
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>setCardId</code>
-      <code>setParticipant</code>
-      <code>setType</code>
-    </UndefinedMagicMethod>
-    <UndefinedThisPropertyAssignment occurrences="1">
-      <code>$this-&gt;currentUser</code>
-    </UndefinedThisPropertyAssignment>
-    <UndefinedThisPropertyFetch occurrences="1">
-      <code>$this-&gt;currentUser</code>
-    </UndefinedThisPropertyFetch>
-  </file>
-  <file src="lib/Service/AttachmentService.php">
-    <MissingDependency occurrences="1">
-      <code>Application</code>
-    </MissingDependency>
-    <UndefinedMagicMethod occurrences="13">
-      <code>getCardId</code>
-      <code>getCardId</code>
-      <code>getCardId</code>
-      <code>getData</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>setCardId</code>
-      <code>setCreatedAt</code>
-      <code>setCreatedBy</code>
-      <code>setData</code>
-      <code>setLastModified</code>
-      <code>setLastModified</code>
-      <code>setType</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Service/BoardService.php">
-    <InvalidArgument occurrences="6">
-      <code>'\OCA\Deck\Board::onCreate'</code>
-      <code>'\OCA\Deck\Board::onDelete'</code>
-      <code>'\OCA\Deck\Board::onDelete'</code>
-      <code>'\OCA\Deck\Board::onShareEdit'</code>
-      <code>'\OCA\Deck\Board::onUpdate'</code>
-      <code>'\OCA\Deck\Board::onUpdate'</code>
-    </InvalidArgument>
-    <MissingDependency occurrences="3">
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-    </MissingDependency>
     <TooManyArguments occurrences="2">
       <code>findAll</code>
       <code>findAll</code>
     </TooManyArguments>
-    <UndefinedMagicMethod occurrences="40">
-      <code>getAcl</code>
-      <code>getAcl</code>
-      <code>getAcl</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getParticipant</code>
-      <code>getType</code>
-      <code>setBoardId</code>
-      <code>setBoardId</code>
-      <code>setBoardId</code>
-      <code>setBoardId</code>
-      <code>setColor</code>
-      <code>setColor</code>
-      <code>setColor</code>
-      <code>setColor</code>
-      <code>setColor</code>
-      <code>setLabels</code>
-      <code>setOwner</code>
-      <code>setOwner</code>
-      <code>setParticipant</code>
-      <code>setPermissionEdit</code>
-      <code>setPermissionEdit</code>
-      <code>setPermissionManage</code>
-      <code>setPermissionManage</code>
-      <code>setPermissionShare</code>
-      <code>setPermissionShare</code>
-      <code>setPermissions</code>
-      <code>setPermissions</code>
-      <code>setPermissions</code>
-      <code>setPermissions</code>
-      <code>setSettings</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setType</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Service/CardService.php">
     <TooFewArguments occurrences="1">
@@ -479,52 +206,6 @@
     <UndefinedDocblockClass occurrences="1">
       <code>\OCP\AppFramework\Db\</code>
     </UndefinedDocblockClass>
-    <UndefinedMagicMethod occurrences="44">
-      <code>getArchived</code>
-      <code>getArchived</code>
-      <code>getArchived</code>
-      <code>getArchived</code>
-      <code>getArchived</code>
-      <code>getDescription</code>
-      <code>getDescription</code>
-      <code>getDescription</code>
-      <code>getDescriptionPrev</code>
-      <code>getDescriptionPrev</code>
-      <code>getLastEditor</code>
-      <code>getLastEditor</code>
-      <code>getLastEditor</code>
-      <code>getOrder</code>
-      <code>setArchived</code>
-      <code>setArchived</code>
-      <code>setArchived</code>
-      <code>setAssignedUsers</code>
-      <code>setAssignedUsers</code>
-      <code>setAttachmentCount</code>
-      <code>setAttachments</code>
-      <code>setCommentsUnread</code>
-      <code>setDeletedAt</code>
-      <code>setDeletedAt</code>
-      <code>setDescription</code>
-      <code>setDescription</code>
-      <code>setDescriptionPrev</code>
-      <code>setDescriptionPrev</code>
-      <code>setDuedate</code>
-      <code>setDuedate</code>
-      <code>setLabels</code>
-      <code>setLastEditor</code>
-      <code>setOrder</code>
-      <code>setOrder</code>
-      <code>setOwner</code>
-      <code>setOwner</code>
-      <code>setStackId</code>
-      <code>setStackId</code>
-      <code>setStackId</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-      <code>setType</code>
-      <code>setType</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Service/CirclesService.php">
     <UndefinedClass occurrences="2">
@@ -533,13 +214,6 @@
     </UndefinedClass>
   </file>
   <file src="lib/Service/CommentService.php">
-    <MissingDependency occurrences="5">
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-    </MissingDependency>
     <UndefinedThisPropertyAssignment occurrences="2">
       <code>$this-&gt;cardMapper</code>
       <code>$this-&gt;permissionService</code>
@@ -559,21 +233,8 @@
     <InvalidScalarArgument occurrences="1">
       <code>(int)$value</code>
     </InvalidScalarArgument>
-    <MissingDependency occurrences="7">
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-      <code>Application</code>
-    </MissingDependency>
   </file>
   <file src="lib/Service/DefaultBoardService.php">
-    <MissingDependency occurrences="2">
-      <code>Application</code>
-      <code>Application</code>
-    </MissingDependency>
     <TypeDoesNotContainNull occurrences="6">
       <code>$color === false || $color === null</code>
       <code>$color === null</code>
@@ -597,94 +258,17 @@
       <code>is_resource($content)</code>
       <code>is_resource($content)</code>
     </RedundantCondition>
-    <UndefinedMagicMethod occurrences="10">
-      <code>getCardId</code>
-      <code>getCardId</code>
-      <code>getCardId</code>
-      <code>getData</code>
-      <code>getData</code>
-      <code>setData</code>
-      <code>setData</code>
-      <code>setDeletedAt</code>
-      <code>setExtendedData</code>
-      <code>setLastModified</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Service/FullTextSearchService.php">
-    <UndefinedClass occurrences="2">
-      <code>DocumentAccess</code>
-      <code>IndexDocument</code>
-    </UndefinedClass>
-    <UndefinedMagicMethod occurrences="4">
-      <code>getDescription</code>
-      <code>getDescription</code>
-      <code>getTitle</code>
-      <code>getTitle</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Service/LabelService.php">
-    <UndefinedMagicMethod occurrences="4">
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>setBoardId</code>
-      <code>setColor</code>
-      <code>setColor</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-    </UndefinedMagicMethod>
-  </file>
-  <file src="lib/Service/OverviewService.php">
-    <UndefinedMagicMethod occurrences="4">
-      <code>setAssignedUsers</code>
-      <code>setAttachmentCount</code>
-      <code>setCommentsUnread</code>
-      <code>setLabels</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Service/PermissionService.php">
-    <UndefinedClass occurrences="2">
+    <UndefinedClass occurrences="3">
+      <code>Member</code>
       <code>\OCA\Circles\Api\v1\Circles</code>
       <code>\OCA\Circles\Api\v1\Circles</code>
     </UndefinedClass>
-    <UndefinedMagicMethod occurrences="6">
-      <code>getAcl</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getParticipant</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-      <code>getType</code>
-    </UndefinedMagicMethod>
   </file>
   <file src="lib/Service/StackService.php">
-    <InvalidArgument occurrences="3">
-      <code>'\OCA\Deck\Stack::onCreate'</code>
-      <code>'\OCA\Deck\Stack::onDelete'</code>
-      <code>'\OCA\Deck\Stack::onUpdate'</code>
-    </InvalidArgument>
     <UndefinedClass occurrences="1">
       <code>BadRquestException</code>
     </UndefinedClass>
-    <UndefinedMagicMethod occurrences="14">
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getBoardId</code>
-      <code>getOrder</code>
-      <code>setBoardId</code>
-      <code>setBoardId</code>
-      <code>setCards</code>
-      <code>setDeletedAt</code>
-      <code>setDeletedAt</code>
-      <code>setOrder</code>
-      <code>setOrder</code>
-      <code>setTitle</code>
-      <code>setTitle</code>
-    </UndefinedMagicMethod>
   </file>
 </files>

tests/unit/Db/AclMapperTest.php

@@ -24,6 +24,7 @@
 namespace OCA\Deck\Db;
 
 use OCP\IGroupManager;
+use OCP\ILogger;
 use OCP\IUserManager;
 use Test\AppFramework\Db\MapperTestUtility;
 
@@ -54,7 +55,8 @@ class AclMapperTest extends MapperTestUtility {
 			$this->aclMapper,
 			\OC::$server->query(StackMapper::class),
 			$this->userManager,
-			$this->groupManager
+			$this->groupManager,
+			$this->createMock(ILogger::class)
 		);
 
 		$this->boards = [

tests/unit/Db/BoardMapperTest.php

@@ -25,6 +25,7 @@ namespace OCA\Deck\Db;
 
 use OCP\IDBConnection;
 use OCP\IGroupManager;
+use OCP\ILogger;
 use OCP\IUserManager;
 use Test\AppFramework\Db\MapperTestUtility;
 
@@ -61,7 +62,8 @@ class BoardMapperTest extends MapperTestUtility {
 			\OC::$server->query(AclMapper::class),
 			\OC::$server->query(StackMapper::class),
 			$this->userManager,
-			$this->groupManager
+			$this->groupManager,
+			$this->createMock(ILogger::class)
 		);
 		$this->aclMapper = \OC::$server->query(AclMapper::class);
 		$this->labelMapper = \OC::$server->query(LabelMapper::class);

tests/unit/Notification/NotificationHelperTest.php

@@ -130,7 +130,8 @@ class NotificationHelperTest extends \Test\TestCase {
 		$card = Card::fromParams([
 			'notified' => false,
 			'id' => 123,
-			'title' => 'MyCardTitle'
+			'title' => 'MyCardTitle',
+			'duedate' => '2020-12-24'
 		]);
 		$this->cardMapper->expects($this->once())
 			->method('findBoardId')
@@ -225,7 +226,8 @@ class NotificationHelperTest extends \Test\TestCase {
 		$card = Card::fromParams([
 			'notified' => false,
 			'id' => 123,
-			'title' => 'MyCardTitle'
+			'title' => 'MyCardTitle',
+			'duedate' => '2020-12-24'
 		]);
 		$card->setAssignedUsers([
 			new User($users[0])
@@ -323,7 +325,8 @@ class NotificationHelperTest extends \Test\TestCase {
 		$card = Card::fromParams([
 			'notified' => false,
 			'id' => 123,
-			'title' => 'MyCardTitle'
+			'title' => 'MyCardTitle',
+			'duedate' => '2020-12-24'
 		]);
 		$card->setAssignedUsers([
 			new User($users[0])
@@ -470,7 +473,7 @@ class NotificationHelperTest extends \Test\TestCase {
 			->with(123)
 			->willReturn($board);
 		$user = $this->createMock(IUser::class);
-		$user->expects($this->once())
+		$user->expects($this->any())
 			->method('getUID')
 			->willReturn('userA');
 		$group = $this->createMock(IGroup::class);

tests/unit/Service/FileServiceTest.php

@@ -25,10 +25,10 @@ namespace OCA\Deck\Service;
 
 use OCA\Deck\Db\Attachment;
 use OCA\Deck\Db\AttachmentMapper;
-use OCP\AppFramework\Http\ContentSecurityPolicy;
 use OCP\AppFramework\Http\StreamResponse;
 use OCP\Files\Folder;
 use OCP\Files\IAppData;
+use OCP\Files\IMimeTypeDetector;
 use OCP\Files\IRootFolder;
 use OCP\Files\SimpleFS\ISimpleFile;
 use OCP\Files\SimpleFS\ISimpleFolder;
@@ -57,6 +57,8 @@ class FileServiceTest extends TestCase {
 	private $config;
 	/** @var AttachmentMapper|MockObject */
 	private $attachmentMapper;
+	/** @var IMimeTypeDetector|MockObject */
+	private $mimeTypeDetector;
 
 	public function setUp(): void {
 		parent::setUp();
@@ -67,7 +69,8 @@ class FileServiceTest extends TestCase {
 		$this->rootFolder = $this->createMock(IRootFolder::class);
 		$this->config = $this->createMock(IConfig::class);
 		$this->attachmentMapper = $this->createMock(AttachmentMapper::class);
-		$this->fileService = new FileService($this->l10n, $this->appData, $this->request, $this->logger, $this->rootFolder, $this->config, $this->attachmentMapper);
+		$this->mimeTypeDetector = $this->createMock(IMimeTypeDetector::class);
+		$this->fileService = new FileService($this->l10n, $this->appData, $this->request, $this->logger, $this->rootFolder, $this->config, $this->attachmentMapper, $this->mimeTypeDetector);
 	}
 
 	public function mockGetFolder($cardId) {
@@ -268,51 +271,13 @@ class FileServiceTest extends TestCase {
 		$file->expects($this->any())
 			->method('fopen')
 			->willReturn('fileresource');
+		$this->mimeTypeDetector->expects($this->once())
+			->method('getSecureMimeType')
+			->willReturn('image/jpeg');
 		$actual = $this->fileService->display($attachment);
 		$expected = new StreamResponse('fileresource');
 		$expected->addHeader('Content-Type', 'image/jpeg');
-		$expected->addHeader('Content-Disposition', 'inline; filename="' . rawurldecode($file->getName()) . '"');
+		$expected->addHeader('Content-Disposition', 'attachment; filename="' . rawurldecode($file->getName()) . '"');
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedObjectDomain('\'self\'');
-		$policy->addAllowedObjectDomain('blob:');
-		$policy->addAllowedMediaDomain('\'self\'');
-		$policy->addAllowedMediaDomain('blob:');
-		$expected->setContentSecurityPolicy($policy);
-		$this->assertEquals($expected, $actual);
-	}
-
-	public function testDisplayPdf() {
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->willReturn('123');
-		$appDataFolder = $this->createMock(Folder::class);
-		$deckAppDataFolder = $this->createMock(Folder::class);
-		$cardFolder = $this->createMock(Folder::class);
-		$this->rootFolder->expects($this->once())->method('get')->willReturn($appDataFolder);
-		$appDataFolder->expects($this->once())->method('get')->willReturn($deckAppDataFolder);
-		$deckAppDataFolder->expects($this->once())->method('get')->willReturn($cardFolder);
-		$attachment = $this->getAttachment();
-		$file = $this->createMock(\OCP\Files\File::class);
-		$cardFolder->expects($this->once())->method('get')->willReturn($file);
-		$file->expects($this->any())
-			->method('getMimeType')
-			->willReturn('application/pdf');
-		$file->expects($this->any())
-			->method('getName')
-			->willReturn('file1');
-		$file->expects($this->any())
-			->method('fopen')
-			->willReturn('fileresource');
-		$actual = $this->fileService->display($attachment);
-		$expected = new StreamResponse('fileresource');
-		$expected->addHeader('Content-Disposition', 'inline; filename="' . rawurldecode($file->getName()) . '"');
-		$expected->addHeader('Content-Type', 'application/pdf');
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedObjectDomain('\'self\'');
-		$policy->addAllowedObjectDomain('blob:');
-		$policy->addAllowedMediaDomain('\'self\'');
-		$policy->addAllowedMediaDomain('blob:');
-		$expected->setContentSecurityPolicy($policy);
 		$this->assertEquals($expected, $actual);
 	}