perf: Use getBoard to get the board

So that this can benefit from a local cache

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>

lib/Db/SessionMapper.php

@@ -45,8 +45,7 @@ class SessionMapper extends QBMapper {
 		$qb->select('id', 'board_id', 'last_contact', 'user_id', 'token')
 			->from($this->getTableName())
 			->where($qb->expr()->eq('board_id', $qb->createNamedParameter($boardId)))
-			->andWhere($qb->expr()->gt('last_contact', $qb->createNamedParameter(time() - SessionService::SESSION_VALID_TIME)))
+			->andWhere($qb->expr()->gt('last_contact', $qb->createNamedParameter(time() - SessionService::SESSION_VALID_TIME)));
-			->executeQuery();
 
 		return $this->findEntities($qb);
 	}

lib/Service/BoardService.php

@@ -621,7 +621,9 @@ class BoardService {
 
 			if ($fullDetails) {
 				$this->enrichWithStacks($board);
+				if ($board->getLabels() === null) {
 					$this->enrichWithLabels($board);
+				}
 				$this->enrichWithUsers($board);
 				$this->enrichWithBoardSettings($board);
 				$this->enrichWithActiveSessions($board);

lib/Service/PermissionService.php

@@ -214,7 +214,7 @@ class PermissionService {
 		}
 
 		try {
-			$board = $this->boardMapper->find($boardId);
+			$board = $this->getBoard($boardId);
 		} catch (DoesNotExistException $e) {
 			return [];
 		} catch (MultipleObjectsReturnedException $e) {
@@ -227,7 +227,7 @@ class PermissionService {
 		} else {
 			$users[$board->getOwner()] = new User($board->getOwner(), $this->userManager);
 		}
-		$acls = $this->aclMapper->findAll($boardId);
+		$acls = $board->getAcl();
 		/** @var Acl $acl */
 		foreach ($acls as $acl) {
 			if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {

tests/unit/Service/PermissionServiceTest.php

@@ -347,9 +347,8 @@ class PermissionServiceTest extends \Test\TestCase {
 			->method('__call')
 			->with('getOwner', [])
 			->willReturn('user1');
-		$this->aclMapper->expects($this->once())
+		$board->expects($this->any())
-			->method('findAll')
+			->method('getAcl')
-			->with(123)
 			->willReturn([$aclUser, $aclGroup]);
 		$this->boardMapper->expects($this->once())
 			->method('find')