Commit Graph

388 Commits

Author SHA1 Message Date
Max
cfa9c4d1c4 fix: crash when leaving out system parameter
The `--system` parameter can be supplied via command line
or selected afterwards.

However if none was provided the command would crash with
`TypeError: Cannot assign null to property $system`.

Handle that gracefully and make the type spec more precise
for the setSystem function.

Signed-off-by: Max <max@nextcloud.com>
2023-06-15 12:53:14 +02:00
Max
0419ebc856 Fix(occ): set user id for permission sevice from board service
Fixes #4010.

Signed-off-by: Max <max@nextcloud.com>
2023-06-14 11:12:58 +02:00
Julius Härtl
0985f24f57 chore: Fix php-cs-fixer errors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-05 22:26:08 +02:00
Julius Härtl
0b2ea0f839 fix: Centralize usage of CardDetails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-03 15:35:51 +02:00
Julius Härtl
62752f8b72 fix: Use passed userid when getting attachment folder
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 22:56:28 +01:00
Julius Härtl
1beff8945b fix: Pass user id along to properly check permissions in background jobs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 11:25:45 +01:00
chandi Langecker
41d8867bdd live updates: listen for stack and board changes
Signed-off-by: chandi Langecker <git@chandi.it>
2023-02-21 21:53:22 +01:00
chandi Langecker
322ee92573 live updates for boards
Signed-off-by: chandi Langecker <git@chandi.it>
2023-02-21 21:53:20 +01:00
Julius Härtl
46df19a3a6 fix: Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:28 +01:00
Julius Härtl
b19b7794bc perf: Cache full/partial board data differently
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
29d21e05e8 chore: Remove some unused methods
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
afcd226be8 refactor: Unify board enrichment
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
4b319d8d23 perf: Avoid extra round trips when checking permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
8ec8a91cab perf: Group queries for fetching overview cards
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
c01e542044 perf: remove duplicate fetching of assignments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
af21282468 style: php-cs-fixer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:26 +01:00
Julius Härtl
81c0d96357 perf: Make fetching user details lazy
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:26 +01:00
Julius Härtl
ea8b7999f7 perf: No need to fetch boards every middleware call
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:26 +01:00
Julius Härtl
7bfbbee6e8 perf: Enrich calls in combined sql queries
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:26 +01:00
Raul
7575bd0bf7 Fix due status calculation
Signed-off-by: Raul <raul@nextcloud.com>
2023-02-15 13:18:11 +01:00
Raul
6ae61368a7 Update Card serialization (jsonSerialize usages) to use CardDetails model
Signed-off-by: Raul <raul@nextcloud.com>
2023-02-15 13:18:11 +01:00
Julien Veyssier
bbd6f0c26c use deck icon for boards, MDI-card for cards and MDI-comment for comments
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-02-08 14:02:06 +01:00
Julien Veyssier
9658ccd843 refactor CommentService a bit, add BoardReferenceProvider and CommentReferenceProvider (no widgets but resolving)
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-02-08 14:02:05 +01:00
chandi Langecker
541ee13780 sessions: ignore self-emitted update events
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:45:11 +01:00
chandi Langecker
0ea384d1e5 session cleanup via background job
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:45:11 +01:00
chandi
54b390010c Update lib/Service/SessionService.php
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
a674b5b5b2 fix php7 syntax error (unexpected '|')
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
cd7fb9a4bd increase session timeout
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
6bfb54e2b3 use strict types in new php classes
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
7dc64de2de dedicated Listener class, constants for events
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
fd6e15b58c ensure activeSessions is an array
sometimes the resulting json contained an object leading to JS errors

Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:59 +01:00
chandi Langecker
fcfbcc63b4 basic notify_push usage with session handling (rebased)
Signed-off-by: chandi Langecker <git@chandi.it>
2023-01-03 12:43:56 +01:00
Marcel Klehr
00b95fe6ce Fix psalm errors
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-12-30 12:56:06 +01:00
David Loe
e256cf23ce Fix Errors
Signed-off-by: David Loe <d.loewens24@gmail.com>
2022-12-30 12:56:06 +01:00
David Loe
88a9fe2161 Export Board
Signed-off-by: David Loe <d.loewens24@gmail.com>
2022-12-30 12:56:06 +01:00
Julius Härtl
ed282479a1 Fix validation of attachment data
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 20:39:20 +01:00
Julius Härtl
805f185191 Merge pull request #4173 from nextcloud/bugfix/noid/card-sanity-check 2022-10-31 21:17:31 +01:00
Julius Härtl
a231061043 Merge pull request #4059 from nextcloud/feature/improve-security-level 2022-10-31 12:59:12 +01:00
Julius Härtl
1f66c66ad3 Unify getting the share for attachments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-31 12:48:51 +01:00
Adrian Missy
f7717aa02a feat: #2906 add card ID badge
- adds vscode settings file to gitingore
- adds new badge for card ID
- adds card ID to board filter
- adds settings to disable card ID badge

Signed-off-by: Adrian Missy <adrian.missy@onewavestudios.com>
2022-10-29 10:25:28 +02:00
Luka Trovic
1217b37b19 feat: add validators to check values in services
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2022-10-21 18:08:19 +02:00
Julius Härtl
d00bd159d2 Avoid always setting the current time on card updates
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-19 20:03:22 +02:00
Joas Schilling
2c3113334a Fix issue with duedate format
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-19 19:46:09 +02:00
Julius Härtl
c81501c2ea Cache user membership for circles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-10-14 23:11:19 +02:00
Joas Schilling
982df96c3c Fix sorting stacks
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-13 14:07:59 +02:00
raul
24a4260e55 Fix deleteAcl
Signed-off-by: raul <raul@nextcloud.com>
2022-09-22 08:46:35 +02:00
Julien Veyssier
cb60e70ae9 refs #4035 fix attachment creator name: show display name instead of user id
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-09-07 16:53:51 +02:00
Julius Härtl
e2c5367050 Avoid duplicate code
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-28 20:51:22 +02:00
Julius Härtl
7c40172c40 Use capped memory cache for board permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-16 16:06:40 +02:00
Julius Härtl
e639456a82 Fetch attachment folder for the correct user during cron job
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-05 13:20:41 +02:00