Ryan Fletcher
4391bf4eb8
added missing BadRequestException checks to StackService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
aba7d02cfe
Added BadRequestException checks in DefaultBoardService. Fixed bug in DefaultBoardService BadRequestException checks.
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
6f5c0a2816
Added in BadRequestException checks in CardService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
e8571454d9
Added BadRequestException checks into BoardService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
7930fec5d7
Added in BadRequestException tests into AttachmentService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
37a2858d5f
wrote attachment api controller, fixed bug caught by unit test in CardService
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:22 +02:00
Ryan Fletcher
172a80fa5d
Added additional endpoints for cards / stacks
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:21 +02:00
Ryan Fletcher
3e965d0cfb
Implemented additional CardApiController endpoints
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:21 +02:00
Ryan Fletcher
72aeb723a5
fixed up missing checks from labelService, BadRequestException is now extending StatusException
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:21 +02:00
Ryan Fletcher
5bc8a363b9
Split Card Update in CardApiController as it was gigantic and broke codacy complexity rules by a lot. Also moved validation checks into respective services.
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:20 +02:00
Ryan Fletcher
f2268c7f58
Moved Data Response checks into stack serivice, cleaned up related unit tests.
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:20 +02:00
Ryan Fletcher
d33dd3e0fc
Moved BadRequestException checks to middleware, removed uneeded unit tests in BoardApiController
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:20 +02:00
Ryan Fletcher
891fa7b7d5
Created index tests for StackApiTestController
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:19 +02:00
Julius Härtl
dcfb9f3903
Properly annotate exceptions thrown by services
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-15 21:15:19 +02:00
Ryan Fletcher
cfd9ab98c6
Implemented StackApiController Get Function.
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:17 +02:00
Ryan Fletcher
dd1d4246fe
Finished Error handling across the API
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:17 +02:00
Ryan Fletcher
2668f6b80c
committing WIP (improving error validation across the api's)
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-08-15 21:15:17 +02:00
Julius Härtl
9fc01eb51f
Move DI of IUserManager, IGroupManager, userId to the BoardService
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-15 21:15:12 +02:00
Steven R. Baker
e32adb17f2
Don't need to pass around the userInfo with it encapsulated in BoardService.
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-15 21:15:12 +02:00
Steven R. Baker
1ffa3211ba
Extract getBoardPererequisites() so it can be re-used.
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-08-15 21:15:11 +02:00
Manuel Arno Korfmann
94e1b86eaf
fixed bugs where labels would dissappear
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:31 +02:00
Manuel Arno Korfmann
5ddfb66633
Card,Stack undo delete: CardServiceTest fix
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Stack,Card undo delete: Test Fix 2
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Card, Stack undo delete: Test fix 3
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Card,Stack undo delete: Test fix 4
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Stack, Card undo delete: Relative time in deleted entity listings
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Card, Stack undo delete: Test Fix 5
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Test Fix 6
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
Test Fix 7
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
fix codacy
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:31 +02:00
Manuel Arno Korfmann
41d30d4fd4
stack, card undo delete: refactoring
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
stack undo delete: serve cards with deleted and delete actions
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
stack, cards undo delete: codacy
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
card undo delete: 526#discussion_r204501758, refactoring
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
card, stack undo delete: code review fixes #1
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
undo card, stack delete: show deleted stacks name in deleted card listing
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:31 +02:00
Manuel Arno Korfmann
ef4ce31c47
refactoring and stack undo delete early wip
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
stack soft delete done
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
stack undo delete done
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
stack undo: code review remarks and fixes
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:30 +02:00
Manuel Arno Korfmann
f2795f120b
show deleted cards in sidebar tab (styling still wip)
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
card undo delete done, styling still wip
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
fix Codacy findings
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:30 +02:00
Manuel Arno Korfmann
2ef4b55af4
cards soft delete wip
...
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
cards: softdelete done; undo delete wip
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
show deleted cards in board settings sidebar wip
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
CardMapper#findDeleted: fix bug in entity property assigning
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info >
2018-08-15 20:33:30 +02:00
steav
9595e00ae1
Do not send card assignment notifications to ourselves
...
Signed-off-by: steav <steav8@gmail.com >
2018-07-28 12:17:28 +02:00
Steav
77472b978d
Add notification on card assignment to user
...
Signed-off-by: Steav <steav8@gmail.com >
2018-07-28 12:16:50 +02:00
Julius Härtl
09105d6e3d
Check when assigning users
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-25 18:39:08 +02:00
Ryan Fletcher
8d4dbd4d82
Fixed up code styles as per review by juliushaertl
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-12 11:17:11 -04:00
Ryan Fletcher
ba378ea00b
First attempt at using l10n
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-11 15:00:08 -04:00
Ryan Fletcher
61fb68f4cf
Added a unit test against DefaultBoardService->TestCreateDefaultBoard()
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-11 10:20:42 -04:00
Ryan Fletcher
8a8cffc542
Completed checkFirstRun() in DefaultBoardService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-11 08:02:54 -04:00
Ryan Fletcher
a36dfcc144
first attempt at writing the checkFirstRun() in DefaultBoardService.php
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-10 21:16:24 -04:00
Ryan Fletcher
683354da9d
corrected null errors from first attempt.
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-10 19:30:47 -04:00
Ryan Fletcher
e208fd8222
First Attempt at implementing createDefaultBoard()
...
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca >
2018-07-10 17:10:27 -04:00
Julius Härtl
cb25643741
Fetch file from rootFolder instead of IAppData to use StreamResponse when displaying
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-07-05 18:42:33 +02:00
Julius Härtl
014f76b2fb
Provide resource of tmp file instead of putting all content in memory
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-25 17:55:40 +02:00
Julius Härtl
546928fb79
Throw proper StatusException
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-25 17:55:18 +02:00
Julius Härtl
c2c0bae3d6
Fix scrutinizer issues
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 19:40:12 +02:00
Julius Härtl
7955a19149
Add some logging
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:06 +02:00
Julius Härtl
a83b50bb97
return empty result
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:06 +02:00
Julius Härtl
0f50f8d1d9
Use generic Exception
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:06 +02:00
Julius Härtl
7ad8080f82
Add unit tests for new classes
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:06 +02:00
Julius Härtl
5bc65a6eb3
Use object-src self/blob for pdf files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:05 +02:00
Julius Härtl
581fa011e3
Implement updating files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:05 +02:00
Julius Härtl
7b230d567e
Add field for user count
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:04 +02:00
Julius Härtl
0137b882c5
Add attachment indicator
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:04 +02:00
Julius Härtl
ee5a54a575
Allow to undo file deletions
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 18:00:04 +02:00
Julius Härtl
45c7241daf
Implement attachment backend with a first module for app data file upload
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-19 17:59:00 +02:00