Julius Härtl
|
4441075f49
|
Add tests for param parsing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-07 12:53:58 +02:00 |
|
Julius Härtl
|
56f9b5b6e6
|
Code cleanup
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-07 08:51:52 +02:00 |
|
Julius Härtl
|
f686b1e75b
|
Activity: trigger activity on board share/unshare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 21:09:21 +02:00 |
|
Julius Härtl
|
7e88d246c0
|
Tests: Add tests for ActivityManager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 20:01:26 +02:00 |
|
Julius Härtl
|
80aadb2717
|
Tests: More coverage for DeckProvider->parse()
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 15:05:35 +02:00 |
|
Julius Härtl
|
0cc4fffd08
|
Add tests for activity classes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 13:19:54 +02:00 |
|
Julius Härtl
|
e06a5ad44f
|
Use proper trigger methods for activities
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:03 +02:00 |
|
Julius Härtl
|
2d545aafa5
|
Fix service update methods
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:02 +02:00 |
|
Julius Härtl
|
18f92f7b54
|
Implement remaining activity types
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:01 +02:00 |
|
Julius Härtl
|
b5cf3709c2
|
Emit activity events in StackService
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:01 +02:00 |
|
Julius Härtl
|
df8c1984ca
|
Emit activity events in CardService
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:01 +02:00 |
|
Julius Härtl
|
c32ab5648c
|
Emit activity events in BoardService
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:01 +02:00 |
|
Julius Härtl
|
6a5b4fe40c
|
WIP: Activity integration
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-09-06 10:05:01 +02:00 |
|
Julius Härtl
|
5639bd1274
|
Fix controller deleted at parameter
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:23 +02:00 |
|
Julius Härtl
|
babfcbddd8
|
Fix imports
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:23 +02:00 |
|
Julius Härtl
|
0c9b1f5338
|
Mapper can be null if provided id is a board id
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:23 +02:00 |
|
Julius Härtl
|
81d333243d
|
Fix comparison
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:23 +02:00 |
|
Julius Härtl
|
47a7e76a4d
|
Catch DoesNotExistException to return proper API repsonses
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:23 +02:00 |
|
Ryan Fletcher
|
4391bf4eb8
|
added missing BadRequestException checks to StackService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
aba7d02cfe
|
Added BadRequestException checks in DefaultBoardService. Fixed bug in DefaultBoardService BadRequestException checks.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
6f5c0a2816
|
Added in BadRequestException checks in CardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
e8571454d9
|
Added BadRequestException checks into BoardService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
7930fec5d7
|
Added in BadRequestException tests into AttachmentService.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
37a2858d5f
|
wrote attachment api controller, fixed bug caught by unit test in CardService
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:22 +02:00 |
|
Ryan Fletcher
|
e88c9a760d
|
Wrote unit tests for AttachmentApiController and stubbed out AttachmentApicontroller. Trying out test driven development.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
172a80fa5d
|
Added additional endpoints for cards / stacks
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
3e965d0cfb
|
Implemented additional CardApiController endpoints
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
72aeb723a5
|
fixed up missing checks from labelService, BadRequestException is now extending StatusException
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
507a7fd243
|
Code cleanup, removing unused code from older iteration.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
184cd00a8b
|
Wrote initial unit tests for LabelApiControllerTest.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:21 +02:00 |
|
Ryan Fletcher
|
9c81584b02
|
Wrote tests for CardApiControllerTest.php
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
Ryan Fletcher
|
5bc8a363b9
|
Split Card Update in CardApiController as it was gigantic and broke codacy complexity rules by a lot. Also moved validation checks into respective services.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
Ryan Fletcher
|
f2268c7f58
|
Moved Data Response checks into stack serivice, cleaned up related unit tests.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
Ryan Fletcher
|
d33dd3e0fc
|
Moved BadRequestException checks to middleware, removed uneeded unit tests in BoardApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
Ryan Fletcher
|
8cac183af6
|
simple code style changes according to codacy standards.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:20 +02:00 |
|
Ryan Fletcher
|
570ac81848
|
added the create tests in StackApiControllerTest
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
Ryan Fletcher
|
5719e9f134
|
Wrote unit tests against StackApiController -> get()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
Ryan Fletcher
|
891fa7b7d5
|
Created index tests for StackApiTestController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
Ryan Fletcher
|
54f110f7c6
|
first attempt at BoardApiControllerTest->testGetNoPermission()
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:19 +02:00 |
|
Julius Härtl
|
dcfb9f3903
|
Properly annotate exceptions thrown by services
Signed-off-by: Julius Härtl <jus@bitgrid.net>
|
2018-08-15 21:15:19 +02:00 |
|
Ryan Fletcher
|
6d57b1081a
|
BoardApiControllerTest wrote delete tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
Ryan Fletcher
|
8dd732631a
|
BoardApiController wrote update tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
Ryan Fletcher
|
1fe70568cb
|
Wrote unit tests for the BoardApiController -> create tests
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
Ryan Fletcher
|
bd254fd261
|
BoardApiControllerTest wrote get() tests.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:18 +02:00 |
|
Ryan Fletcher
|
cfd9ab98c6
|
Implemented StackApiController Get Function.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
Ryan Fletcher
|
dd1d4246fe
|
Finished Error handling across the API
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
Ryan Fletcher
|
2668f6b80c
|
committing WIP (improving error validation across the api's)
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:17 +02:00 |
|
Ryan Fletcher
|
a388d199dc
|
Refactored error handling in StackApiController and moved it into ApiHelper.php, this will allow me to use the same checks in all controllers.
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
Ryan Fletcher
|
d9f3d492dc
|
Better variable name for stackService in StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|
Ryan Fletcher
|
a14ca3d1f5
|
Better error handling in StackApiController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
|
2018-08-15 21:15:16 +02:00 |
|