Commit Graph

67 Commits

Author SHA1 Message Date
Carl Schwan
5cf486150a refactor: Fix psalm issues
- Add typing for most of the services, controllers and mappers
- Add api doc for mappers
- Use vendor-bin for psalm
- Use attributes for controllers
- Fix upload of attachments

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-28 11:49:06 +02:00
Julius Knorr
a35489bee3 fix: Catch not found card
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-01-03 14:48:00 +01:00
Luka Trovic
439c2b422e fix phpcs
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2024-09-26 17:12:53 +02:00
dependabot[bot]
ba3e97b73d Chore(deps-dev): Bump nextcloud/coding-standard from 1.2.1 to 1.2.3
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.2.1 to 1.2.3.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.2.1...v1.2.3)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-26 08:14:42 +02:00
Julius Härtl
d4ea088cd2 perf: Avoid fetching labels and owner details on permission check
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-25 17:01:30 +02:00
Julius Härtl
ec9e87d0cb chore: Clean up permission service
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-21 09:58:11 +02:00
Andy Scherzinger
be11113d32 chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-07 15:51:49 +02:00
Marcel Klehr
a45ede092a fix(PermissionService#getPermissions): Catch exceptions from getBoard method
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-02-02 11:50:17 +01:00
Julius Härtl
86d2d1a0f3 fix: limit to non-deleted cards
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-04 15:20:08 +01:00
Julius Härtl
178d1b3d77 fix: Consider a deleted board inaccessible to share recipients
Only the owner can delete/undo a board deletion so there is no reason
other users should have any permission on a board marked as deleted

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-04 15:20:08 +01:00
Julius Härtl
a05d64250f fix: Only query boards not marked for deletion unless we want to undo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-20 08:22:45 +01:00
Julius Härtl
0985f24f57 chore: Fix php-cs-fixer errors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-05 22:26:08 +02:00
Julius Härtl
1beff8945b fix: Pass user id along to properly check permissions in background jobs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 11:25:45 +01:00
Julius Härtl
4b319d8d23 perf: Avoid extra round trips when checking permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:27 +01:00
Julius Härtl
81c0d96357 perf: Make fetching user details lazy
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 09:16:26 +01:00
Julius Härtl
7c40172c40 Use capped memory cache for board permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-16 16:06:40 +02:00
Bink
04f8292b8a Fix: Check all circle shares for permissions instead of returning after the first 2022-04-11 15:49:14 +02:00
Julius Härtl
23f0b16a5a Handle board exceptions more gracefully
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-22 08:23:30 +01:00
Julius Härtl
72134e6e95 fix: unit tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-22 08:23:28 +01:00
Julius Härtl
eaf6defe59 Move any circles API usage to internal service
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-01-03 10:23:47 +01:00
Julius Härtl
901b8f2506 Avoid fetching board details multiple times
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-11-24 09:40:30 +01:00
Julius Härtl
cb9fc6c9a2 Check for null value to avoid TypeError in the group manager
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-03 09:47:27 +02:00
Julius Härtl
82dbd800d6 Move circle checks to a unified service and improve member checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-03 09:15:18 +02:00
Julius Härtl
ae2aa8caff Reduce duplicate queries when fetching user boards an permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-07-05 19:53:43 +02:00
Julius Härtl
3e032b133d Add compatibility for circles on 22
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-25 11:23:38 +02:00
Julius Härtl
79468e6f06 Use board permissions to be applied for the shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-04 22:26:04 +01:00
Julius Härtl
4e92faa517 Do not error on deprecated methods for now
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-28 14:48:52 +01:00
Julius Härtl
6114c28b10 Remove unneeded cardId parameters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-11 12:21:37 +02:00
Julius Härtl
52febb396c Fix php cs issues
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-22 19:57:19 +02:00
Julius Härtl
1f724fb612 Fix undefined users variable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-04 16:44:11 +01:00
Julius Härtl
61e4d807b7 Merge remote-tracking branch 'origin/vue' into master-merge-vue 2020-01-25 10:42:05 +01:00
Julius Härtl
e5edd96b74 Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-08 21:50:17 +01:00
Jakob
7628eb425c little changes
Signed-off-by: Jakob <jakob.roehrl@web.de>
2019-10-16 10:09:25 +02:00
Jakob
e0808273ec get circle users
Signed-off-by: Jakob <jakob.roehrl@web.de>
2019-10-15 13:56:12 +02:00
Jakob
84dc4ce1dd circles
Signed-off-by: Jakob <jakob.roehrl@web.de>
2019-10-15 11:39:15 +02:00
Jakob
e7fcef3e3a circle sharing
Signed-off-by: Jakob <jakob.roehrl@web.de>
2019-10-15 08:30:25 +02:00
Julius Härtl
29f6ae477b Make circles/collections depending on available version
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-28 18:46:37 +01:00
Julius Härtl
8615fe1a40 Merge pull request #923 from nextcloud/feature/126/circles
Share with circles
2019-03-28 16:48:05 +01:00
Julius Härtl
ed38e70989 Properly fetch infromation for personal circles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-27 18:15:11 +01:00
Julius Härtl
ed3991b7bd Share with circles
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-27 18:10:43 +01:00
Julius Härtl
e2be00a18d Implement collections integration
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-25 14:51:42 +01:00
Julius Härtl
b8d00c8228 Make sure only groups can create if set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-07 08:27:29 +01:00
Julius Härtl
0528bd59d1 Fix tests for group restrictions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-04 09:25:35 +01:00
Julius Härtl
7c95783ab5 Add group limit for creating boards
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-04 09:11:50 +01:00
Julius Härtl
bff3cafb37 Check if sharing is disabled for a user via core settings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-12-04 07:51:47 +01:00
Ryan Fletcher
891fa7b7d5 Created index tests for StackApiTestController
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
2018-08-15 21:15:19 +02:00
Julius Härtl
dcfb9f3903 Properly annotate exceptions thrown by services
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-08-15 21:15:19 +02:00
Scrutinizer Auto-Fixer
b633d82c5e Scrutinizer Auto-Fixes
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
2018-05-12 11:10:23 +00:00
Julius Härtl
dc917b1e5d Fix inspection issues
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-10-23 22:12:08 +02:00
Julius Härtl
c45bb71084 Fix phpstorm inspection issues
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2017-10-17 01:17:37 +02:00