ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix tests that invoke findUsers

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2017-10-10 19:23:01 +02:00
committed by Julius Härtl
parent a56ceb348d
commit ff2d96a1fb
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Service/BoardService.php
View File

@@ -103,7 +103,8 @@ class BoardService {
'PERMISSION_MANAGE' => $permissions[Acl::PERMISSION_MANAGE], 'PERMISSION_MANAGE' => $permissions[Acl::PERMISSION_MANAGE],
'PERMISSION_SHARE' => $permissions[Acl::PERMISSION_SHARE] 'PERMISSION_SHARE' => $permissions[Acl::PERMISSION_SHARE]
]); ]);
$board->setUsers(array_values($this->permissionService->findUsers($boardId))); $boardUsers = $this->permissionService->findUsers($boardId);
$board->setUsers(array_values($boardUsers));
return $board; return $board;
} }

1
tests/unit/Db/CardTest.php
View File

@@ -97,6 +97,7 @@ class CardTest extends \PHPUnit_Framework_TestCase {
'duedate' => null, 'duedate' => null,
'overdue' => 0, 'overdue' => 0,
'archived' => false, 'archived' => false,
'assignedUsers' => null,
], $card->jsonSerialize()); ], $card->jsonSerialize());
} }

15
tests/unit/Service/BoardServiceTest.php
View File

@@ -105,6 +105,11 @@ class BoardServiceTest extends TestCase {
->method('find') ->method('find')
->with(1) ->with(1)
->willReturn($b1); ->willReturn($b1);
$this->permissionService->expects($this->once())
->method('findUsers')
->willReturn([
'admin' => 'admin',
]);
$this->assertEquals($b1, $this->service->find(1)); $this->assertEquals($b1, $this->service->find(1));
} }
@@ -137,6 +142,11 @@ class BoardServiceTest extends TestCase {
->method('update') ->method('update')
->with($board) ->with($board)
->willReturn($board); ->willReturn($board);
$this->permissionService->expects($this->once())
->method('findUsers')
->willReturn([
'admin' => 'admin',
]);
$b = $this->service->update(123, 'MyNewNameBoard', 'ffffff', false); $b = $this->service->update(123, 'MyNewNameBoard', 'ffffff', false);
$this->assertEquals($b->getTitle(), 'MyNewNameBoard'); $this->assertEquals($b->getTitle(), 'MyNewNameBoard');
@@ -151,6 +161,11 @@ class BoardServiceTest extends TestCase {
$this->boardMapper->expects($this->once()) $this->boardMapper->expects($this->once())
->method('find') ->method('find')
->willReturn($board); ->willReturn($board);
$this->permissionService->expects($this->once())
->method('findUsers')
->willReturn([
'admin' => 'admin',
]);
$this->assertEquals($board, $this->service->delete(123)); $this->assertEquals($board, $this->service->delete(123));
} }