From 329df8e856951ef6684fffad2e58b6e7e5253974 Mon Sep 17 00:00:00 2001
From: Jakob <jakob.roehrl@web.de>
Date: Wed, 28 Aug 2019 11:01:36 +0200
Subject: [PATCH 1/3] card and stack names required, clear card field after
 creation

Signed-off-by: Jakob <jakob.roehrl@web.de>
---
 src/components/Controls.vue    | 13 +++++++++++--
 src/components/board/Stack.vue | 17 +++++++++++++++--
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index 1052577a8..6ad02ef50 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -42,9 +42,10 @@
 					<label for="new-stack-input-main" class="hidden-visually">Add a new stack</label>
 					<input id="new-stack-input-main" v-model="newStackTitle" type="text"
 						class="no-close"
-						placeholder="Add a new stack">
+						placeholder="Add a new stack" required>
 					<input v-tooltip="t('deck', 'clickAddNewStack')" class="icon-confirm" type="submit"
 						value="">
+
 				</form>
 			</div>
 			<div class="board-action-buttons">
@@ -75,7 +76,8 @@ export default {
 		return {
 			newStackTitle: '',
 			stack: '',
-			showArchived: false
+			showArchived: false,
+			missingStackName: t('deck', 'stack title must be provided')
 		}
 	},
 	computed: {
@@ -88,6 +90,13 @@ export default {
 				return 'opacity: 1.0'
 			}
 			return 'opacity: 0.3'
+		},
+		addNewStackValidation() {
+			if (this.newStackTitle === '') {
+				return false
+			}
+
+			return true
 		}
 	},
 	methods: {
diff --git a/src/components/board/Stack.vue b/src/components/board/Stack.vue
index d4ea85050..824a1e183 100644
--- a/src/components/board/Stack.vue
+++ b/src/components/board/Stack.vue
@@ -49,7 +49,11 @@
 			<input id="new-stack-input-main" v-model="newCardTitle" type="text"
 				class="no-close"
 				placeholder="Add a new card">
-			<input v-tooltip="t('deck', 'Create a new card')" class="icon-confirm" type="submit"
+
+			<input v-tooltip="{content: missingCardName, show: !addNewCardValidation, trigger: 'manual' }"
+				:disabled="!addNewCardValidation"
+				class="icon-confirm"
+				type="submit"
 				value="">
 		</form>
 
@@ -83,12 +87,20 @@ export default {
 		return {
 			editing: false,
 			copiedStack: '',
-			newCardTitle: ''
+			newCardTitle: '',
+			missingCardName: t('deck', 'card title must be provided')
 		}
 	},
 	computed: {
 		cardsByStack() {
 			return (id) => this.$store.getters.cardsByStack(id)
+		},
+		addNewCardValidation() {
+			if (this.newCardTitle === '') {
+				return false
+			}
+
+			return true
 		}
 	},
 
@@ -121,6 +133,7 @@ export default {
 				boardId: this.stack.boardId
 			}
 			this.$store.dispatch('addCard', newCard)
+			this.newCardTitle = ''
 		}
 	}
 }

From 1c040d35be89905de178071a3438c4dbc9adc349 Mon Sep 17 00:00:00 2001
From: Jakob <jakob.roehrl@web.de>
Date: Wed, 28 Aug 2019 11:17:31 +0200
Subject: [PATCH 2/3] edit not possible in archive mode

Signed-off-by: Jakob <jakob.roehrl@web.de>
---
 src/components/cards/CardItem.vue | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/components/cards/CardItem.vue b/src/components/cards/CardItem.vue
index 653d8d967..9b58d19e8 100644
--- a/src/components/cards/CardItem.vue
+++ b/src/components/cards/CardItem.vue
@@ -24,7 +24,8 @@
 	<div :class="{'compact': compactMode}" tag="div" class="card"
 		@click.self="openCard">
 		<div class="card-upper">
-			<h3 @click.stop="startEditing(card)">{{ card.title }}</h3>
+			<h3 v-if="showArchived">{{ card.title }}</h3>
+			<h3 v-else @click.stop="startEditing(card)">{{ card.title }}</h3>
 			<transition name="fade" mode="out-in">
 				<form v-if="editing">
 					<input v-model="copiedCard.title" type="text" autofocus>
@@ -32,9 +33,9 @@
 				</form>
 
 				<Actions @click.stop.prevent>
-					<ActionButton icon="icon-user" @click="assignCardToMe()">{{ t('deck', 'Assign to me') }}</ActionButton>
+					<ActionButton v-if="showArchived === false" icon="icon-user" @click="assignCardToMe()">{{ t('deck', 'Assign to me') }}</ActionButton>
 					<ActionButton icon="icon-archive" @click="archiveUnarchiveCard()">{{ t('deck', (showArchived ? 'Unarchive card' : 'Archive card')) }}</ActionButton>
-					<ActionButton icon="icon-delete" @click="deleteCard()">{{ t('deck', 'Delete card') }}</ActionButton>
+					<ActionButton v-if="showArchived === false" icon="icon-delete" @click="deleteCard()">{{ t('deck', 'Delete card') }}</ActionButton>
 					<ActionButton icon="icon-settings-dark" @click="openCard">{{ t('deck', 'Card details') }}</ActionButton>
 				</Actions>
 

From 619f70b33b9ec2b17508a2899b1805e703dd18f8 Mon Sep 17 00:00:00 2001
From: Jakob <jakob.roehrl@web.de>
Date: Thu, 29 Aug 2019 08:39:52 +0200
Subject: [PATCH 3/3] avoid empty names with required

Signed-off-by: Jakob <jakob.roehrl@web.de>
---
 src/components/Controls.vue    | 10 +---------
 src/components/board/Stack.vue | 16 +++-------------
 2 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index 6ad02ef50..7f961f936 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -76,8 +76,7 @@ export default {
 		return {
 			newStackTitle: '',
 			stack: '',
-			showArchived: false,
-			missingStackName: t('deck', 'stack title must be provided')
+			showArchived: false
 		}
 	},
 	computed: {
@@ -90,13 +89,6 @@ export default {
 				return 'opacity: 1.0'
 			}
 			return 'opacity: 0.3'
-		},
-		addNewStackValidation() {
-			if (this.newStackTitle === '') {
-				return false
-			}
-
-			return true
 		}
 	},
 	methods: {
diff --git a/src/components/board/Stack.vue b/src/components/board/Stack.vue
index 824a1e183..4275b247a 100644
--- a/src/components/board/Stack.vue
+++ b/src/components/board/Stack.vue
@@ -48,11 +48,9 @@
 			<label for="new-stack-input-main" class="hidden-visually">Add a new card</label>
 			<input id="new-stack-input-main" v-model="newCardTitle" type="text"
 				class="no-close"
-				placeholder="Add a new card">
+				placeholder="Add a new card" required>
 
-			<input v-tooltip="{content: missingCardName, show: !addNewCardValidation, trigger: 'manual' }"
-				:disabled="!addNewCardValidation"
-				class="icon-confirm"
+			<input class="icon-confirm"
 				type="submit"
 				value="">
 		</form>
@@ -87,20 +85,12 @@ export default {
 		return {
 			editing: false,
 			copiedStack: '',
-			newCardTitle: '',
-			missingCardName: t('deck', 'card title must be provided')
+			newCardTitle: ''
 		}
 	},
 	computed: {
 		cardsByStack() {
 			return (id) => this.$store.getters.cardsByStack(id)
-		},
-		addNewCardValidation() {
-			if (this.newCardTitle === '') {
-				return false
-			}
-
-			return true
 		}
 	},