Fix tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>

lib/Db/Circle.php

@@ -23,8 +23,6 @@
 
 namespace OCA\Deck\Db;
 
-use OCP\Share\IShare;
-
 class Circle extends RelationalObject {
 
 	/** @var \OCA\Circles\Model\Circle */

lib/Db/Group.php

@@ -24,7 +24,6 @@
 namespace OCA\Deck\Db;
 
 use OCP\IGroup;
-use OCP\Share\IShare;
 
 class Group extends RelationalObject {
 	public function __construct(IGroup $group) {

lib/Db/User.php

@@ -24,7 +24,6 @@
 namespace OCA\Deck\Db;
 
 use OCP\IUser;
-use OCP\Share\IShare;
 
 class User extends RelationalObject {
 	public function __construct(IUser $user) {

tests/unit/Db/GroupTest.php

@@ -38,7 +38,8 @@ class GroupTest extends \Test\TestCase {
 		$groupRelationalObject = new Group($group);
 		$expected = [
 			'uid' => 'mygroup',
-			'displayname' => 'My Group'
+			'displayname' => 'My Group',
+			'type' => 1
 		];
 		$this->assertEquals($expected, $groupRelationalObject->getObjectSerialization());
 	}
@@ -56,7 +57,8 @@ class GroupTest extends \Test\TestCase {
 		$expected = [
 			'uid' => 'mygroup',
 			'displayname' => 'My Group',
-			'primaryKey' => '1:mygroup'
+			'primaryKey' => 'mygroup',
+			'type' => 1
 		];
 
 		$actual = $groupRelationalObject->jsonSerialize();

tests/unit/Db/UserTest.php

@@ -38,7 +38,8 @@ class UserTest extends \Test\TestCase {
 		$userRelationalObject = new User($user);
 		$expected = [
 			'uid' => 'myuser',
-			'displayname' => 'myuser displayname'
+			'displayname' => 'myuser displayname',
+			'type' => 0
 		];
 		$this->assertEquals($expected, $userRelationalObject->getObjectSerialization());
 	}
@@ -56,7 +57,8 @@ class UserTest extends \Test\TestCase {
 		$expected = [
 			'uid' => 'myuser',
 			'displayname' => 'myuser displayname',
-			'primaryKey' => '0:myuser'
+			'primaryKey' => 'myuser',
+			'type' => 0,
 		];
 		$this->assertEquals($expected, $userRelationalObject->jsonSerialize());
 	}

tests/unit/controller/LabelApiControllerTest.php

@@ -34,7 +34,9 @@ class LabelApiControllerTest extends \Test\TestCase {
 	private $request;
 	private $labelService;
 	private $userId = 'admin';
-	private $exampleLabel;
+	private $exampleLabel = [
+		'id' => 123
+	];
 
 	public function setUp(): void {
 		parent::setUp();

tests/unit/controller/StackApiControllerTest.php

@@ -36,8 +36,8 @@ class StackApiControllerTest extends \Test\TestCase {
 	private $controller;
 	private $boardService;
 	private $stackService;
-	private $exampleStack;
-	private $exampleBoard;
+	private $exampleStack = [];
+	private $exampleBoard = [];
 
 	public function setUp(): void {
 		parent::setUp();
@@ -45,13 +45,13 @@ class StackApiControllerTest extends \Test\TestCase {
 		$this->boardService = $this->createMock(BoardService::class);
 		$this->stackService = $this->createMock(StackService::class);
 
+		$this->exampleBoard['boardId'] = '89';
+
 		$this->exampleStack['id'] = 345;
 		$this->exampleStack['boardId'] = $this->exampleBoard['boardId'];
 		$this->exampleStack['order'] = 0;
 		$this->exampleStack['title'] = 'Example Stack From API';
 
-		$this->exampleBoard['boardId'] = '89';
-
 		$this->controller = new StackApiController(
 			$this->appName,
 			$this->request,