ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix tests

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2020-05-06 09:34:38 +02:00
parent 611f9ff6a5
commit fc5c34897e
7 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Db/Circle.php
View File

@@ -23,8 +23,6 @@
namespace OCA\Deck\Db; namespace OCA\Deck\Db;
use OCP\Share\IShare;
class Circle extends RelationalObject { class Circle extends RelationalObject {
/** @var \OCA\Circles\Model\Circle */ /** @var \OCA\Circles\Model\Circle */

1
lib/Db/Group.php
View File

@@ -24,7 +24,6 @@
namespace OCA\Deck\Db; namespace OCA\Deck\Db;
use OCP\IGroup; use OCP\IGroup;
use OCP\Share\IShare;
class Group extends RelationalObject { class Group extends RelationalObject {
public function __construct(IGroup $group) { public function __construct(IGroup $group) {

1
lib/Db/User.php
View File

@@ -24,7 +24,6 @@
namespace OCA\Deck\Db; namespace OCA\Deck\Db;
use OCP\IUser; use OCP\IUser;
use OCP\Share\IShare;
class User extends RelationalObject { class User extends RelationalObject {
public function __construct(IUser $user) { public function __construct(IUser $user) {

6
tests/unit/Db/GroupTest.php
View File

@@ -38,7 +38,8 @@ class GroupTest extends \Test\TestCase {
$groupRelationalObject = new Group($group); $groupRelationalObject = new Group($group);
$expected = [ $expected = [
'uid' => 'mygroup', 'uid' => 'mygroup',
'displayname' => 'My Group' 'displayname' => 'My Group',
'type' => 1
]; ];
$this->assertEquals($expected, $groupRelationalObject->getObjectSerialization()); $this->assertEquals($expected, $groupRelationalObject->getObjectSerialization());
} }
@@ -56,7 +57,8 @@ class GroupTest extends \Test\TestCase {
$expected = [ $expected = [
'uid' => 'mygroup', 'uid' => 'mygroup',
'displayname' => 'My Group', 'displayname' => 'My Group',
'primaryKey' => '1:mygroup' 'primaryKey' => 'mygroup',
'type' => 1
]; ];
$actual = $groupRelationalObject->jsonSerialize(); $actual = $groupRelationalObject->jsonSerialize();

6
tests/unit/Db/UserTest.php
View File

@@ -38,7 +38,8 @@ class UserTest extends \Test\TestCase {
$userRelationalObject = new User($user); $userRelationalObject = new User($user);
$expected = [ $expected = [
'uid' => 'myuser', 'uid' => 'myuser',
'displayname' => 'myuser displayname' 'displayname' => 'myuser displayname',
'type' => 0
]; ];
$this->assertEquals($expected, $userRelationalObject->getObjectSerialization()); $this->assertEquals($expected, $userRelationalObject->getObjectSerialization());
} }
@@ -56,7 +57,8 @@ class UserTest extends \Test\TestCase {
$expected = [ $expected = [
'uid' => 'myuser', 'uid' => 'myuser',
'displayname' => 'myuser displayname', 'displayname' => 'myuser displayname',
'primaryKey' => '0:myuser' 'primaryKey' => 'myuser',
'type' => 0,
]; ];
$this->assertEquals($expected, $userRelationalObject->jsonSerialize()); $this->assertEquals($expected, $userRelationalObject->jsonSerialize());
} }

4
tests/unit/controller/LabelApiControllerTest.php
View File

@@ -34,7 +34,9 @@ class LabelApiControllerTest extends \Test\TestCase {
private $request; private $request;
private $labelService; private $labelService;
private $userId = 'admin'; private $userId = 'admin';
private $exampleLabel; private $exampleLabel = [
'id' => 123
];
public function setUp(): void { public function setUp(): void {
parent::setUp(); parent::setUp();

8
tests/unit/controller/StackApiControllerTest.php
View File

@@ -36,8 +36,8 @@ class StackApiControllerTest extends \Test\TestCase {
private $controller; private $controller;
private $boardService; private $boardService;
private $stackService; private $stackService;
private $exampleStack; private $exampleStack = [];
private $exampleBoard; private $exampleBoard = [];
public function setUp(): void { public function setUp(): void {
parent::setUp(); parent::setUp();
@@ -45,13 +45,13 @@ class StackApiControllerTest extends \Test\TestCase {
$this->boardService = $this->createMock(BoardService::class); $this->boardService = $this->createMock(BoardService::class);
$this->stackService = $this->createMock(StackService::class); $this->stackService = $this->createMock(StackService::class);
$this->exampleBoard['boardId'] = '89';
$this->exampleStack['id'] = 345; $this->exampleStack['id'] = 345;
$this->exampleStack['boardId'] = $this->exampleBoard['boardId']; $this->exampleStack['boardId'] = $this->exampleBoard['boardId'];
$this->exampleStack['order'] = 0; $this->exampleStack['order'] = 0;
$this->exampleStack['title'] = 'Example Stack From API'; $this->exampleStack['title'] = 'Example Stack From API';
$this->exampleBoard['boardId'] = '89';
$this->controller = new StackApiController( $this->controller = new StackApiController(
$this->appName, $this->appName,
$this->request, $this->request,