ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix static analysis by stubbing more circle methods

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2022-07-05 08:30:40 +02:00
parent 00120a6b37
commit f03ffd13a0
3 changed files with 68 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
composer.lock generated
View File

@@ -305,17 +305,17 @@
"source": { "source": {
"type": "git", "type": "git",
"url": "https://github.com/ChristophWurst/nextcloud_composer.git", "url": "https://github.com/ChristophWurst/nextcloud_composer.git",
"reference": "5e9719488fe558db974ef45f289a6911fe2c6850" "reference": "309ccfab8b7e842df9f17d6389f190411158bd36"
}, },
"dist": { "dist": {
"type": "zip", "type": "zip",
"url": "https://api.github.com/repos/ChristophWurst/nextcloud_composer/zipball/5e9719488fe558db974ef45f289a6911fe2c6850", "url": "https://api.github.com/repos/ChristophWurst/nextcloud_composer/zipball/309ccfab8b7e842df9f17d6389f190411158bd36",
"reference": "5e9719488fe558db974ef45f289a6911fe2c6850", "reference": "309ccfab8b7e842df9f17d6389f190411158bd36",
"shasum": "" "shasum": ""
}, },
"require": { "require": {
"php": "^7.4 || ~8.0 || ~8.1", "php": "^7.4 || ~8.0 || ~8.1",
"psr/container": "^1.0", "psr/container": "^1.1.1",
"psr/event-dispatcher": "^1.0", "psr/event-dispatcher": "^1.0",
"psr/log": "^1.1" "psr/log": "^1.1"
}, },
@@ -341,7 +341,7 @@
"issues": "https://github.com/ChristophWurst/nextcloud_composer/issues", "issues": "https://github.com/ChristophWurst/nextcloud_composer/issues",
"source": "https://github.com/ChristophWurst/nextcloud_composer/tree/master" "source": "https://github.com/ChristophWurst/nextcloud_composer/tree/master"
}, },
"time": "2022-05-11T02:03:08+00:00" "time": "2022-07-02T02:10:17+00:00"
}, },
{ {
"name": "composer/package-versions-deprecated", "name": "composer/package-versions-deprecated",
@@ -5473,5 +5473,5 @@
"platform-overrides": { "platform-overrides": {
"php": "7.4" "php": "7.4"
}, },
"plugin-api-version": "2.2.0" "plugin-api-version": "2.3.0"
} }

4
tests/psalm-baseline.xml
View File

@@ -127,7 +127,9 @@
</TooManyArguments> </TooManyArguments>
</file> </file>
<file src="lib/Service/CirclesService.php"> <file src="lib/Service/CirclesService.php">
<UndefinedClass occurrences="1"/> <RedundantCondition occurrences="1">
<code>$member !== null</code>
</RedundantCondition>
</file> </file>
<file src="lib/Service/FileService.php"> <file src="lib/Service/FileService.php">
<RedundantCondition occurrences="2"> <RedundantCondition occurrences="2">

17
tests/stub.phpstub
View File

@@ -42,6 +42,8 @@ namespace OCA\Circles\Model {
public const APP_CIRCLES = 10001; public const APP_CIRCLES = 10001;
public const APP_OCC = 10002; public const APP_OCC = 10002;
public const APP_DEFAULT = 11000; public const APP_DEFAULT = 11000;
public function getLevel(): int {}
} }
class Circle { class Circle {
@@ -50,17 +52,30 @@ namespace OCA\Circles\Model {
public function getOwner(): string {} public function getOwner(): string {}
public function getSingleId(): string {} public function getSingleId(): string {}
public function getInheritedMembers(): array {} public function getInheritedMembers(): array {}
public function getInitiator(): Member {}
}
class FederatedUser {
} }
} }
namespace OCA\Circles\Model\Probes { namespace OCA\Circles\Model\Probes {
class CircleProble { class CircleProbe {
public function __construct() {} public function __construct() {}
public function mustBeMember(bool $must = true): self {}
} }
} }
namespace OCA\Circles { namespace OCA\Circles {
use OCA\Circles\Model\Circle;
use OCA\Circles\Model\FederatedUser;
use OCA\Circles\Model\Probes\CircleProbe;
class CirclesManager { class CirclesManager {
public function startSuperSession(): void {}
public function startSession(?FederatedUser $federatedUser = null): void {}
public function getCircles(?CircleProbe $probe = null): array {}
public function getCircle(string $singleId, ?CircleProbe $probe = null): Circle {}
public function getFederatedUser(string $federatedId, int $type = Member::TYPE_SINGLE): FederatedUser {}
} }
} }