ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix validation of attachment data

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2022-11-03 20:37:47 +01:00
parent b648947ad7
commit ed282479a1
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Service/AttachmentService.php
View File

@@ -194,7 +194,7 @@ class AttachmentService {
* @throws BadRequestException * @throws BadRequestException
*/ */
public function create($cardId, $type, $data) { public function create($cardId, $type, $data) {
$this->attachmentServiceValidator->check(compact('cardId', 'type', 'data')); $this->attachmentServiceValidator->check(compact('cardId', 'type'));
$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT); $this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);

1
tests/integration/features/bootstrap/AttachmentContext.php
View File

@@ -67,6 +67,7 @@ class AttachmentContext implements Context {
* @Given remember the last attachment as :arg1 * @Given remember the last attachment as :arg1
*/ */
public function rememberTheLastAttachmentAs($arg1) { public function rememberTheLastAttachmentAs($arg1) {
$this->requestContext->theResponseShouldHaveStatusCode(200);
$this->lastAttachment = $this->requestContext->getResponseBodyFromJson(); $this->lastAttachment = $this->requestContext->getResponseBodyFromJson();
$this->rememberedAttachments[$arg1] = $this->lastAttachment; $this->rememberedAttachments[$arg1] = $this->lastAttachment;
} }