From bf7e7e33b2fb1a5875a879f6938ce8c3237117e4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 14 Nov 2023 18:10:32 +0100
Subject: [PATCH 1/4] fix: fix copy paste error to bring back label picker
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/components/card/TagSelector.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/card/TagSelector.vue b/src/components/card/TagSelector.vue
index 323a447b1..b71b21423 100644
--- a/src/components/card/TagSelector.vue
+++ b/src/components/card/TagSelector.vue
@@ -63,7 +63,7 @@ export default {
 			return [...this.labels].sort((a, b) => (a.title < b.title) ? -1 : 1)
 		},
 		assignedLabels() {
-			return [...this.card.labels].local((a, b) => (a.title < b.title) ? -1 : 1)
+			return [...this.card.labels].sort((a, b) => (a.title < b.title) ? -1 : 1)
 		},
 	},
 	methods: {

From 91ce24b7a6ddfe8d51e9273c12d0350dc955aa36 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 14 Nov 2023 18:11:10 +0100
Subject: [PATCH 2/4] fix: Bring back upcoming cards view by adapting to proper
 API return value
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/store/overview.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/store/overview.js b/src/store/overview.js
index 5ac6fb6e7..7c0f19433 100644
--- a/src/store/overview.js
+++ b/src/store/overview.js
@@ -52,11 +52,11 @@ export default {
 			const promise = (async () => {
 				commit('setCurrentBoard', null)
 				const assignedCards = await apiClient.get('upcoming')
-				const assignedCardsFlat = assignedCards.flat()
+				const assignedCardsFlat = Object.values(assignedCards).flat()
 				for (const i in assignedCardsFlat) {
 					commit('addCard', assignedCardsFlat[i])
 				}
-				commit('setAssignedCards', assignedCardsFlat)
+				commit('setAssignedCards', assignedCards)
 				commit('setLoading', false)
 			})()
 			commit('setLoading', promise)

From 9e41cb162de805677f50dff34874ef0430db47de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 14 Nov 2023 18:47:20 +0100
Subject: [PATCH 3/4] test: Add test selectors and label multiselect cypress
 test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 cypress/e2e/cardFeatures.js                | 33 ++++++++++++++++++++++
 src/components/card/AssignmentSelector.vue |  2 +-
 src/components/card/Description.vue        |  2 +-
 src/components/card/DueDateSelector.vue    |  2 +-
 src/components/card/TagSelector.vue        |  4 +--
 5 files changed, 38 insertions(+), 5 deletions(-)

diff --git a/cypress/e2e/cardFeatures.js b/cypress/e2e/cardFeatures.js
index fc85cff11..ee5de838f 100644
--- a/cypress/e2e/cardFeatures.js
+++ b/cypress/e2e/cardFeatures.js
@@ -217,6 +217,39 @@ describe('Card', function() {
 			cy.get(`.card:contains("${newCardTitle}")`).find('[data-due-state]').should('not.exist')
 		})
 
+		it('Add a label', function() {
+			const newCardTitle = 'Card with labels'
+
+			cy.get('.button-vue[aria-label*="Add card"]')
+				.first().click()
+			cy.get('.stack__card-add form input#new-stack-input-main')
+				.type(newCardTitle)
+			cy.get('.stack__card-add form input[type=submit]')
+				.first().click()
+			cy.get(`.card:contains("${newCardTitle}")`).should('be.visible').click()
+
+			cy.get('#app-sidebar-vue [data-test="tag-selector"]').should('be.visible').click()
+			cy.get('.multiselect__option:contains("Action needed")').should('be.visible').click()
+
+			cy.get('[data-test="tag-selector"] .selector-wrapper--icon').click()
+			cy.get('.multiselect__option:contains("Action needed")').should('not.be.visible')
+
+			cy.get('[data-test="tag-selector"] .multiselect__tags .tag:contains("Action needed")')
+				.should('be.visible')
+
+			cy.get(`.card:contains("${newCardTitle}")`).find('.labels li:contains("Action needed")')
+				.should('be.visible')
+
+			cy.get('#app-sidebar-vue [data-test="tag-selector"]').should('be.visible').click()
+			cy.get('.multiselect__option:contains("Later")').should('be.visible').click()
+			cy.get('.multiselect__option:contains("Action needed")').should('be.visible').click()
+
+			cy.get(`.card:contains("${newCardTitle}")`).find('.labels li:contains("Later")')
+				.should('be.visible')
+			cy.get(`.card:contains("${newCardTitle}")`).find('.labels li:contains("Action needed")')
+				.should('not.exist')
+		})
+
 	})
 
 })
diff --git a/src/components/card/AssignmentSelector.vue b/src/components/card/AssignmentSelector.vue
index bfebfe3e4..6b9287b6c 100644
--- a/src/components/card/AssignmentSelector.vue
+++ b/src/components/card/AssignmentSelector.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="selector-wrapper" :aria-label="t('deck', 'Assign to users/groups/circles')">
+	<div class="selector-wrapper" :aria-label="t('deck', 'Assign to users/groups/circles')" data-test="assignment-selector">
 		<div class="selector-wrapper--icon">
 			<AccountMultiple :size="20" />
 		</div>
diff --git a/src/components/card/Description.vue b/src/components/card/Description.vue
index 76c5fbdfe..a804de325 100644
--- a/src/components/card/Description.vue
+++ b/src/components/card/Description.vue
@@ -21,7 +21,7 @@
   -->
 
 <template>
-	<div>
+	<div data-test="description">
 		<h5>
 			{{ t('deck', 'Description') }}
 			<span v-if="descriptionLastEdit && !descriptionSaving">{{ t('deck', '(Unsaved)') }}</span>
diff --git a/src/components/card/DueDateSelector.vue b/src/components/card/DueDateSelector.vue
index e04055406..1bfb8bd88 100644
--- a/src/components/card/DueDateSelector.vue
+++ b/src/components/card/DueDateSelector.vue
@@ -1,5 +1,5 @@
 <template>
-	<CardDetailEntry :label="t('deck', 'Assign a due date to this card…')">
+	<CardDetailEntry :label="t('deck', 'Assign a due date to this card…')" data-test="due-date-selector">
 		<Calendar v-if="!card.done" slot="icon" :size="20" />
 		<CalendarCheck v-else slot="icon" :size="20" />
 		<template v-if="!card.done && !card.archived">
diff --git a/src/components/card/TagSelector.vue b/src/components/card/TagSelector.vue
index b71b21423..45c68fb1f 100644
--- a/src/components/card/TagSelector.vue
+++ b/src/components/card/TagSelector.vue
@@ -1,9 +1,9 @@
 <template>
-	<div class="selector-wrapper" :aria-label="t('deck', 'Assign a tag to this card…')">
+	<div class="selector-wrapper" :aria-label="t('deck', 'Assign a tag to this card…')" data-test="tag-selector">
 		<div class="selector-wrapper--icon">
 			<TagMultiple :size="20" />
 		</div>
-		<NcMultiselect v-model="assignedLabels"
+		<NcMultiselect :value="assignedLabels"
 			class="selector-wrapper--selector"
 			:multiple="true"
 			:disabled="disabled"

From 446360437da0c84e5c6e22ff0729e958c0d56a75 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 14 Nov 2023 19:05:28 +0100
Subject: [PATCH 4/4] test: Add cypress test for upcoming card
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 cypress/e2e/deckDashboard.js | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/cypress/e2e/deckDashboard.js b/cypress/e2e/deckDashboard.js
index aedccc2a2..eb8a0dd75 100644
--- a/cypress/e2e/deckDashboard.js
+++ b/cypress/e2e/deckDashboard.js
@@ -1,4 +1,5 @@
 import { randUser } from '../utils/index.js'
+import { sampleBoard } from '../utils/sampleBoard'
 const user = randUser()
 
 describe('Deck dashboard', function() {
@@ -8,16 +9,18 @@ describe('Deck dashboard', function() {
 
 	beforeEach(function() {
 		cy.login(user)
-		cy.visit('/apps/deck')
 	})
 
 	it('Can show the right title on the dashboard', function() {
+		cy.visit('/apps/deck')
 		cy.get('.board-title h2')
 			.should('have.length', 1).first()
 			.should($el => expect($el.text().trim()).to.equal('Upcoming cards'))
 	})
 
 	it('Can see the default "Personal Board" created for user by default', function() {
+		cy.visit('/apps/deck')
+
 		const defaultBoard = 'Personal'
 
 		cy.get('.app-navigation-entry-wrapper[icon=icon-deck]')
@@ -26,4 +29,29 @@ describe('Deck dashboard', function() {
 			.contains(defaultBoard)
 			.should('be.visible')
 	})
+
+	it('Shows a card with due date on the overview', function() {
+		cy.createExampleBoard({
+			user,
+			board: sampleBoard(),
+		}).then((board) => {
+			cy.visit(`/apps/deck/#/board/${board.id}`)
+
+			cy.intercept({ method: 'PUT', url: '**/apps/deck/cards/**' }).as('updateCard')
+
+			const newCardTitle = 'Hello world'
+			cy.get(`.card:contains("${newCardTitle}")`).should('be.visible').click()
+			cy.get('#app-sidebar-vue [data-cy-due-date-actions]').should('be.visible').click()
+			cy.get('[data-cy-due-date-shortcut="tomorrow"] button').should('be.visible').click()
+
+			cy.wait('@updateCard')
+
+			cy.get('button[title="Close sidebar"]').click()
+			cy.get('.app-navigation-entry:contains("Upcoming cards") a').click()
+
+			cy.get(`.card:contains("${newCardTitle}")`).should('be.visible')
+			cy.get('.dashboard-column:contains("Tomorrow")').should('be.visible')
+			cy.get('.dashboard-column:contains("Tomorrow") .card:contains("Hello world")').should('be.visible')
+		})
+	})
 })