ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

tests: Fix url generation mocks and cleanup some phpunit code

Browse Source 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
This commit is contained in:
Julius Knorr
2025-01-17 10:59:25 +01:00
committed by backportbot[bot]
parent 81c8aad66f
commit e9e5234925
11 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/unit/Service/BoardServiceTest.php
View File

@@ -291,7 +291,7 @@ class BoardServiceTest extends TestCase {
));
}
public function dataAddAclExtendPermission() {
public static function dataAddAclExtendPermission() {
return [
[[false, false, false], [false, false, false], [false, false, false]],
[[false, false, false], [true, true, true], [false, false, false]],

2
tests/unit/Service/CardServiceTest.php
View File

@@ -365,7 +365,7 @@ class CardServiceTest extends TestCase {
$this->cardService->rename(123, 'newtitle');
}
public function dataReorder() {
public static function dataReorder() {
return [
[0, 0, [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]],
[0, 9, [1, 2, 3, 4, 5, 6, 7, 8, 9, 0]],

4
tests/unit/Service/PermissionServiceTest.php
View File

@@ -151,7 +151,7 @@ class PermissionServiceTest extends \Test\TestCase {
$this->assertEquals(false, $this->service->userIsBoardOwner(123));
}
public function dataTestUserCan() {
public static function dataTestUserCan() {
return [
// participant permissions type
['admin', false, false, false, 'user', true, false, false, false],
@@ -183,7 +183,7 @@ class PermissionServiceTest extends \Test\TestCase {
$this->assertFalse($this->service->userCan([], Acl::PERMISSION_EDIT));
}
public function dataCheckPermission() {
public static function dataCheckPermission() {
return [
// see getAcls() for set permissions
[1, Acl::PERMISSION_READ, true],