From e48a1c6a9474982f1c495c1c39d9310f138401af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Wed, 19 Jul 2023 09:55:43 +0200 Subject: [PATCH] draft: todos MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- lib/Service/Importer/BoardImportService.php | 1 - lib/Service/Importer/Systems/DeckJsonService.php | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Service/Importer/BoardImportService.php b/lib/Service/Importer/BoardImportService.php index dcd0bbc0c..ba08c7a93 100644 --- a/lib/Service/Importer/BoardImportService.php +++ b/lib/Service/Importer/BoardImportService.php @@ -117,7 +117,6 @@ class BoardImportService { $this->importComments(); $this->importCardAssignments(); } catch (\Throwable $th) { - throw $th; throw new BadRequestException($th->getMessage()); } } diff --git a/lib/Service/Importer/Systems/DeckJsonService.php b/lib/Service/Importer/Systems/DeckJsonService.php index 57caff6c7..37c99ec11 100644 --- a/lib/Service/Importer/Systems/DeckJsonService.php +++ b/lib/Service/Importer/Systems/DeckJsonService.php @@ -216,6 +216,8 @@ class DeckJsonService extends ABoardImportService { $acl->setPermissionEdit(false); $acl->setPermissionShare(false); $acl->setPermissionManage(false); + // FIXME: Figure out a way to collect and aggregate warnings about users + // FIXME: Maybe have a dry run? $return[] = $acl; } return $return;