From dc917b1e5d7aefa15e5b9948e8b95cad8a720752 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Tue, 10 Oct 2017 19:31:31 +0200 Subject: [PATCH] Fix inspection issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- lib/Service/BoardService.php | 6 +++--- lib/Service/PermissionService.php | 2 +- lib/Service/StackService.php | 10 +++++++++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/lib/Service/BoardService.php b/lib/Service/BoardService.php index 0f3482fee..072f7c1f5 100644 --- a/lib/Service/BoardService.php +++ b/lib/Service/BoardService.php @@ -157,10 +157,10 @@ class BoardService { 'F1DB50' => $this->l10n->t('Later') ]; $labels = []; - foreach ($default_labels as $color => $title) { + foreach ($default_labels as $labelColor => $labelTitle) { $label = new Label(); - $label->setColor($color); - $label->setTitle($title); + $label->setColor($labelColor); + $label->setTitle($labelTitle); $label->setBoardId($new_board->getId()); $labels[] = $this->labelMapper->insert($label); } diff --git a/lib/Service/PermissionService.php b/lib/Service/PermissionService.php index 5d301456c..f32748356 100644 --- a/lib/Service/PermissionService.php +++ b/lib/Service/PermissionService.php @@ -89,7 +89,7 @@ class PermissionService { /** * Get current user permissions for a board * - * @param Board $board + * @param Board|Entity $board * @return array|bool * @internal param $boardId */ diff --git a/lib/Service/StackService.php b/lib/Service/StackService.php index b80cba14e..2e8155068 100644 --- a/lib/Service/StackService.php +++ b/lib/Service/StackService.php @@ -41,8 +41,16 @@ class StackService { private $labelMapper; private $permissionService; private $boardService; + private $assignedUsersMapper; - public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, PermissionService $permissionService, BoardService $boardService, AssignedUsersMapper $assignedUsersMapper) { + public function __construct( + StackMapper $stackMapper, + CardMapper $cardMapper, + LabelMapper $labelMapper, + PermissionService $permissionService, + BoardService $boardService, + AssignedUsersMapper $assignedUsersMapper + ) { $this->stackMapper = $stackMapper; $this->cardMapper = $cardMapper; $this->labelMapper = $labelMapper;