From d82746be97b7a990b4c2c48273a0ee861f7273f7 Mon Sep 17 00:00:00 2001 From: Ryan Fletcher Date: Thu, 12 Jul 2018 17:31:59 -0400 Subject: [PATCH] Error handling for undoDelete and created an update method in BoardApiController Signed-off-by: Ryan Fletcher --- lib/Controller/BoardApiController.php | 32 +++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/lib/Controller/BoardApiController.php b/lib/Controller/BoardApiController.php index 448428bbb..c90d1240d 100644 --- a/lib/Controller/BoardApiController.php +++ b/lib/Controller/BoardApiController.php @@ -3,6 +3,7 @@ * @copyright Copyright (c) 2017 Steven R. Baker * * @author Steven R. Baker + * @author Ryan Fletcher * * @license GNU AGPL version 3 or any later version * @@ -101,6 +102,28 @@ class BoardApiController extends ApiController { return new DataResponse($board); } + /** + * @NoAdminRequired + * @CORS + * @NoCSRFRequired + * + * @params $boardId + * @params $title + * @params $color + * @params $archived + * + * Create a board with the specified title and color. + */ + public function update($boardId, $title, $color, $archived) { + $board = $this->service->update($boardId, $title, $color, $archived); + + if ($board === false || $board === null) { + return new DataResponse('Board not found', HTTP::STATUS_NOT_FOUND); + } + + return new DataResponse($board, HTTP::STATUS_OK); + } + /** * @NoAdminRequired * @CORS @@ -131,9 +154,14 @@ class BoardApiController extends ApiController { */ public function undoDelete($id) { $board = $this->service->find($id); - $this->service->deleteUndo($id); - return new DataResponse($board); + if ($board === false || $board === null) { + return new DataResponse('Board not found', HTTP::STATUS_NOT_FOUND); + } else { + $board = $this->service->deleteUndo($id); + } + + return new DataResponse($board, HTTP::STATUS_OK); } }