ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

now the tests are working

Browse Source 
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
This commit is contained in:
Jakob Röhrl
2019-02-20 14:15:31 +01:00
committed by Julius Härtl
parent ee20841ad6
commit d11917e4ff
1 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/Service/LabelService.php
View File

@@ -93,12 +93,13 @@ class LabelService {
$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE); $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
//$this->checkDuplicateTitle($boardId, $title); //$this->checkDuplicateTitle($boardId, $title);
$boardLabels = array();
$boardLabels = $this->labelMapper->findAll($boardId); $boardLabels = $this->labelMapper->findAll($boardId);
foreach($boardLabels as $boardLabel) { if (is_array($boardLabels) || is_object($boardLabels)) {
if ($boardLabel->getTitle() === $title) { foreach($boardLabels as $boardLabel) {
throw new BadRequestException('title must be unique'); if ($boardLabel->getTitle() === $title) {
break; throw new BadRequestException('title must be unique');
break;
}
} }
} }
@@ -169,13 +170,15 @@ class LabelService {
$boardLabels = array(); $boardLabels = array();
$boardLabels = $this->labelMapper->findAll($label->getBoardId()); $boardLabels = $this->labelMapper->findAll($label->getBoardId());
foreach($boardLabels as $boardLabel) { if (is_array($boardLabels) || is_object($boardLabels)) {
if ($boardLabel->getId() === $label->getId()) { foreach($boardLabels as $boardLabel) {
continue; if ($boardLabel->getId() === $label->getId()) {
} continue;
if ($boardLabel->getTitle() === $title) { }
throw new BadRequestException('title must be unique'); if ($boardLabel->getTitle() === $title) {
break; throw new BadRequestException('title must be unique');
break;
}
} }
} }