ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(done): Mark card as undone when updating card

Browse Source 
As stated in https://github.com/nextcloud/deck/issues/534#issuecomment-1892061055 updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way".

This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request.

Refs: #534 #4137 c3b4ed6e1f

Signed-off-by: Stefan Niedermann <info@niedermann.it>

Signed-off-by: Niedermann IT-Dienstleistungen <stefan-niedermann@users.noreply.github.com>
This commit is contained in:
Niedermann IT-Dienstleistungen
2024-01-18 12:08:10 +01:00
committed by GitHub
parent 3fd1667549
commit cf4d6268ac
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Service/CardService.php
View File

@@ -355,6 +355,8 @@ class CardService {
} }
if ($done !== null) { if ($done !== null) {
$card->setDone($done->getValue()); $card->setDone($done->getValue());
} else {
$card->setDone(null);
} }