From ca6fe65580e07aa54701401fe9815fceb656e8ca Mon Sep 17 00:00:00 2001 From: Bink Date: Wed, 9 Mar 2022 08:54:52 +0100 Subject: [PATCH] Fix: Check all circle shares for permissions instead of returning after the first --- lib/Service/PermissionService.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Service/PermissionService.php b/lib/Service/PermissionService.php index 2a1aed5e0..0919fc47b 100644 --- a/lib/Service/PermissionService.php +++ b/lib/Service/PermissionService.php @@ -213,7 +213,9 @@ class PermissionService { if ($this->circlesService->isCirclesEnabled() && $acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) { try { - return $this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission); + if ($this->circlesService->isUserInCircle($acl->getParticipant(), $userId) && $acl->getPermission($permission)) { + return true; + } } catch (\Exception $e) { $this->logger->info('Member not found in circle that was accessed. This should not happen.'); }