diff --git a/lib/Activity/ActivityManager.php b/lib/Activity/ActivityManager.php index 4a74e2d9d..4e1d192e0 100644 --- a/lib/Activity/ActivityManager.php +++ b/lib/Activity/ActivityManager.php @@ -325,7 +325,6 @@ class ActivityManager { */ $eventType = 'deck'; $subjectParams = []; - $message = null; switch ($subject) { // No need to enhance parameters since entity already contains the required data case self::SUBJECT_BOARD_CREATE: @@ -434,10 +433,6 @@ class ActivityManager { ->setSubject($subject, $subjectParams) ->setTimestamp(time()); - if ($message !== null) { - $event->setMessage($message); - } - // FIXME: We currently require activities for comments even if they are disabled though settings // Get rid of this once the frontend fetches comments/activity individually if ($eventType === 'deck_comment') { diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php index a2a5c9d8c..d19bcc72b 100644 --- a/lib/Activity/DeckProvider.php +++ b/lib/Activity/DeckProvider.php @@ -294,7 +294,7 @@ class DeckProvider implements IProvider { if (array_key_exists('comment', $subjectParams)) { /** @var IComment $comment */ try { - $comment = $this->commentsManager->get((int)$subjectParams['comment']); + $comment = $this->commentsManager->get($subjectParams['comment']); $event->setParsedMessage($comment->getMessage()); $params['comment'] = [ 'type' => 'highlight', diff --git a/lib/Db/AclMapper.php b/lib/Db/AclMapper.php index c271d8d32..cac999d4d 100644 --- a/lib/Db/AclMapper.php +++ b/lib/Db/AclMapper.php @@ -28,6 +28,7 @@ use OCP\AppFramework\Db\MultipleObjectsReturnedException; use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IDBConnection; +/** @template-extends DeckMapper */ class AclMapper extends DeckMapper implements IPermissionMapper { public function __construct(IDBConnection $db) { parent::__construct($db, 'deck_board_acl', Acl::class); diff --git a/lib/Db/AssignmentMapper.php b/lib/Db/AssignmentMapper.php index 65fa2ba8d..d7d3a1eb8 100644 --- a/lib/Db/AssignmentMapper.php +++ b/lib/Db/AssignmentMapper.php @@ -35,6 +35,7 @@ use OCP\IGroupManager; use OCP\IUserManager; use PDO; +/** @template-extends QBMapper */ class AssignmentMapper extends QBMapper implements IPermissionMapper { /** @var CardMapper */ diff --git a/lib/Db/AttachmentMapper.php b/lib/Db/AttachmentMapper.php index 727e3cce1..c35f49fcf 100644 --- a/lib/Db/AttachmentMapper.php +++ b/lib/Db/AttachmentMapper.php @@ -31,6 +31,7 @@ use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IDBConnection; use OCP\IUserManager; +/** @template-extends DeckMapper */ class AttachmentMapper extends DeckMapper implements IPermissionMapper { private $cardMapper; private $userManager; diff --git a/lib/Db/BoardMapper.php b/lib/Db/BoardMapper.php index c340aa151..5db3c3994 100644 --- a/lib/Db/BoardMapper.php +++ b/lib/Db/BoardMapper.php @@ -33,6 +33,7 @@ use OCP\IUserManager; use OCP\IGroupManager; use Psr\Log\LoggerInterface; +/** @template-extends QBMapper */ class BoardMapper extends QBMapper implements IPermissionMapper { private $labelMapper; private $aclMapper; diff --git a/lib/Db/CardMapper.php b/lib/Db/CardMapper.php index e245c0320..d1b70c600 100644 --- a/lib/Db/CardMapper.php +++ b/lib/Db/CardMapper.php @@ -38,6 +38,7 @@ use OCP\IUser; use OCP\IUserManager; use OCP\Notification\IManager; +/** @template-extends QBMapper */ class CardMapper extends QBMapper implements IPermissionMapper { /** @var LabelMapper */ diff --git a/lib/Db/DeckMapper.php b/lib/Db/DeckMapper.php index 0aa0e7d96..887774409 100644 --- a/lib/Db/DeckMapper.php +++ b/lib/Db/DeckMapper.php @@ -23,15 +23,15 @@ namespace OCA\Deck\Db; +use OCP\AppFramework\Db\Entity; use OCP\AppFramework\Db\QBMapper; use OCP\DB\QueryBuilder\IQueryBuilder; /** - * Class DeckMapper - * - * @package OCA\Deck\Db + * @template T of Entity + * @template-extends QBMapper */ -class DeckMapper extends QBMapper { +abstract class DeckMapper extends QBMapper { /** * @param $id diff --git a/lib/Db/LabelMapper.php b/lib/Db/LabelMapper.php index 61ce03ed3..7f6de33bf 100644 --- a/lib/Db/LabelMapper.php +++ b/lib/Db/LabelMapper.php @@ -29,6 +29,7 @@ use OCP\AppFramework\Db\MultipleObjectsReturnedException; use OCP\DB\QueryBuilder\IQueryBuilder; use OCP\IDBConnection; +/** @template-extends DeckMapper