diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index d56d51808..ec130248a 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -141,23 +141,23 @@
{{ t('deck', 'Filter by completed') }}
-
+
-
+
@@ -165,10 +165,10 @@
v-model="filter.completed"
type="radio"
class="radio"
- :value="true"
+ value="completed"
@change="setFilter"
@click="beforeSetFilter">
-
+
{{ t('deck', 'Filter by due date') }}
@@ -325,7 +325,7 @@ export default {
filterVisible: false,
showArchived: false,
isAddStackVisible: false,
- filter: { tags: [], users: [], due: '', unassigned: false, open: false, completed: false, completedOrOpen: true },
+ filter: { tags: [], users: [], due: '', unassigned: false, completed: 'both' },
showAddCardModal: false,
defaultPageTitle: false,
isNotifyPushEnabled: isNotifyPushEnabled(),
@@ -349,7 +349,7 @@ export default {
}
},
isFilterActive() {
- return this.filter.tags.length !== 0 || this.filter.users.length !== 0 || this.filter.due !== '' || this.filter.open || this.filter.completed || !this.filter.completedOrOpen
+ return this.filter.tags.length !== 0 || this.filter.users.length !== 0 || this.filter.due !== '' || this.filter.completed !== 'both'
},
labelsSorted() {
return [...this.board.labels].sort((a, b) => (a.title < b.title) ? -1 : 1)
@@ -393,22 +393,8 @@ export default {
if (e.target.value === 'unassigned') {
this.filter.users = []
this.$store.dispatch('setFilter', { ...this.filter })
- }
- if (e.target.id === 'filter-option-open') {
- this.filter.open = !this.filter.open
- this.$store.dispatch('setFilter', { ...this.filter })
- }
- if (e.target.id === 'filter-option-completed') {
- this.filter.completed = !this.filter.completed
- this.$store.dispatch('setFilter', { ...this.filter })
- }
- if (e.target.id !== 'filter-option-both') {
- this.filter.completedOrOpen = !(this.filter.open || this.filter.completed)
- this.$store.dispatch('setFilter', { ...this.filter })
} else {
- this.filter.completedOrOpen = true
- this.filter.open = false
- this.filter.completed = false
+ this.filter.completed = 'both'
this.$store.dispatch('setFilter', { ...this.filter })
}
this.$store.dispatch('setFilter', { ...this.filter })
@@ -453,7 +439,7 @@ export default {
}
},
clearFilter() {
- const filterReset = { tags: [], users: [], due: '', open: false, completed: false, completedOrOpen: true }
+ const filterReset = { tags: [], users: [], due: '', completed: 'both' }
this.$store.dispatch('setFilter', { ...filterReset })
this.filter = filterReset
},
@@ -570,7 +556,6 @@ export default {
input + label {
display: block;
padding: 6px 0;
- vertical-align: middle;
.avatardiv {
vertical-align: middle;
margin-bottom: 2px;
diff --git a/src/store/card.js b/src/store/card.js
index 00ff4da92..fb4df408c 100644
--- a/src/store/card.js
+++ b/src/store/card.js
@@ -33,10 +33,10 @@ export default {
getters: {
cardsByStack: (state, getters, rootState) => (id) => {
return state.cards.filter((card) => {
- const { tags, users, due, unassigned, open, completed } = rootState.filter
+ const { tags, users, due, unassigned, completed } = rootState.filter
- if (open && card.done !== null) { return false }
- if (completed && card.done == null) { return false }
+ if (completed === 'open' && card.done !== null) { return false }
+ if (completed === 'completed' && card.done == null) { return false }
let allTagsMatch = true
let allUsersMatch = true
diff --git a/src/store/main.js b/src/store/main.js
index 698e0ff3c..f52aeafc9 100644
--- a/src/store/main.js
+++ b/src/store/main.js
@@ -74,7 +74,7 @@ export default new Vuex.Store({
searchQuery: '',
activity: [],
activityLoadMore: true,
- filter: { tags: [], users: [], due: '', open: false, completed: false, completedOrOpen: true },
+ filter: { tags: [], users: [], due: '', completed: 'both' },
shortcutLock: false,
},
getters: {