ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix scrutinizer issues

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2018-06-19 19:40:12 +02:00
parent 56412498f1
commit c2c0bae3d6
3 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/controller/CardController.js
View File

@@ -101,8 +101,8 @@ app.controller('CardController', function ($scope, $rootScope, $sce, $location,
var reg = /\[(X|\s|\_|\-)\]\s(.*)/ig; var reg = /\[(X|\s|\_|\-)\]\s(.*)/ig;
var nth = 0; var nth = 0;
$scope.status.edit.description = $scope.status.edit.description.replace(reg, function (match, i, original) { $scope.status.edit.description = $scope.status.edit.description.replace(reg, function (match, i, original) {
var result = match;
if (nth++ === id) { if (nth++ === id) {
var result;
if (match.match(/^\[\s\]/i)) { if (match.match(/^\[\s\]/i)) {
result = match.replace(/\[\s\]/i, '[x]'); result = match.replace(/\[\s\]/i, '[x]');
} }

16
lib/Db/AttachmentMapper.php
View File

@@ -37,6 +37,7 @@ class AttachmentMapper extends DeckMapper implements IPermissionMapper {
private $cardMapper; private $cardMapper;
private $userManager; private $userManager;
private $qb;
public function __construct(IDBConnection $db, CardMapper $cardMapper, IUserManager $userManager) { public function __construct(IDBConnection $db, CardMapper $cardMapper, IUserManager $userManager) {
parent::__construct($db, 'deck_attachment', Attachment::class); parent::__construct($db, 'deck_attachment', Attachment::class);
@@ -111,21 +112,6 @@ class AttachmentMapper extends DeckMapper implements IPermissionMapper {
return $entities; return $entities;
} }
/**
* @param Attachment $attachment
* @throws \Exception
*/
public function mapParticipant(Attachment $attachment) {
$userManager = $this->userManager;
$attachment->resolveRelation('participant', function() use (&$userManager, &$attachment) {
$user = $userManager->get($attachment->getParticipant());
if ($user !== null) {
return new User($user);
}
return null;
});
}
/** /**
* Check if $userId is owner of Entity with $id * Check if $userId is owner of Entity with $id

1
lib/Service/CardService.php
View File

@@ -40,6 +40,7 @@ class CardService {
private $permissionService; private $permissionService;
private $boardService; private $boardService;
private $assignedUsersMapper; private $assignedUsersMapper;
private $attachmentService;
public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService, BoardService $boardService, AssignedUsersMapper $assignedUsersMapper, AttachmentService $attachmentService) { public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService, BoardService $boardService, AssignedUsersMapper $assignedUsersMapper, AttachmentService $attachmentService) {
$this->cardMapper = $cardMapper; $this->cardMapper = $cardMapper;