Transfer deck ownership even if target user already participant of a board
https://github.com/nextcloud/deck/pull/1955#issuecomment-640392715 Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
This commit is contained in:
committed by
Julius Härtl
parent
a0f93a81d2
commit
bdf4631504
@@ -64,13 +64,33 @@ class AclMapper extends DeckMapper implements IPermissionMapper {
|
||||
* @return void
|
||||
*/
|
||||
public function transferOwnership($ownerId, $newOwnerId) {
|
||||
$params = [
|
||||
'owner' => $ownerId,
|
||||
'newOwner' => $newOwnerId,
|
||||
'type' => Acl::PERMISSION_TYPE_USER
|
||||
];
|
||||
$sql = "UPDATE `{$this->tableName}` SET `participant` = :newOwner WHERE `participant` = :owner AND `type` = :type";
|
||||
$stmt = $this->execute($sql, $params);
|
||||
$stmt->closeCursor();
|
||||
$params = [
|
||||
'owner' => $ownerId,
|
||||
'newOwner' => $newOwnerId,
|
||||
'type' => Acl::PERMISSION_TYPE_USER
|
||||
];
|
||||
//We want preserve permissions from both users
|
||||
$sql = "UPDATE `{$this->tableName}` AS `source`
|
||||
LEFT JOIN `{$this->tableName}` AS `target`
|
||||
ON `target`.`participant` = :newOwner AND `target`.`type` = :type
|
||||
SET `source`.`permission_edit` =(`source`.`permission_edit` || `target`.`permission_edit`),
|
||||
`source`.`permission_share` =(`source`.`permission_share` || `target`.`permission_share`),
|
||||
`source`.`permission_manage` =(`source`.`permission_manage` || `target`.`permission_manage`)
|
||||
WHERE `source`.`participant` = :owner AND `source`.`type` = :type";
|
||||
$stmt = $this->execute($sql, $params);
|
||||
$stmt->closeCursor();
|
||||
//We can't transfer acl if target already in acl
|
||||
$sql = "DELETE FROM `{$this->tableName}`
|
||||
WHERE `participant` = :newOwner
|
||||
AND `type` = :type
|
||||
AND EXISTS (SELECT `id` FROM (SELECT `id` FROM `{$this->tableName}`
|
||||
WHERE `participant` = :owner AND `type` = :type) as tmp)";
|
||||
$stmt = $this->execute($sql, $params);
|
||||
$stmt->closeCursor();
|
||||
//Now we can transfer without errors
|
||||
$sqlUpdate = "UPDATE `{$this->tableName}`
|
||||
SET `participant` = :newOwner WHERE `participant` = :owner AND `type` = :type";
|
||||
$stmt = $this->execute($sqlUpdate, $params);
|
||||
$stmt->closeCursor();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -154,10 +154,17 @@ class AssignmentMapper extends QBMapper implements IPermissionMapper {
|
||||
*/
|
||||
public function transferOwnership($ownerId, $newOwnerId) {
|
||||
$params = [
|
||||
'owner' => $ownerId,
|
||||
'newOwner' => $newOwnerId,
|
||||
'type' => AssignedUsers::TYPE_USER
|
||||
];
|
||||
$sql = "DELETE FROM `{$this->tableName}` WHERE `participant` = :newOwner AND `type`= :type";
|
||||
$stmt = $this->execute($sql, $params);
|
||||
$stmt->closeCursor();
|
||||
$params = [
|
||||
'owner' => $ownerId,
|
||||
'newOwner' => $newOwnerId,
|
||||
'type' => AssignedUsers::TYPE_USER
|
||||
];
|
||||
$sql = "UPDATE `{$this->tableName}` SET `participant` = :newOwner WHERE `participant` = :owner AND `type`= :type";
|
||||
$stmt = $this->execute($sql, $params);
|
||||
$stmt->closeCursor();
|
||||
|
||||
Reference in New Issue
Block a user