From bd0aa664b84972693108e389f40c7e04423e41f8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 14 Feb 2019 13:58:15 +0100
Subject: [PATCH] Fix some eslint errors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 .eslintrc.js                                     | 2 +-
 src/components/Controls.vue                      | 7 ++++---
 src/components/Sidebar.vue                       | 2 +-
 src/components/board/Board.vue                   | 4 ++--
 src/components/cards/CardBadges.vue              | 7 +++++--
 src/components/cards/CardItem.vue                | 9 ++++++---
 src/components/navigation/AppNavigationBoard.vue | 2 ++
 src/mixins/color.js                              | 8 +++++---
 8 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 340cc1cfa..06874304a 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -40,7 +40,7 @@ module.exports = {
 		'no-tabs': 0,
 		'vue/html-indent': ['error', 'tab'],
 		// only debug console
-		'no-console': ['error', { allow: ['error', 'warn', 'debug'] }],
+		'no-console': ['warn', { allow: ['error', 'warn', 'debug'] }],
 		// classes blocks
 		'padded-blocks': ['error', { classes: 'always' }],
 		// always have the operator in front
diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index 24b99d34a..d3be7cec1 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -39,18 +39,19 @@
 			<div id="stack-add">
 				<form>
 					<label for="new-stack-input-main" class="hidden-visually">Add a new stack</label>
-					<input type="text" class="no-close" id="new-stack-input-main" placeholder="Add a new stack">
+					<input id="new-stack-input-main" type="text" class="no-close"
+						placeholder="Add a new stack">
 					<button class="button-inline icon icon-add" type="submit" title="Submit">
 						<span class="hidden-visually">Submit</span>
 					</button>
 				</form>
 			</div>
 			<button title="Show archived cards">
-				<i class="icon icon-archive"></i>
+				<i class="icon icon-archive" />
 				<span class="hidden-visually">Show archived cards</span>
 			</button>
 			<button title="Toggle compact mode">
-				<i class="icon icon-toggle-compact-expanded"></i>
+				<i class="icon icon-toggle-compact-expanded" />
 				<span class="hidden-visually">Toggle compact mode</span>
 			</button>
 			<router-link v-tooltip="t('deck', 'Board settings')" :to="{name: 'board.details'}" class="icon-settings"
diff --git a/src/components/Sidebar.vue b/src/components/Sidebar.vue
index e802cb48d..1c2bc7c06 100644
--- a/src/components/Sidebar.vue
+++ b/src/components/Sidebar.vue
@@ -25,7 +25,7 @@
 		<span class="icon-close" title="Close" @click="closeSidebar">
 			<span class="hidden-visually">Close</span>
 		</span>
-		<router-view name="sidebar"></router-view>
+		<router-view name="sidebar" />
 	</div>
 
 </template>
diff --git a/src/components/board/Board.vue b/src/components/board/Board.vue
index bc8c9e4c6..944eaf2ff 100644
--- a/src/components/board/Board.vue
+++ b/src/components/board/Board.vue
@@ -34,7 +34,7 @@
 					</container>
 					<div class="card create">
 						<div title="Add card">
-							<i class="icon icon-add"></i>
+							<i class="icon icon-add" />
 							<span class="hidden-visually">Add card</span>
 						</div>
 					</div>
@@ -53,7 +53,7 @@
 <script>
 
 import { Container, Draggable } from 'vue-smooth-dnd'
-import { mapState, mapGetters } from 'vuex'
+import { mapState } from 'vuex'
 import Controls from '../Controls'
 import CardItem from '../cards/CardItem'
 
diff --git a/src/components/cards/CardBadges.vue b/src/components/cards/CardBadges.vue
index 4fb829e59..6ace09e03 100644
--- a/src/components/cards/CardBadges.vue
+++ b/src/components/cards/CardBadges.vue
@@ -25,7 +25,7 @@
 		<i v-if="true" class="icon icon-description" title="" />
 		<span v-if="true" class="due">
 			<i class="icon icon-badge" />
-			<span data-timestamp="" class="live-relative-timestamp"></span>
+			<span data-timestamp="" class="live-relative-timestamp" />
 		</span>
 		<div v-if="true" class="card-tasks">
 			<i class="icon icon-checkmark" />
@@ -53,7 +53,10 @@ export default {
 	name: 'CardBadges',
 	components: { Avatar },
 	props: {
-		id: {}
+		id: {
+			type: Number,
+			default: null
+		}
 	},
 	computed: {
 		compactMode() {
diff --git a/src/components/cards/CardItem.vue b/src/components/cards/CardItem.vue
index 45046ea15..5cda023cd 100644
--- a/src/components/cards/CardItem.vue
+++ b/src/components/cards/CardItem.vue
@@ -21,7 +21,7 @@
   -->
 
 <template>
-	<div @click="openCard" tag="div" class="card">
+	<div tag="div" class="card" @click="openCard">
 		<div class="card-upper">
 			<h3>{{ card.title }}</h3>
 			<ul class="labels">
@@ -41,7 +41,7 @@
 </template>
 
 <script>
-import { Avatar, PopoverMenu } from 'nextcloud-vue'
+import { PopoverMenu } from 'nextcloud-vue'
 import ClickOutside from 'vue-click-outside'
 
 import CardBadges from './CardBadges'
@@ -55,7 +55,10 @@ export default {
 	},
 	mixins: [Color],
 	props: {
-		id: {}
+		id: {
+			type: Number,
+			default: null
+		}
 	},
 	data() {
 		return {
diff --git a/src/components/navigation/AppNavigationBoard.vue b/src/components/navigation/AppNavigationBoard.vue
index d62d75446..c487291d4 100644
--- a/src/components/navigation/AppNavigationBoard.vue
+++ b/src/components/navigation/AppNavigationBoard.vue
@@ -102,6 +102,8 @@ export default {
 			}
 		},
 		actions: function() {
+			/* eslint-disable vue/no-side-effects-in-computed-properties */
+			/* eslint-disable vue/no-async-in-computed-properties */
 			const actions = []
 
 			// do not show actions while the item is loading
diff --git a/src/mixins/color.js b/src/mixins/color.js
index 7f2397ebd..43d2b5cf2 100644
--- a/src/mixins/color.js
+++ b/src/mixins/color.js
@@ -24,12 +24,14 @@ export default {
 	methods: {
 		hexToRgb(hex) {
 			let result = /^#?([A-Fa-f\d]{2})([A-Fa-f\d]{2})([A-Fa-f\d]{2})$/i.exec(hex)
-			return result
-				? {
+			if (result) {
+				return {
 					r: parseInt(result[1], 16),
 					g: parseInt(result[2], 16),
 					b: parseInt(result[3], 16)
-				} : null
+				}
+			}
+			return null
 		},
 		rgb2hls(rgb) {
 			// RGB2HLS by Garry Tan