ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: clean attachment sharing records after permanent deleted

Browse Source 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
This commit is contained in:
Luka Trovic
2025-08-22 11:09:53 +02:00
parent 382c05ed8d
commit b80e0d9297
4 changed files with 61 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/Cron/DeleteCron.php
View File

@@ -14,6 +14,7 @@ use OCA\Deck\Db\CardMapper;
use OCA\Deck\Db\StackMapper;
use OCA\Deck\InvalidAttachmentType;
use OCA\Deck\Service\AttachmentService;
use OCA\Deck\Sharing\DeckShareProvider;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\BackgroundJob\IJob;
use OCP\BackgroundJob\TimedJob;
@@ -30,14 +31,25 @@ class DeleteCron extends TimedJob {
private $attachmentMapper;
/** @var StackMapper */
private $stackMapper;
/** @var DeckShareProvider */
private $deckShareProvider;
public function __construct(ITimeFactory $time, BoardMapper $boardMapper, CardMapper $cardMapper, AttachmentService $attachmentService, AttachmentMapper $attachmentMapper, StackMapper $stackMapper) {
public function __construct(
ITimeFactory $time,
BoardMapper $boardMapper,
CardMapper $cardMapper,
AttachmentService $attachmentService,
AttachmentMapper $attachmentMapper,
StackMapper $stackMapper,
DeckShareProvider $deckShareProvider,
) {
parent::__construct($time);
$this->boardMapper = $boardMapper;
$this->cardMapper = $cardMapper;
$this->attachmentService = $attachmentService;
$this->attachmentMapper = $attachmentMapper;
$this->stackMapper = $stackMapper;
$this->deckShareProvider = $deckShareProvider;
$this->setInterval(60 * 60 * 24);
$this->setTimeSensitivity(IJob::TIME_INSENSITIVE);
@@ -70,6 +82,12 @@ class DeleteCron extends TimedJob {
$this->attachmentMapper->delete($attachment);
}
// Delete orphaned attachment shares
$shares = $this->deckShareProvider->getOrphanedAttachmentShares();
foreach ($shares as $share) {
$this->deckShareProvider->delete($share);
}
$stacks = $this->stackMapper->findToDelete();
foreach ($stacks as $stack) {
$this->stackMapper->delete($stack);