ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Scrutinizer Auto-Fixes

Browse Source 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
This commit is contained in:
Scrutinizer Auto-Fixer
2018-05-12 11:10:23 +00:00
parent 08d9d51bea
commit b633d82c5e
17 changed files with 77 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/AppInfo/Application.php
View File

@@ -30,7 +30,6 @@ use OCA\Deck\Notification\Notifier;
use OCP\AppFramework\App; use OCP\AppFramework\App;
use OCA\Deck\Middleware\SharingMiddleware; use OCA\Deck\Middleware\SharingMiddleware;
use OCP\IGroup; use OCP\IGroup;
use OCP\IUser; use OCP\IUser;
use OCP\IUserManager; use OCP\IUserManager;
use OCP\IURLGenerator; use OCP\IURLGenerator;

4
lib/Db/RelationalEntity.php
View File

@@ -32,7 +32,7 @@ class RelationalEntity extends Entity implements \JsonSerializable {
/** /**
* Mark a property as relation so it will not get updated using Mapper::update * Mark a property as relation so it will not get updated using Mapper::update
* @param $property string Name of the property * @param string $property string Name of the property
*/ */
public function addRelation($property) { public function addRelation($property) {
if (!in_array($property, $this->_relations, true)) { if (!in_array($property, $this->_relations, true)) {
@@ -42,7 +42,7 @@ class RelationalEntity extends Entity implements \JsonSerializable {
/** /**
* Mark a property as resolvable via resolveRelation() * Mark a property as resolvable via resolveRelation()
* @param $property string Name of the property * @param string $property string Name of the property
*/ */
public function addResolvable($property) { public function addResolvable($property) {
$this->_resolvedProperties[$property] = null; $this->_resolvedProperties[$property] = null;

5
lib/Notification/NotificationHelper.php
View File

@@ -98,7 +98,7 @@ class NotificationHelper {
* Send notifications that a board was shared with a user/group * Send notifications that a board was shared with a user/group
* *
* @param $boardId * @param $boardId
* @param $acl * @param Acl $acl
* @throws \InvalidArgumentException * @throws \InvalidArgumentException
*/ */
public function sendBoardShared($boardId, $acl) { public function sendBoardShared($boardId, $acl) {
@@ -128,6 +128,9 @@ class NotificationHelper {
return $this->boards[$boardId]; return $this->boards[$boardId];
} }
/**
* @param Board $board
*/
private function generateBoardShared($board, $userId) { private function generateBoardShared($board, $userId) {
$notification = $this->notificationManager->createNotification(); $notification = $this->notificationManager->createNotification();
$notification $notification

3
lib/Service/CardService.php
View File

@@ -57,6 +57,9 @@ class CardService {
return $card; return $card;
} }
/**
* @param integer $order
*/
public function create($title, $stackId, $type, $order, $owner) { public function create($title, $stackId, $type, $order, $owner) {
$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT); $this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
if ($this->boardService->isArchived($this->stackMapper, $stackId)) { if ($this->boardService->isArchived($this->stackMapper, $stackId)) {

5
lib/Service/StackService.php
View File

@@ -27,9 +27,7 @@ use OCA\Deck\Db\Acl;
use OCA\Deck\Db\CardMapper; use OCA\Deck\Db\CardMapper;
use OCA\Deck\Db\LabelMapper; use OCA\Deck\Db\LabelMapper;
use OCA\Deck\Db\AssignedUsersMapper; use OCA\Deck\Db\AssignedUsersMapper;
use OCA\Deck\Db\Stack; use OCA\Deck\Db\Stack;
use OCA\Deck\Db\StackMapper; use OCA\Deck\Db\StackMapper;
use OCA\Deck\StatusException; use OCA\Deck\StatusException;
@@ -93,6 +91,9 @@ class StackService {
return $stacks; return $stacks;
} }
/**
* @param integer $order
*/
public function create($title, $boardId, $order) { public function create($title, $boardId, $order) {
$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE); $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
if ($this->boardService->isArchived(null, $boardId)) { if ($this->boardService->isArchived(null, $boardId)) {