ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

optimize sql queries / indexing

Browse Source 
Signed-off-by: chandi Langecker <git@chandi.it>
This commit is contained in:
chandi Langecker
2022-09-05 13:56:15 +02:00
parent b3d4ac5218
commit af134959ce
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Db/SessionMapper.php
View File

@@ -38,9 +38,7 @@ class SessionMapper extends QBMapper {
$qb = $this->db->getQueryBuilder(); $qb = $this->db->getQueryBuilder();
$result = $qb->select('*') $result = $qb->select('*')
->from($this->getTableName()) ->from($this->getTableName())
->where($qb->expr()->eq('board_id', $qb->createNamedParameter($boardId))) ->where($qb->expr()->eq('token', $qb->createNamedParameter($token)))
->andWhere($qb->expr()->eq('user_id', $qb->createNamedParameter($userId)))
->andWhere($qb->expr()->eq('token', $qb->createNamedParameter($token)))
->andWhere($qb->expr()->gt('last_contact', $qb->createNamedParameter(time() - SessionService::SESSION_VALID_TIME))) ->andWhere($qb->expr()->gt('last_contact', $qb->createNamedParameter(time() - SessionService::SESSION_VALID_TIME)))
->executeQuery(); ->executeQuery();
@@ -49,7 +47,11 @@ class SessionMapper extends QBMapper {
if ($data === false) { if ($data === false) {
throw new DoesNotExistException('Session is invalid'); throw new DoesNotExistException('Session is invalid');
} }
return Session::fromRow($data); $session = Session::fromRow($data);
if ($session->getUserId() != $userId || $session->getBoardId() != $boardId) {
throw new DoesNotExistException('Session is invalid');
}
return $session;
} }
public function findAllActive($boardId) { public function findAllActive($boardId) {

2
lib/Migration/Version10900Date202206151724222.php
View File

@@ -58,8 +58,8 @@ class Version10900Date202206151724222 extends SimpleMigrationStep {
'unsigned' => true, 'unsigned' => true,
]); ]);
$table->setPrimaryKey(['id']); $table->setPrimaryKey(['id']);
$table->addIndex(['board_id'], 'rd_session_board_id_idx');
$table->addIndex(['token'], 'rd_session_token_idx'); $table->addIndex(['token'], 'rd_session_token_idx');
$table->addIndex(['last_contact'], 'ts_lastcontact');
} }
return $schema; return $schema;
} }