ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix tests

Browse Source 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
This commit is contained in:
Julien Veyssier
2022-09-07 17:15:48 +02:00
parent 5b2c03f733
commit a89bdab5e3
1 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/unit/Service/AttachmentServiceTest.php
View File

@@ -37,6 +37,7 @@ use OCA\Deck\NotFoundException;
use OCP\AppFramework\Http\Response; use OCP\AppFramework\Http\Response;
use OCP\AppFramework\IAppContainer; use OCP\AppFramework\IAppContainer;
use OCP\IL10N; use OCP\IL10N;
use OCP\IUserManager;
use PHPUnit\Framework\MockObject\MockObject; use PHPUnit\Framework\MockObject\MockObject;
use Test\TestCase; use Test\TestCase;
@@ -60,6 +61,8 @@ class MyAttachmentService implements IAttachmentService {
class AttachmentServiceTest extends TestCase { class AttachmentServiceTest extends TestCase {
/** @var IUserManager|MockObject */
private $userManager;
/** @var AttachmentMapper|MockObject */ /** @var AttachmentMapper|MockObject */
private $attachmentMapper; private $attachmentMapper;
/** @var CardMapper|MockObject */ /** @var CardMapper|MockObject */
@@ -98,6 +101,7 @@ class AttachmentServiceTest extends TestCase {
$this->appContainer = $this->createMock(IAppContainer::class); $this->appContainer = $this->createMock(IAppContainer::class);
$this->userManager = $this->createMock(IUserManager::class);
$this->attachmentMapper = $this->createMock(AttachmentMapper::class); $this->attachmentMapper = $this->createMock(AttachmentMapper::class);
$this->cardMapper = $this->createMock(CardMapper::class); $this->cardMapper = $this->createMock(CardMapper::class);
$this->permissionService = $this->createMock(PermissionService::class); $this->permissionService = $this->createMock(PermissionService::class);
@@ -126,6 +130,7 @@ class AttachmentServiceTest extends TestCase {
$this->attachmentService = new AttachmentService( $this->attachmentService = new AttachmentService(
$this->attachmentMapper, $this->attachmentMapper,
$this->cardMapper, $this->cardMapper,
$this->userManager,
$this->changeHelper, $this->changeHelper,
$this->permissionService, $this->permissionService,
$this->application, $this->application,
@@ -158,7 +163,7 @@ class AttachmentServiceTest extends TestCase {
$application->expects($this->any()) $application->expects($this->any())
->method('getContainer') ->method('getContainer')
->willReturn($appContainer); ->willReturn($appContainer);
$attachmentService = new AttachmentService($this->attachmentMapper, $this->cardMapper, $this->changeHelper, $this->permissionService, $application, $this->attachmentCacheHelper, $this->userId, $this->l10n, $this->activityManager); $attachmentService = new AttachmentService($this->attachmentMapper, $this->cardMapper, $this->userManager, $this->changeHelper, $this->permissionService, $application, $this->attachmentCacheHelper, $this->userId, $this->l10n, $this->activityManager);
$attachmentService->registerAttachmentService('custom', MyAttachmentService::class); $attachmentService->registerAttachmentService('custom', MyAttachmentService::class);
$this->assertEquals($fileServiceMock, $attachmentService->getService('deck_file')); $this->assertEquals($fileServiceMock, $attachmentService->getService('deck_file'));
$this->assertEquals(MyAttachmentService::class, get_class($attachmentService->getService('custom'))); $this->assertEquals(MyAttachmentService::class, get_class($attachmentService->getService('custom')));
@@ -188,7 +193,7 @@ class AttachmentServiceTest extends TestCase {
->method('getContainer') ->method('getContainer')
->willReturn($appContainer); ->willReturn($appContainer);
$attachmentService = new AttachmentService($this->attachmentMapper, $this->cardMapper, $this->changeHelper, $this->permissionService, $application, $this->attachmentCacheHelper, $this->userId, $this->l10n, $this->activityManager); $attachmentService = new AttachmentService($this->attachmentMapper, $this->cardMapper, $this->userManager, $this->changeHelper, $this->permissionService, $application, $this->attachmentCacheHelper, $this->userId, $this->l10n, $this->activityManager);
$attachmentService->registerAttachmentService('custom', MyAttachmentService::class); $attachmentService->registerAttachmentService('custom', MyAttachmentService::class);
$attachmentService->getService('deck_file_invalid'); $attachmentService->getService('deck_file_invalid');
} }
@@ -296,7 +301,14 @@ class AttachmentServiceTest extends TestCase {
$actual = $this->attachmentService->create(123, 'deck_file', 'file_name.jpg'); $actual = $this->attachmentService->create(123, 'deck_file', 'file_name.jpg');
$expected->setExtendedData(['mime' => 'image/jpeg']); $expected->setExtendedData([
'mime' => 'image/jpeg',
'attachmentCreator' => [
'displayName' => '',
'id' => '',
'email' => null,
],
]);
$this->assertEquals($expected, $actual); $this->assertEquals($expected, $actual);
} }
@@ -353,7 +365,14 @@ class AttachmentServiceTest extends TestCase {
$actual = $this->attachmentService->update(1, 1, 'file_name.jpg'); $actual = $this->attachmentService->update(1, 1, 'file_name.jpg');
$expected->setExtendedData(['mime' => 'image/jpeg']); $expected->setExtendedData([
'mime' => 'image/jpeg',
'attachmentCreator' => [
'displayName' => '',
'id' => '',
'email' => null,
],
]);
$expected->setLastModified($attachment->getLastModified()); $expected->setLastModified($attachment->getLastModified());
$this->assertEquals($expected, $actual); $this->assertEquals($expected, $actual);
} }