From 9595e00ae115ace59a48c1dc0b81410e8db659a8 Mon Sep 17 00:00:00 2001 From: steav Date: Wed, 25 Jul 2018 23:21:29 +0200 Subject: [PATCH] Do not send card assignment notifications to ourselves Signed-off-by: steav --- lib/Service/CardService.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Service/CardService.php b/lib/Service/CardService.php index 83188de0b..a9b7ae7a2 100644 --- a/lib/Service/CardService.php +++ b/lib/Service/CardService.php @@ -43,8 +43,9 @@ class CardService { private $notificationHelper; private $assignedUsersMapper; private $attachmentService; + private $currentUser; - public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService, BoardService $boardService, NotificationHelper $notificationHelper, AssignedUsersMapper $assignedUsersMapper, AttachmentService $attachmentService) { + public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService, BoardService $boardService, NotificationHelper $notificationHelper, AssignedUsersMapper $assignedUsersMapper, AttachmentService $attachmentService, $userId) { $this->cardMapper = $cardMapper; $this->stackMapper = $stackMapper; $this->permissionService = $permissionService; @@ -52,6 +53,7 @@ class CardService { $this->notificationHelper = $notificationHelper; $this->assignedUsersMapper = $assignedUsersMapper; $this->attachmentService = $attachmentService; + $this->currentUser = $userId; } public function find($cardId) { @@ -206,9 +208,11 @@ class CardService { } } - /* Notify user about the card assignment */ - $card = $this->cardMapper->find($cardId); - $this->notificationHelper->sendCardAssigned($card, $userId); + if ($userId !== $this->currentUser) { + /* Notifyuser about the card assignment */ + $card = $this->cardMapper->find($cardId); + $this->notificationHelper->sendCardAssigned($card, $userId); + } $assignment = new AssignedUsers(); $assignment->setCardId($cardId);