diff --git a/lib/Db/BoardMapper.php b/lib/Db/BoardMapper.php index 834475307..16de38a3c 100644 --- a/lib/Db/BoardMapper.php +++ b/lib/Db/BoardMapper.php @@ -25,9 +25,9 @@ namespace OCA\Deck\Db; use OCP\AppFramework\Db\DoesNotExistException; use OCP\IDBConnection; -use OCP\ILogger; use OCP\IUserManager; use OCP\IGroupManager; +use Psr\Log\LoggerInterface; class BoardMapper extends DeckMapper implements IPermissionMapper { private $labelMapper; @@ -35,6 +35,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { private $stackMapper; private $userManager; private $groupManager; + private $logger; private $circlesEnabled; @@ -44,7 +45,8 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { AclMapper $aclMapper, StackMapper $stackMapper, IUserManager $userManager, - IGroupManager $groupManager + IGroupManager $groupManager, + LoggerInterface $logger ) { parent::__construct($db, 'deck_boards', Board::class); $this->labelMapper = $labelMapper; @@ -52,6 +54,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { $this->stackMapper = $stackMapper; $this->userManager = $userManager; $this->groupManager = $groupManager; + $this->logger = $logger; $this->circlesEnabled = \OC::$server->getAppManager()->isEnabledForUser('circles'); } @@ -248,7 +251,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { if ($user !== null) { return new User($user); } - \OC::$server->getLogger()->debug('User ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant()); + $this->logger->debug('User ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant()); return null; } if ($acl->getType() === Acl::PERMISSION_TYPE_GROUP) { @@ -256,7 +259,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { if ($group !== null) { return new Group($group); } - \OC::$server->getLogger()->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant()); + $this->logger->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant()); return null; } if ($acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) { @@ -268,11 +271,12 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { if ($circle) { return new Circle($circle); } - } catch (\Exception $e) { + } catch (\Throwable $e) { + $this->logger->error('Failed to get circle details when building ACL', ['exception' => $e]); } return null; } - \OC::$server->getLogger()->log(ILogger::WARN, 'Unknown permission type for mapping acl ' . $acl->getId()); + $this->logger->warning('Unknown permission type for mapping acl ' . $acl->getId()); return null; }); } diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml index 7145e7996..16058795f 100644 --- a/tests/psalm-baseline.xml +++ b/tests/psalm-baseline.xml @@ -105,7 +105,8 @@ $boardId - + + \OCA\Circles\Api\v1\Circles \OCA\Circles\Api\v1\Circles @@ -170,11 +171,6 @@ $stackId - - - $board->getId() - - (string) $l->t('%s has mentioned you in a comment on "%s".', [$dn, $params[0]]) @@ -196,12 +192,6 @@ $cardId $cardId - - $this->currentUser - - - $this->currentUser - @@ -265,7 +255,6 @@ - $this->rootFolder $this->rootFolder @@ -279,13 +268,6 @@ \OCA\Circles\Api\v1\Circles - - - $this->l10n - $this->urlGenerator - $this->userManager - - BadRquestException diff --git a/tests/unit/Db/AclMapperTest.php b/tests/unit/Db/AclMapperTest.php index 97d57ef54..f720fdb1a 100644 --- a/tests/unit/Db/AclMapperTest.php +++ b/tests/unit/Db/AclMapperTest.php @@ -25,6 +25,7 @@ namespace OCA\Deck\Db; use OCP\IGroupManager; use OCP\IUserManager; +use Psr\Log\LoggerInterface; use Test\AppFramework\Db\MapperTestUtility; /** @@ -54,7 +55,8 @@ class AclMapperTest extends MapperTestUtility { $this->aclMapper, \OC::$server->query(StackMapper::class), $this->userManager, - $this->groupManager + $this->groupManager, + $this->createMock(LoggerInterface::class) ); $this->boards = [ diff --git a/tests/unit/Db/BoardMapperTest.php b/tests/unit/Db/BoardMapperTest.php index 2b6ff56ff..78cc0cccc 100644 --- a/tests/unit/Db/BoardMapperTest.php +++ b/tests/unit/Db/BoardMapperTest.php @@ -26,6 +26,7 @@ namespace OCA\Deck\Db; use OCP\IDBConnection; use OCP\IGroupManager; use OCP\IUserManager; +use Psr\Log\LoggerInterface; use Test\AppFramework\Db\MapperTestUtility; /** @@ -61,7 +62,8 @@ class BoardMapperTest extends MapperTestUtility { \OC::$server->query(AclMapper::class), \OC::$server->query(StackMapper::class), $this->userManager, - $this->groupManager + $this->groupManager, + $this->createMock(LoggerInterface::class) ); $this->aclMapper = \OC::$server->query(AclMapper::class); $this->labelMapper = \OC::$server->query(LabelMapper::class);