JS: Fix scrutinizer warnings and indentation for filters

Signed-off-by: Julius Härtl <jus@bitgrid.net>

js/controller/AppController.js

@@ -20,6 +20,7 @@
  *  
  */
 
+/** global: OC */
 app.controller('AppController', function ($scope, $location, $http, $route, $log, $rootScope, $stateParams) {
 	$rootScope.sidebar = {
 		show: false

js/controller/BoardController.js

@@ -20,6 +20,7 @@
  *  
  */
 
+/** global: oc_defaults */
 app.controller('BoardController', function ($rootScope, $scope, $stateParams, StatusService, BoardService, StackService, CardService, LabelService, $state, $transitions, $filter) {
 
 	$scope.sidebar = $rootScope.sidebar;

js/filters/iconWhiteFilter.js

@@ -30,7 +30,9 @@ app.filter('iconWhiteFilter', function() {
 			g: parseInt(result[2], 16),
 			b: parseInt(result[3], 16)
 		} : null;
-		if(result !== null) {
+		if (result === null) {
+			return "";
+		}
 		var r = color.r / 255;
 		var g = color.g / 255;
 		var b = color.b / 255;
@@ -43,23 +45,22 @@ app.filter('iconWhiteFilter', function() {
 			var d = max - min;
 			s = l > 0.5 ? d / (2 - max - min) : d / (max + min);
 			switch (max) {
-					case r: h = (g - b) / d + (g < b ? 6 : 0); break;
-					case g: h = (b - r) / d + 2; break;
-					case b: h = (r - g) / d + 4; break;
+				case r:
+					h = (g - b) / d + (g < b ? 6 : 0);
+					break;
+				case g:
+					h = (b - r) / d + 2;
+					break;
+				case b:
+					h = (r - g) / d + 4;
+					break;
 			}
 			h /= 6;
 		}
-			// TODO: Maybe just darken/lighten the color
 		if (l < 0.5) {
 			return "-white";
 		} else {
 			return "";
 		}
-			//var rgba = "rgba(" + color.r + "," + color.g + "," + color.b + ",0.7)";
-			//return rgba;
-		} else {
-			return "";
-		}
-
 	}
 });

js/filters/textColorFilter.js

@@ -43,9 +43,15 @@ app.filter('textColorFilter', function() {
 				var d = max - min;
 				s = l > 0.5 ? d / (2 - max - min) : d / (max + min);
 				switch (max) {
-					case r: h = (g - b) / d + (g < b ? 6 : 0); break;
-					case g: h = (b - r) / d + 2; break;
-					case b: h = (r - g) / d + 4; break;
+					case r:
+						h = (g - b) / d + (g < b ? 6 : 0);
+						break;
+					case g:
+						h = (b - r) / d + 2;
+						break;
+					case b:
+						h = (r - g) / d + 4;
+						break;
 				}
 				h /= 6;
 			}