ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

perf: Use getBoard to get the board

Browse Source 
So that this can benefit from a local cache

Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>
This commit is contained in:
Carl Schwan
2025-08-13 13:34:03 +02:00
parent ce81c89b03
commit 8ebeeaa755
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Service/PermissionService.php
View File

@@ -214,7 +214,7 @@ class PermissionService {
} }
try { try {
$board = $this->boardMapper->find($boardId); $board = $this->getBoard($boardId);
} catch (DoesNotExistException $e) { } catch (DoesNotExistException $e) {
return []; return [];
} catch (MultipleObjectsReturnedException $e) { } catch (MultipleObjectsReturnedException $e) {
@@ -227,7 +227,7 @@ class PermissionService {
} else { } else {
$users[$board->getOwner()] = new User($board->getOwner(), $this->userManager); $users[$board->getOwner()] = new User($board->getOwner(), $this->userManager);
} }
$acls = $this->aclMapper->findAll($boardId); $acls = $board->getAcl();
/** @var Acl $acl */ /** @var Acl $acl */
foreach ($acls as $acl) { foreach ($acls as $acl) {
if ($acl->getType() === Acl::PERMISSION_TYPE_USER) { if ($acl->getType() === Acl::PERMISSION_TYPE_USER) {

5
tests/unit/Service/PermissionServiceTest.php
View File

@@ -347,9 +347,8 @@ class PermissionServiceTest extends \Test\TestCase {
->method('__call') ->method('__call')
->with('getOwner', []) ->with('getOwner', [])
->willReturn('user1'); ->willReturn('user1');
$this->aclMapper->expects($this->once()) $board->expects($this->any())
->method('findAll') ->method('getAcl')
->with(123)
->willReturn([$aclUser, $aclGroup]); ->willReturn([$aclUser, $aclGroup]);
$this->boardMapper->expects($this->once()) $this->boardMapper->expects($this->once())
->method('find') ->method('find')