diff --git a/lib/Service/DefaultBoardService.php b/lib/Service/DefaultBoardService.php index 8f3a7cdf9..f79b8d24e 100644 --- a/lib/Service/DefaultBoardService.php +++ b/lib/Service/DefaultBoardService.php @@ -57,11 +57,11 @@ class DefaultBoardService { } public function checkFirstRun($userId, $appName) { - $firstRun = $this->config->getUserValue($userId,$appName,'firstRun','yes'); + $firstRun = $this->config->getUserValue($userId, $appName, 'firstRun', 'yes'); $userBoards = $this->boardMapper->findAllByUser($userId); if ($firstRun === 'yes' && count($userBoards) === 0) { - $this->config->setUserValue($userId,$appName,'firstRun','no'); + $this->config->setUserValue($userId, $appName, 'firstRun', 'no'); return true; } diff --git a/tests/unit/Service/DefaultBoardServiceTest.php b/tests/unit/Service/DefaultBoardServiceTest.php index dcac93ca8..0eecd8eee 100644 --- a/tests/unit/Service/DefaultBoardServiceTest.php +++ b/tests/unit/Service/DefaultBoardServiceTest.php @@ -66,11 +66,7 @@ class DefaultBoardServiceTest extends TestCase { $this->stackService = $this->createMock(StackService::class); $this->cardService = $this->createMock(CardService::class); $this->config = $this->createMock(IConfig::class); - - $this->l10n = $this->request = $this->getMockBuilder( - '\OCP\IL10n') - ->disableOriginalConstructor() - ->getMock(); + $this->l10n = $this->createMock(IL10N::class); $this->service = new DefaultBoardService( $this->l10n, @@ -83,7 +79,7 @@ class DefaultBoardServiceTest extends TestCase { } public function testCheckFirstRunCaseTrue() { - $appName = "Deck"; + $appName = 'deck'; $userBoards = []; $this->config->expects($this->once()) @@ -102,7 +98,7 @@ class DefaultBoardServiceTest extends TestCase { } public function testCheckFirstRunCaseFalse() { - $appName = "deck"; + $appName = 'deck'; $board = new Board(); $board->setTitle('Personal'); $board->setOwner($this->userId); diff --git a/tests/unit/controller/PageControllerTest.php b/tests/unit/controller/PageControllerTest.php index ce0d40b2a..f4aa70e08 100644 --- a/tests/unit/controller/PageControllerTest.php +++ b/tests/unit/controller/PageControllerTest.php @@ -59,7 +59,7 @@ class PageControllerTest extends \Test\TestCase { public function testIndexOnFirstRun() { $board = new Board(); - $board->setTitle("Personal"); + $board->setTitle('Personal'); $board->setOwner($this->userId); $board->setColor('000000'); @@ -77,7 +77,7 @@ class PageControllerTest extends \Test\TestCase { public function testIndexOnSecondRun() { - $this->config->setUserValue($this->userId,'deck','firstRun','no'); + $this->config->setUserValue($this->userId, 'deck', 'firstRun', 'no'); $this->defaultBoardService->expects($this->once()) ->method('checkFirstRun')