ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

simple code style changes according to codacy standards.

Browse Source 
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
This commit is contained in:
Ryan Fletcher
2018-07-15 23:20:16 -04:00
committed by Julius Härtl
parent 570ac81848
commit 8cac183af6
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/Controller/StackApiController.php
View File

@@ -42,8 +42,7 @@ use OCA\Deck\Controller\Helper\ApiHelper;
class StackApiController extends ApiController { class StackApiController extends ApiController {
private $boardService; private $boardService;
private $stackService; private $stackService;
private $userInfo;
private $apiHelper; private $apiHelper;
/** /**
@@ -53,7 +52,7 @@ class StackApiController extends ApiController {
*/ */
public function __construct($appName, IRequest $request, StackService $stackService, BoardService $boardService) { public function __construct($appName, IRequest $request, StackService $stackService, BoardService $boardService) {
parent::__construct($appName, $request); parent::__construct($appName, $request);
$this->service = $stackService; $this->stackService = $stackService;
$this->boardService = $boardService; $this->boardService = $boardService;
$this->apiHelper = new ApiHelper(); $this->apiHelper = new ApiHelper();
} }
@@ -72,7 +71,7 @@ class StackApiController extends ApiController {
return new DataResponse($boardError['message'], $boardError['status']); return new DataResponse($boardError['message'], $boardError['status']);
} }
$stacks = $this->service->findAll($this->request->getParam('boardId')); $stacks = $this->stackService->findAll($this->request->getParam('boardId'));
return new DataResponse($stacks, HTTP::STATUS_OK); return new DataResponse($stacks, HTTP::STATUS_OK);
} }
@@ -95,7 +94,7 @@ class StackApiController extends ApiController {
return new DataResponse($boardError['message'], $boardError['status']); return new DataResponse($boardError['message'], $boardError['status']);
} }
$stack = $this->service->find($this->request->getParam('stackId')); $stack = $this->stackService->find($this->request->getParam('stackId'));
if ($stack === false || $stack === null) { if ($stack === false || $stack === null) {
return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND); return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND);
@@ -130,7 +129,7 @@ class StackApiController extends ApiController {
return new DataResponse($boardError['message'], $boardError['status']); return new DataResponse($boardError['message'], $boardError['status']);
} }
$stack = $this->service->create($title, $this->request->getParam('boardId'), $order); $stack = $this->stackService->create($title, $this->request->getParam('boardId'), $order);
return new DataResponse($stack, HTTP::STATUS_OK); return new DataResponse($stack, HTTP::STATUS_OK);
} }
@@ -162,7 +161,7 @@ class StackApiController extends ApiController {
} }
try { try {
$stack = $this->service->update($this->request->getParam('stackId'), $title, $this->request->getParam('boardId'), $order); $stack = $this->stackService->update($this->request->getParam('stackId'), $title, $this->request->getParam('boardId'), $order);
if ($stack === false || $stack === null) { if ($stack === false || $stack === null) {
return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND); return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND);
@@ -193,7 +192,7 @@ class StackApiController extends ApiController {
return new DataResponse('stack id must be a number', HTTP::STATUS_BAD_REQUEST); return new DataResponse('stack id must be a number', HTTP::STATUS_BAD_REQUEST);
} }
$stack = $this->service->delete($this->request->getParam('stackId')); $stack = $this->stackService->delete($this->request->getParam('stackId'));
if ($stack == false || $stack == null) { if ($stack == false || $stack == null) {
return new DataResponse('Stack Not Found', HTTP::STATUS_NOT_FOUND); return new DataResponse('Stack Not Found', HTTP::STATUS_NOT_FOUND);