Merge pull request #2517 from nextcloud/bugfix/2482

Filter out duplicate cards in overview
This commit is contained in:
Julius Härtl
2020-11-11 08:23:06 +01:00
committed by GitHub
3 changed files with 6 additions and 10 deletions

View File

@@ -86,6 +86,10 @@ class RelationalEntity extends Entity implements \JsonSerializable {
return $json;
}
public function __toString(): string {
return (string)$this->getId();
}
/*
* Resolve relational data from external methods
*

View File

@@ -119,15 +119,7 @@ class BoardService {
$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since, $includeArchived);
$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null, $since, $includeArchived);
$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null, $since, $includeArchived);
$mergedBoards = array_merge($userBoards, $groupBoards, $circleBoards);
$result = [];
/** @var Board $item */
foreach ($mergedBoards as &$item) {
if (!array_key_exists($item->getId(), $result)) {
$result[$item->getId()] = $item;
}
}
return array_values($result);
return array_unique(array_merge($userBoards, $groupBoards, $circleBoards));
}
/**
* @return array

View File

@@ -140,7 +140,7 @@ class OverviewService {
$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null);
$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null);
$circleBoards = $this->boardMapper->findAllByCircles($userInfo['user'], null, null);
return array_merge($userBoards, $groupBoards, $circleBoards);
return array_unique(array_merge($userBoards, $groupBoards, $circleBoards));
}
private function getBoardPrerequisites($userId): array {