From 47e3aad1b79742d51078ec5781171de4ff73fac2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Tue, 7 May 2019 14:01:38 +0200 Subject: [PATCH] Only map circles if the app is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- lib/Db/BoardMapper.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Db/BoardMapper.php b/lib/Db/BoardMapper.php index 363916172..db65993c8 100644 --- a/lib/Db/BoardMapper.php +++ b/lib/Db/BoardMapper.php @@ -26,6 +26,7 @@ namespace OCA\Deck\Db; use OCP\AppFramework\Db\DoesNotExistException; use OCP\AppFramework\QueryException; use OCP\IDBConnection; +use OCP\ILogger; use OCP\IUserManager; use OCP\IGroupManager; @@ -234,7 +235,7 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { \OC::$server->getLogger()->debug('Group ' . $acl->getId() . ' not found when mapping acl ' . $acl->getParticipant()); return null; } - if ($acl->getType() === Acl::PERMISSION_TYPE_CIRCLE) { + if ($acl->getType() === Acl::PERMISSION_TYPE_CIRCLE && $this->circlesEnabled) { try { $circle = \OCA\Circles\Api\v1\Circles::detailsCircle($acl->getParticipant(), true); if ($circle) { @@ -244,7 +245,8 @@ class BoardMapper extends DeckMapper implements IPermissionMapper { } return null; } - throw new \Exception('Unknown permission type for mapping Acl'); + \OC::$server->getLogger()->log(ILogger::WARN, 'Unknown permission type for mapping acl ' . $acl->getId()); + return null; }); }