From 857a82ecfface3c30cd2a8127bfec7afb8589d55 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Fri, 17 Nov 2023 10:30:08 +0100
Subject: [PATCH] fix: Show proper error page when board was not found
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/components/board/Board.vue | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/components/board/Board.vue b/src/components/board/Board.vue
index f41cf81bb..a2931c29b 100644
--- a/src/components/board/Board.vue
+++ b/src/components/board/Board.vue
@@ -30,6 +30,11 @@
 				<h2>{{ t('deck', 'Loading board') }}</h2>
 				<p />
 			</div>
+			<div v-else-if="!board" key="notfound" class="emptycontent">
+				<div class="icon icon-deck" />
+				<h2>{{ t('deck', 'Board not found') }}</h2>
+				<p />
+			</div>
 			<NcEmptyContent v-else-if="isEmpty" key="empty">
 				<template #icon>
 					<DeckIcon />
@@ -70,11 +75,6 @@
 					</Draggable>
 				</Container>
 			</div>
-			<div v-else key="notfound" class="emptycontent">
-				<div class="icon icon-deck" />
-				<h2>{{ t('deck', 'Board not found') }}</h2>
-				<p />
-			</div>
 		</transition>
 		<GlobalSearchResults />
 	</div>
@@ -140,12 +140,6 @@ export default {
 	},
 	watch: {
 		id(newValue, oldValue) {
-			if (this.session) {
-				// close old session
-				this.session.close()
-			}
-			this.session = createSession(newValue)
-
 			this.fetchData()
 		},
 		showArchived() {
@@ -165,11 +159,16 @@ export default {
 			try {
 				await this.$store.dispatch('loadBoardById', this.id)
 				await this.$store.dispatch('loadStacks', this.id)
+
+				this.session?.close()
+				this.session = createSession(this.id)
 			} catch (e) {
+				this.loading = false
 				console.error(e)
 				showError(e)
+			} finally {
+				this.loading = false
 			}
-			this.loading = false
 		},
 
 		onDropStack({ removedIndex, addedIndex }) {